Skip to contentSkip to conversation

kexec-tools: Add --append option for s390

PATCH In review Michael Holzheu 2 participants 2 messages Sep 7, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kexec-tools: Add --append option for s390

Hello Simon,

From: Michael Holzheu <[email protected]>

All architectures define the "--append" option together with the "--command-line" option to specify kernel parameters. This option is also used by kdump init scripts. In order to be compatible this patch introduces the "--append" option also for s390. In addition to that the help text is adjusted so that it is now the same as on all other architectures.

---
 kexec/arch/s390/include/arch/options.h |    1 +
 kexec/arch/s390/kexec-image.c          |    4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)
kexec/arch/s390/include/arch/options.h +1 -0
@@ -30,6 +30,7 @@
 #define KEXEC_ALL_OPTIONS				\
 	KEXEC_ARCH_OPTIONS				\
 	{"command-line",     1, 0, OPT_APPEND},		\
+	{"append",           1, 0, OPT_APPEND},		\
 	{"initrd",	     1, 0, OPT_RAMDISK},
 
 #define KEXEC_ALL_OPT_STR KEXEC_ARCH_OPT_STR
kexec/arch/s390/kexec-image.c +3 -1
@@ -61,6 +61,7 @@ image_s390_load(int argc, char **argv, c
 		{
 			KEXEC_OPTIONS
 			{"command-line",     1, 0, OPT_APPEND},
+			{"append",           1, 0, OPT_APPEND},
 			{"initrd",           1, 0, OPT_RAMDISK},
 			{0,                  0, 0, 0},
 		};
@@ -160,7 +161,8 @@ image_s390_probe(const char *UNUSED(kern
 void
 image_s390_usage(void)
 {
-	printf("--command-line=STRING Pass a custom command line STRING to the kernel.\n"
+	printf("--command-line=STRING Set the kernel command line to STRING.\n"
+	       "--append=STRING       Set the kernel command line to STRING.\n"
 	       "--initrd=FILENAME     Use the file FILENAME as a ramdisk.\n"
 		);
 }

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#1 lore raw
Quoted 10 lines · Michael Holzheu

Hello Simon,

From: Michael Holzheu <[email protected]>

All architectures define the "--append" option together with the "--command-line" option to specify kernel parameters. This option is also used by kdump init scripts. In order to be compatible this patch introduces the "--append" option also for s390. In addition to that the help text is adjusted so that it is now the same as on all other architectures.

Thanks, that looks good to me.

I have applied it to my local tree and push it once master.kernel.org is available again.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec