Skip to contentSkip to conversation

tzcode-native, tzdata: remove recipes from meta-oe

PATCH In review Andrea Adami 3 participants 4 messages Sep 16, 2011 – Oct 4, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tzcode-native, tzdata: remove recipes from meta-oe

* Up-to-date versions are maintained in oe-core.
*
* What is bad is the newer recipes in the oe-core layer
* are masked and bitbake only sees the recipes in meta-oe
* thus -> NOTE: package tzdata-2011g-r10.0: task do_fetch: Failed *
* For the (mis)feature see
* http://lists.linuxtogo.org/pipermail/bitbake-devel/2011-August/001169.html

---
 meta-oe/recipes-extended/tzcode/tzcode-native.inc  |   18 --
 .../recipes-extended/tzcode/tzcode-native_2011i.bb |   20 ---
 meta-oe/recipes-extended/tzdata/tzdata.inc         |  177 --------------------
 meta-oe/recipes-extended/tzdata/tzdata_2011g.bb    |   12 --
 4 files changed, 0 insertions(+), 227 deletions(-)
 delete mode 100644 meta-oe/recipes-extended/tzcode/tzcode-native.inc
 delete mode 100644 meta-oe/recipes-extended/tzcode/tzcode-native_2011i.bb
 delete mode 100644 meta-oe/recipes-extended/tzdata/tzdata.inc
 delete mode 100644 meta-oe/recipes-extended/tzdata/tzdata_2011g.bb
meta-oe/recipes-extended/tzcode/tzcode-native.inc deleted +0 -18
deleted file mode 100644
index b946e71..0000000
@@ -1,18 +0,0 @@
-DESCRIPTION = "tzcode, timezone zoneinfo utils -- zic, zdump, tzselect"
-INC_PR = "r4"
-
-SRC_URI = " \
-        ftp://elsie.nci.nih.gov/pub/tzcode${PV}.tar.gz;name=tzcode-${PV};subdir=${BPN}-${PV} \
-        ftp://elsie.nci.nih.gov/pub/tzdata${TZDATA_PV}.tar.gz;name=tzdata-${TZDATA_PV};subdir=${BPN}-${PV} \
-	"
-
-inherit native
-
-do_install () {
-        install -d ${D}${bindir}
-        install -m 755 zic ${D}${bindir}/
-        install -m 755 zdump ${D}${bindir}/
-        install -m 755 tzselect ${D}${bindir}/
-}
-
-NATIVE_INSTALL_WORKS = "1"
meta-oe/recipes-extended/tzcode/tzcode-native_2011i.bb deleted +0 -20
deleted file mode 100644
index 8ab4504..0000000
@@ -1,20 +0,0 @@
-require tzcode-native.inc
-
-LICENSE = "PD"
-LIC_FILES_CHKSUM = "file://README;md5=3ae8198f82258417ce29066d3b034035"
-
-# Note that elsie.nci.nih.gov removes old versions when new is coming out
-# So if this doesn't build for you because of missing source file, just
-# bump it to the latest available version, removing old one
-# Also, tzdata (and it is needed to build tzcode) version can differ from
-# tzcode version, thus this variable
-
-TZDATA_PV = "2011i"
-
-PR = "${INC_PR}.2"
-
-SRC_URI[tzcode-2011i.md5sum] = "cf7f4335b7c8682899fa2814e711c1b2"
-SRC_URI[tzcode-2011i.sha256sum] = "f0dd991de3f8d6c599c104e294377c9befa1ef40aa5a1d09e2e295a453f3c1ec"
-SRC_URI[tzdata-2011i.md5sum] = "c7a86ec34f30f8d6aa77ef94902a3047"
-SRC_URI[tzdata-2011i.sha256sum] = "f8dde7ca5e61f21ac34c8cdbef5568d00c829981211098f059d8104964c81ffa"
-
meta-oe/recipes-extended/tzdata/tzdata.inc deleted +0 -177

177 lines not on this page · raw message

meta-oe/recipes-extended/tzdata/tzdata_2011g.bb deleted +0 -12
deleted file mode 100644
index 6863b5a..0000000
@@ -1,12 +0,0 @@
-require tzdata.inc
-
-LICENSE = "PD"
-LIC_FILES_CHKSUM = "file://asia;beginline=2;endline=3;md5=06468c0e84ef4d4c97045a4a29b08234"
-
-# Note that elsie.nci.nih.gov removes old archives after a new one is
-# released. So if this doesn't build for you because of missing source file
-# just bump it to the latest available version, removing the old one
-
-PR = "${INC_PR}.0"
-SRC_URI[md5sum] = "a068c27e7e426fdb12ab0c88506df20d"
-SRC_URI[sha256sum] = "01a2a189eeda63baacc5e68e6c13afffc7edce182102fffc53acbf35e8703d3c"
Signature · 1 line
1.7.3.4
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 17-09-11 00:59, Andrea Adami schreef:

Quoted 1 line

* Up-to-date versions are maintained in oe-core.

Are they as good as the ones in meta-oe? There's a good reason for the recipes to be present :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOdG60MkyGM64RGpERAtQgAJ9HqhtYrnzvosSifKZwBcv9PMhYaQCffvbj 9yKu+lS11DGC51qr/88uD2E=
=jDwt
-----END PGP SIGNATURE-----

#2 lore raw
Quoted 5 lines · On Saturday 17 September 2011 10:56:04 Koen Kooi wrote:

Op 17-09-11 00:59, Andrea Adami schreef:

Quoted 1 line

* Up-to-date versions are maintained in oe-core.

Are they as good as the ones in meta-oe? There's a good reason for the recipes to be present :)

So if they are indeed better, would you mind submitting a patch to improve the ones in oe-core instead?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#3 lore raw
Quoted 7 lines · Paul Eggleton
Quoted 5 lines · On Saturday 17 September 2011 10:56:04 Koen Kooi wrote:

Op 17-09-11 00:59, Andrea Adami schreef:

Quoted 1 line

* Up-to-date versions are maintained in oe-core.

Are they as good as the ones in meta-oe? There's a good reason for the recipes to be present :)

Quoted 8 lines

So if they are indeed better, would you mind submitting a patch to improve the
ones in oe-core instead?

Cheers,
Paul

Any news?
Today tzdata from meta-oe still fails miserably

| ERROR: Function 'Fetcher failure for URL: ' ftp://elsie.nci.nih.gov/pub/tzdata2011g.tar.gz;subdir=tzdata-2011g'. Unable to fetch URL ftp://elsie.nci.nih.gov/pub/tzdata2011g.tar.gz;subdir=tzdata-2011g from any source.' failed
NOTE: package tzdata-2011g-r10.0: task do_fetch: Failed
ERROR: Task 3545 (/oe/meta-openembedded/meta-oe/recipes-extended/tzdata/ tzdata_2011g.bb, do_fetch) failed with exit code '1'

Note the two issues here:

1) it try to fetch the old 2011g
2) SRC_URI differs (subdir)
in meta-oe SRC_URI = " ftp://elsie.nci.nih.gov/pub/tzdata${PV}.tar.gz;subdir=${BPN}-${PV}" in oe-core SRC_URI = " ftp://elsie.nci.nih.gov/pub/tzdata${PV}.tar.gz;name=tzdata"

So, finally, about taking the 'good' bits form the meta-oe recipe...which ones?
Offhand, I see differences in tzdata's do_install (build${prefix}, timezone and localtime) and for tzcode-native just a pointless NATIVE_INSTALL_WORKS = 1.
Ah, imho having an inc for a single recipe is also overkill.

Am I missing more?

Andrea

--

Quoted 9 lines

Paul Eggleton
Intel Open Source Technology Centre

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel