kconfig: fix warnings due to unused return values
PATCH 1/1 kconfig: fix warnings due to unused return values
The return value of wattrset() is being ignored in the code and newer compilers complain about this e.g.
HOSTCC scripts/kconfig/lxdialog/checklist.o scripts/kconfig/lxdialog/checklist.c: In function print_item:scripts/kconfig/lxdialog/checklist.c:40: warning: value computed is not used scripts/kconfig/lxdialog/checklist.c:46: warning: value computed is not used
Let the compiler know that ignore is intentional.
---
The patch was created against the last pull from git.kernel.org The 'pull' from github is taking more than few hours...
Based on the time stamps at this url, I believe the patch should apply cleanly:
https://github.com/torvalds/linux/tree/master/scripts/kconfig/lxdialog
Compiler version used:
gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3
scripts/kconfig/lxdialog/checklist.c | 22 +++++++++++----------- scripts/kconfig/lxdialog/inputbox.c | 12 ++++++------ scripts/kconfig/lxdialog/menubox.c | 20 ++++++++++---------- scripts/kconfig/lxdialog/textbox.c | 8 ++++---- scripts/kconfig/lxdialog/util.c | 20 ++++++++++---------- scripts/kconfig/lxdialog/yesno.c | 6 +++--- 6 files changed, 44 insertions(+), 44 deletions(-)
scripts/kconfig/lxdialog/checklist.c +11 -11
@@ -37,20 +37,20 @@ static void print_item(WINDOW * win, int choice, int selected) list_item[list_width - item_x] ='\0' ;/* Clear 'residue' of last item */ -wattrset (win, dlg.menubox.atr); + (void )wattrset (win, dlg.menubox.atr);wmove (win, choice,0 );for (i =0 ; i < list_width; i++)waddch (win,' ' );wmove (win, choice, check_x); -wattrset (win, selected ? dlg.check_selected.atr + (void )wattrset (win, selected ? dlg.check_selected.atr : dlg.check.atr);if (!item_is_tag (':' ))wprintw (win,"(%c)" ,item_is_tag ('X' ) ?'X' :' ' ); -wattrset (win, selected ? dlg.tag_selected.atr : dlg.tag.atr); + (void )wattrset (win, selected ? dlg.tag_selected.atr : dlg.tag.atr);mvwaddch (win, choice, item_x, list_item[0 ]); -wattrset (win, selected ? dlg.item_selected.atr : dlg.item.atr); + (void )wattrset (win, selected ? dlg.item_selected.atr : dlg.item.atr);waddstr (win, list_item +1 );if (selected) {wmove (win, choice, check_x +1 );
@@ -68,11 +68,11 @@ static void print_arrows(WINDOW * win, int choice, int item_no, int scroll,wmove (win, y, x);if (scroll >0 ) { -wattrset (win, dlg.uarrow.atr); + (void )wattrset (win, dlg.uarrow.atr);waddch (win,ACS_UARROW );waddstr (win,"(-)" ); }else { -wattrset (win, dlg.menubox.atr); + (void )wattrset (win, dlg.menubox.atr);waddch (win,ACS_HLINE );waddch (win,ACS_HLINE );waddch (win,ACS_HLINE );
@@ -83,11 +83,11 @@ static void print_arrows(WINDOW * win, int choice, int item_no, int scroll,wmove (win, y, x);if ((height < item_no) && (scroll + choice < item_no -1 )) { -wattrset (win, dlg.darrow.atr); + (void )wattrset (win, dlg.darrow.atr);waddch (win,ACS_DARROW );waddstr (win,"(+)" ); }else { -wattrset (win, dlg.menubox_border.atr); + (void )wattrset (win, dlg.menubox_border.atr);waddch (win,ACS_HLINE );waddch (win,ACS_HLINE );waddch (win,ACS_HLINE );
@@ -150,16 +150,16 @@ do_resize:draw_box (dialog,0 ,0 , height, width, dlg.dialog.atr, dlg.border.atr); -wattrset (dialog, dlg.border.atr); + (void )wattrset (dialog, dlg.border.atr);mvwaddch (dialog, height -3 ,0 ,ACS_LTEE );for (i =0 ; i < width -2 ; i++)waddch (dialog,ACS_HLINE ); -wattrset (dialog, dlg.dialog.atr); + (void )wattrset (dialog, dlg.dialog.atr);waddch (dialog,ACS_RTEE );print_title (dialog, title, width); -wattrset (dialog, dlg.dialog.atr); + (void )wattrset (dialog, dlg.dialog.atr);print_autowrap (dialog, prompt, width -2 ,1 ,3 ); list_width = width -6 ;
scripts/kconfig/lxdialog/inputbox.c +6 -6
@@ -71,16 +71,16 @@ do_resize:draw_box (dialog,0 ,0 , height, width, dlg.dialog.atr, dlg.border.atr); -wattrset (dialog, dlg.border.atr); + (void )wattrset (dialog, dlg.border.atr);mvwaddch (dialog, height -3 ,0 ,ACS_LTEE );for (i =0 ; i < width -2 ; i++)waddch (dialog,ACS_HLINE ); -wattrset (dialog, dlg.dialog.atr); + (void )wattrset (dialog, dlg.dialog.atr);waddch (dialog,ACS_RTEE );print_title (dialog, title, width); -wattrset (dialog, dlg.dialog.atr); + (void )wattrset (dialog, dlg.dialog.atr);print_autowrap (dialog, prompt, width -2 ,1 ,3 );/* Draw the input field box */
@@ -95,7 +95,7 @@ do_resize:/* Set up the initial value */ wmove (dialog, box_y, box_x); -wattrset (dialog, dlg.inputbox.atr); + (void )wattrset (dialog, dlg.inputbox.atr); input_x =strlen (instr);
@@ -128,7 +128,7 @@ do_resize:case KEY_BACKSPACE :case 127 :if (input_x || scroll) { -wattrset (dialog, dlg.inputbox.atr); + (void )wattrset (dialog, dlg.inputbox.atr);if (!input_x) { scroll = scroll < box_width -1 ?0 : scroll - (box_width -1 );wmove (dialog, box_y, box_x);
@@ -148,7 +148,7 @@ do_resize:default :if (key <0x100 &&isprint (key)) {if (scroll + input_x <MAX_LEN ) { -wattrset (dialog, dlg.inputbox.atr); + (void )wattrset (dialog, dlg.inputbox.atr); instr[scroll + input_x] = key; instr[scroll + input_x +1 ] ='\0' ;if (input_x == box_width -1 ) {
scripts/kconfig/lxdialog/menubox.c +10 -10
@@ -74,7 +74,7 @@ static void do_print_item(WINDOW * win, const char *item, int line_y, j =first_alpha (menu_item,"YyNnMmHh" );/* Clear 'residue' of last item */ -wattrset (win, dlg.menubox.atr); + (void )wattrset (win, dlg.menubox.atr);wmove (win, line_y,0 );#if OLD_NCURSES {
@@ -85,10 +85,10 @@ static void do_print_item(WINDOW * win, const char *item, int line_y,#else wclrtoeol (win);#endif -wattrset (win, selected ? dlg.item_selected.atr : dlg.item.atr); + (void )wattrset (win, selected ? dlg.item_selected.atr : dlg.item.atr);mvwaddstr (win, line_y, item_x, menu_item);if (hotkey) { -wattrset (win, selected ? dlg.tag_key_selected.atr + (void )wattrset (win, selected ? dlg.tag_key_selected.atr : dlg.tag_key.atr);mvwaddch (win, line_y, item_x + j, menu_item[j]); }
@@ -118,11 +118,11 @@ static void print_arrows(WINDOW * win, int item_no, int scroll, int y, int x,wmove (win, y, x);if (scroll >0 ) { -wattrset (win, dlg.uarrow.atr); + (void )wattrset (win, dlg.uarrow.atr);waddch (win,ACS_UARROW );waddstr (win,"(-)" ); }else { -wattrset (win, dlg.menubox.atr); + (void )wattrset (win, dlg.menubox.atr);waddch (win,ACS_HLINE );waddch (win,ACS_HLINE );waddch (win,ACS_HLINE );
@@ -134,11 +134,11 @@ static void print_arrows(WINDOW * win, int item_no, int scroll, int y, int x,wrefresh (win);if ((height < item_no) && (scroll + height < item_no)) { -wattrset (win, dlg.darrow.atr); + (void )wattrset (win, dlg.darrow.atr);waddch (win,ACS_DARROW );waddstr (win,"(+)" ); }else { -wattrset (win, dlg.menubox_border.atr); + (void )wattrset (win, dlg.menubox_border.atr);waddch (win,ACS_HLINE );waddch (win,ACS_HLINE );waddch (win,ACS_HLINE );
@@ -211,17 +211,17 @@ do_resize:draw_box (dialog,0 ,0 , height, width, dlg.dialog.atr, dlg.border.atr); -wattrset (dialog, dlg.border.atr); + (void )wattrset (dialog, dlg.border.atr);mvwaddch (dialog, height -3 ,0 ,ACS_LTEE );for (i =0 ; i < width -2 ; i++)waddch (dialog,ACS_HLINE ); -wattrset (dialog, dlg.dialog.atr); + (void )wattrset (dialog, dlg.dialog.atr);wbkgdset (dialog, dlg.dialog.atr &A_COLOR );waddch (dialog,ACS_RTEE );print_title (dialog, title, width); -wattrset (dialog, dlg.dialog.atr); + (void )wattrset (dialog, dlg.dialog.atr);print_autowrap (dialog, prompt, width -2 ,1 ,3 ); menu_width = width -6 ;
scripts/kconfig/lxdialog/textbox.c +4 -4
@@ -95,7 +95,7 @@ do_resize: boxh = height -4 ; boxw = width -2 ; box =subwin (dialog, boxh, boxw, y +1 , x +1 ); -wattrset (box, dlg.dialog.atr); + (void )wattrset (box, dlg.dialog.atr);wbkgdset (box, dlg.dialog.atr &A_COLOR );keypad (box, TRUE);
@@ -104,11 +104,11 @@ do_resize:draw_box (dialog,0 ,0 , height, width, dlg.dialog.atr, dlg.border.atr); -wattrset (dialog, dlg.border.atr); + (void )wattrset (dialog, dlg.border.atr);mvwaddch (dialog, height -3 ,0 ,ACS_LTEE );for (i =0 ; i < width -2 ; i++)waddch (dialog,ACS_HLINE ); -wattrset (dialog, dlg.dialog.atr); + (void )wattrset (dialog, dlg.dialog.atr);wbkgdset (dialog, dlg.dialog.atr &A_COLOR );waddch (dialog,ACS_RTEE );
@@ -383,7 +383,7 @@ static void print_position(WINDOW * win) {int percent; -wattrset (win, dlg.position_indicator.atr); + (void )wattrset (win, dlg.position_indicator.atr);wbkgdset (win, dlg.position_indicator.atr &A_COLOR ); percent = (page - buf) *100 /strlen (buf);wmove (win,getmaxy (win) -3 ,getmaxx (win) -9 );
scripts/kconfig/lxdialog/util.c +10 -10
@@ -240,7 +240,7 @@ void attr_clear(WINDOW * win, int height, int width, chtype attr) {int i, j; -wattrset (win, attr); + (void )wattrset (win, attr);for (i =0 ; i < height; i++) {wmove (win, i,0 );for (j =0 ; j < width; j++)
@@ -256,7 +256,7 @@ void dialog_clear(void)if (dlg.backtitle !=NULL ) {int i; -wattrset (stdscr, dlg.screen.atr); + (void )wattrset (stdscr, dlg.screen.atr);mvwaddstr (stdscr,0 ,1 , (char *)dlg.backtitle);wmove (stdscr,1 ,1 );for (i =1 ; i <COLS -1 ; i++)
@@ -313,7 +313,7 @@ void print_title(WINDOW *dialog, const char *title, int width) {if (title) {int tlen =MIN (width -2 ,strlen (title)); -wattrset (dialog, dlg.title.atr); + (void )wattrset (dialog, dlg.title.atr);mvwaddch (dialog,0 , (width - tlen) /2 -1 ,' ' );mvwaddnstr (dialog,0 , (width - tlen)/2 , title, tlen);waddch (dialog,' ' );
@@ -393,22 +393,22 @@ void print_button(WINDOW * win, const char *label, int y, int x, int selected)int i, temp;wmove (win, y, x); -wattrset (win, selected ? dlg.button_active.atr + (void )wattrset (win, selected ? dlg.button_active.atr : dlg.button_inactive.atr);waddstr (win,"<" ); temp =strspn (label," " ); label += temp; -wattrset (win, selected ? dlg.button_label_active.atr + (void )wattrset (win, selected ? dlg.button_label_active.atr : dlg.button_label_inactive.atr);for (i =0 ; i < temp; i++)waddch (win,' ' ); -wattrset (win, selected ? dlg.button_key_active.atr + (void )wattrset (win, selected ? dlg.button_key_active.atr : dlg.button_key_inactive.atr);waddch (win, label[0 ]); -wattrset (win, selected ? dlg.button_label_active.atr + (void )wattrset (win, selected ? dlg.button_label_active.atr : dlg.button_label_inactive.atr);waddstr (win, (char *)label +1 ); -wattrset (win, selected ? dlg.button_active.atr + (void )wattrset (win, selected ? dlg.button_active.atr : dlg.button_inactive.atr);waddstr (win,">" );wmove (win, y, x + temp +1 );
@@ -423,7 +423,7 @@ draw_box(WINDOW * win, int y, int x, int height, int width, {int i, j; -wattrset (win,0 ); + (void )wattrset (win,0 );for (i =0 ; i < height; i++) {wmove (win, y + i, x);for (j =0 ; j < width; j++)
@@ -457,7 +457,7 @@ void draw_shadow(WINDOW * win, int y, int x, int height, int width)int i;if (has_colors ()) {/* Whether terminal supports color? */ -wattrset (win, dlg.shadow.atr); + (void )wattrset (win, dlg.shadow.atr);wmove (win, y + height, x +2 );for (i =0 ; i < width; i++)waddch (win,winch (win) &A_CHARTEXT );
scripts/kconfig/lxdialog/yesno.c +3 -3
@@ -61,16 +61,16 @@ do_resize:draw_box (dialog,0 ,0 , height, width, dlg.dialog.atr, dlg.border.atr); -wattrset (dialog, dlg.border.atr); + (void )wattrset (dialog, dlg.border.atr);mvwaddch (dialog, height -3 ,0 ,ACS_LTEE );for (i =0 ; i < width -2 ; i++)waddch (dialog,ACS_HLINE ); -wattrset (dialog, dlg.dialog.atr); + (void )wattrset (dialog, dlg.dialog.atr);waddch (dialog,ACS_RTEE );print_title (dialog, title, width); -wattrset (dialog, dlg.dialog.atr); + (void )wattrset (dialog, dlg.dialog.atr);print_autowrap (dialog, prompt, width -2 ,1 ,3 );print_buttons (dialog, height, width,0 );
Signature · 1 line
1.7.0.4
Quoted 17 lines
-----Original Message-----
From: Premi, Sanjeev
Sent: Thursday, September 22, 2011 5:07 PM
To: [email protected]
Cc: Premi, Sanjeev
Subject: [PATCH] kconfig: fix warnings due to unused return valuesThe return value of
wattrset()is being ignored in the code and newer compilers complain about this e.g.HOSTCC
scripts/kconfig/lxdialog/checklist.oscripts/kconfig/lxdialog/checklist.c: In functionprint_item:scripts/kconfig/lxdialog/checklist.c:40: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c:46: warning: value computed is not used
Quoted 4 lines
Let the compiler know that ignore is intentional.
Signed-off-by Sanjeev Premi <[email protected]>---
Just wanted to ping on the status...
~sanjeev
[snip]...[snip]
Quoted 11 lines · Sanjeev Premi
The return value of
wattrset()is being ignored in the code and newer compilers complain about this e.g.HOSTCC
scripts/kconfig/lxdialog/checklist.oscripts/kconfig/lxdialog/checklist.c: In functionprint_item:scripts/kconfig/lxdialog/checklist.c:40: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c:46: warning: value computed is not usedLet the compiler know that ignore is intentional.
Signed-off-by Sanjeev Premi <[email protected]>
Quoted 8 lines
---
The patch was created against the last pull from git.kernel.org The 'pull' from github is taking more than few hours...
Based on the time stamps at this url, I believe the patch should apply cleanly:
https://github.com/torvalds/linux/tree/master/scripts/kconfig/lxdialog
The latest kconfig tree is at http://repo.or.cz/w/linux-kbuild.git,
branch kconfig. You can pull it by
$ git fetch git://repo.or.cz/linux-kbuild.git kconfig:kconfig
Quoted 7 lines
scripts/kconfig/lxdialog/checklist.c +0
-0@@ -37,20 +37,20 @@ static void print_item(WINDOW * win, int choice, int selected) list_item[list_width - item_x] ='\0' ;
scripts/kconfig/lxdialog/checklist.c static void print_item(WINDOW * win, int choice, int selected) · line 46
Quoted 10 lines
scripts/kconfig/lxdialog/checklist.c +2
-2/* Clear 'residue' of last item */ -wattrset (win, dlg.menubox.atr); + (void )wattrset (win, dlg.menubox.atr);wmove (win, choice,0 );for (i =0 ; i < list_width; i++)waddch (win,' ' );wmove (win, choice, check_x); - wattrset(win, selected ? dlg.check_selected.atr + (void)wattrset(win, selected ? dlg.check_selected.atr
Uhm, not pretty. What ncurses version are you using? Can you post the output of make V=1 menuconfig? It seems like wattrset is defined as a macro instead of a function call. FWIW, it does not print any warnings here with
$ rpm -qf /usr/include/ncurses ncurses-devel-5.8-2.6.x86_64 and gcc version 4.6.1 20110801 [gcc-4_6-branch revision 177033] (SUSE Linux)
on openSUSE Factory.
Michal
Quoted 29 lines
-----Original Message-----
From: Michal Marek [mailto:[email protected]]
Sent: Wednesday, October 05, 2011 8:38 PM
To: Premi, Sanjeev
Cc: [email protected]
Subject: Re: [PATCH] kconfig: fix warnings due to unused return valuesQuoted 6 lines · Sanjeev Premi
The return value of
wattrset()is being ignored in the code and newer compilers complain about this e.g.HOSTCC
scripts/kconfig/lxdialog/checklist.oscripts/kconfig/lxdialog/checklist.c: In functionprint_item:scripts/kconfig/lxdialog/checklist.c:40: warning: valuecomputed is not used
Quoted 1 line
scripts/kconfig/lxdialog/checklist.c:46: warning: valuecomputed is not used
Quoted 12 lines
Let the compiler know that ignore is intentional.
Signed-off-by Sanjeev Premi <[email protected]>---
The patch was created against the last pull from git.kernel.org The 'pull' from github is taking more than few hours...
Based on the time stamps at this url, I believe the patch should apply cleanly:
Quoted 6 lines
https://github.com/torvalds/linux/tree/master/scripts/kconfig/lxdialog
The latest kconfig tree is at http://repo.or.cz/w/linux-kbuild.git,
branch kconfig. You can pull it by$ git fetch git://repo.or.cz/linux-kbuild.git kconfig:kconfig
Sure, I will pull it.
Quoted 17 lines
Review
Quoted 2 lines
(quoted diff) +0
-0
b/scripts/kconfig/lxdialog/checklist.cscripts/kconfig/lxdialog/checklist.c static void print_item(WINDOW * win,
Quoted 4 lines
index a2eb80f..8407849 100644
scripts/kconfig/lxdialog/checklist.c +0
-0@@ -37,20 +37,20 @@ static void print_item(WINDOW * win,int choice, int selected)
Quoted 9 lines
scripts/kconfig/lxdialog/checklist.c +1
-1list_item[list_width - item_x] ='\0' ;/* Clear 'residue' of last item */ -wattrset (win, dlg.menubox.atr); + (void )wattrset (win, dlg.menubox.atr);wmove (win, choice,0 );for (i =0 ; i < list_width; i++)waddch (win,' ' );
Quoted 5 lines
scripts/kconfig/lxdialog/checklist.c static void print_item(WINDOW * win, int choice, int selected) · line 46
Quoted 3 lines
scripts/kconfig/lxdialog/checklist.c +1
-1wmove (win, choice, check_x); - wattrset(win, selected ? dlg.check_selected.atr + (void)wattrset(win, selected ? dlg.check_selected.atrUhm, not pretty.
Agree. But, of course, I am not too conversant with Kconfig code. Just found these prints to be nagging after migrating to machines.
Quoted 11 lines
What ncurses version are you using? Can you post the
output of make V=1 menuconfig? It seems like wattrset is defined as a macro instead of a function call. FWIW, it does not print any warnings here with$ rpm -qf /usr/include/ncurses ncurses-devel-5.8-2.6.x86_64 and gcc version 4.6.1 20110801 [gcc-4_6-branch revision 177033] (SUSE Linux)
Quoted 4 lines
on openSUSE Factory.
Michal
I am on Ubuntu 10.04.1 LTS
premi #
premi # gcc --version
gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3
Copyright (C) 2009 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. premi #
premi #
premi # dpkg --get-selections | grep curses
lib32ncurses5 install libcurses-perl install libcurses-ui-perl install libncurses5 install libncurses5-dev install libncursesw5 install ncurses-base install ncurses-bin install
premi #
premi # make V=1 menuconfig
make -f scripts/Makefile.build obj=scripts/basic
rm -f .tmp_quiet_recordmcount
mkdir -p include/linux include/config
make -f scripts/Makefile.build obj=scripts/kconfig menuconfig/bin/sh /home/premi/linux-omap-2.6/scripts/kconfig/lxdialog/check-lxdialog.sh -check gcc -DCURSES_LOC="<ncurses.h>" -DLOCALE -lncurses
gcc -Wp,-MD,scripts/kconfig/lxdialog/.checklist.o.d -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o scripts/kconfig/lxdialog/checklist.o scripts/kconfig/lxdialog/checklist.cscripts/kconfig/lxdialog/checklist.c: In function âprint_itemâ:scripts/kconfig/lxdialog/checklist.c:40: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c:46: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c:51: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c:53: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c: In function âprint_arrowsâ:scripts/kconfig/lxdialog/checklist.c:71: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c:75: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c:86: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c:90: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c: In function âdialog_checklistâ:scripts/kconfig/lxdialog/checklist.c:153: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c:157: warning: value computed is not usedscripts/kconfig/lxdialog/checklist.c:162: warning: value computed is not used
gcc -Wp,-MD,scripts/kconfig/lxdialog/.inputbox.o.d -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o scripts/kconfig/lxdialog/inputbox.o scripts/kconfig/lxdialog/inputbox.cscripts/kconfig/lxdialog/inputbox.c: In function âdialog_inputboxâ:scripts/kconfig/lxdialog/inputbox.c:74: warning: value computed is not usedscripts/kconfig/lxdialog/inputbox.c:78: warning: value computed is not usedscripts/kconfig/lxdialog/inputbox.c:83: warning: value computed is not usedscripts/kconfig/lxdialog/inputbox.c:98: warning: value computed is not usedscripts/kconfig/lxdialog/inputbox.c:131: warning: value computed is not usedscripts/kconfig/lxdialog/inputbox.c:151: warning: value computed is not used
gcc -Wp,-MD,scripts/kconfig/lxdialog/.menubox.o.d -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o scripts/kconfig/lxdialog/menubox.o scripts/kconfig/lxdialog/menubox.cscripts/kconfig/lxdialog/menubox.c: In function âdo_print_itemâ:scripts/kconfig/lxdialog/menubox.c:77: warning: value computed is not usedscripts/kconfig/lxdialog/menubox.c:88: warning: value computed is not usedscripts/kconfig/lxdialog/menubox.c:91: warning: value computed is not usedscripts/kconfig/lxdialog/menubox.c: In function âprint_arrowsâ:scripts/kconfig/lxdialog/menubox.c:121: warning: value computed is not usedscripts/kconfig/lxdialog/menubox.c:125: warning: value computed is not usedscripts/kconfig/lxdialog/menubox.c:137: warning: value computed is not usedscripts/kconfig/lxdialog/menubox.c:141: warning: value computed is not usedscripts/kconfig/lxdialog/menubox.c: In function âdialog_menuâ:scripts/kconfig/lxdialog/menubox.c:214: warning: value computed is not usedscripts/kconfig/lxdialog/menubox.c:218: warning: value computed is not usedscripts/kconfig/lxdialog/menubox.c:224: warning: value computed is not used
gcc -Wp,-MD,scripts/kconfig/lxdialog/.textbox.o.d -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o scripts/kconfig/lxdialog/textbox.o scripts/kconfig/lxdialog/textbox.cscripts/kconfig/lxdialog/textbox.c: In function âdialog_textboxâ:scripts/kconfig/lxdialog/textbox.c:98: warning: value computed is not usedscripts/kconfig/lxdialog/textbox.c:107: warning: value computed is not usedscripts/kconfig/lxdialog/textbox.c:111: warning: value computed is not usedscripts/kconfig/lxdialog/textbox.c: In function âprint_positionâ:scripts/kconfig/lxdialog/textbox.c:386: warning: value computed is not used
gcc -Wp,-MD,scripts/kconfig/lxdialog/.util.o.d -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o scripts/kconfig/lxdialog/util.o scripts/kconfig/lxdialog/util.cscripts/kconfig/lxdialog/util.c: In function âattr_clearâ:scripts/kconfig/lxdialog/util.c:243: warning: value computed is not usedscripts/kconfig/lxdialog/util.c: In function âdialog_clearâ:scripts/kconfig/lxdialog/util.c:259: warning: value computed is not usedscripts/kconfig/lxdialog/util.c: In function âprint_titleâ:scripts/kconfig/lxdialog/util.c:316: warning: value computed is not usedscripts/kconfig/lxdialog/util.c: In function âprint_buttonâ:scripts/kconfig/lxdialog/util.c:396: warning: value computed is not usedscripts/kconfig/lxdialog/util.c:401: warning: value computed is not usedscripts/kconfig/lxdialog/util.c:405: warning: value computed is not usedscripts/kconfig/lxdialog/util.c:408: warning: value computed is not usedscripts/kconfig/lxdialog/util.c:411: warning: value computed is not usedscripts/kconfig/lxdialog/util.c: In function âdraw_shadowâ:scripts/kconfig/lxdialog/util.c:460: warning: value computed is not used
gcc -Wp,-MD,scripts/kconfig/lxdialog/.yesno.o.d -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o scripts/kconfig/lxdialog/yesno.o scripts/kconfig/lxdialog/yesno.cscripts/kconfig/lxdialog/yesno.c: In function âdialog_yesnoâ:scripts/kconfig/lxdialog/yesno.c:64: warning: value computed is not usedscripts/kconfig/lxdialog/yesno.c:68: warning: value computed is not usedscripts/kconfig/lxdialog/yesno.c:73: warning: value computed is not used
gcc -Wp,-MD,scripts/kconfig/.mconf.o.d -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o scripts/kconfig/mconf.o scripts/kconfig/mconf.c
gcc -o scripts/kconfig/mconf scripts/kconfig/mconf.o scripts/kconfig/zconf.tab.o scripts/kconfig/lxdialog/checklist.o scripts/kconfig/lxdialog/util.o scripts/kconfig/lxdialog/inputbox.o scripts/kconfig/lxdialog/textbox.o scripts/kconfig/lxdialog/yesno.o scripts/kconfig/lxdialog/menubox.o -lncursesscripts/kconfig/mconf Kconfig
Quoted 40 lines
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Premi, Sanjeev
Sent: Friday, October 07, 2011 2:49 PM
To: Michal Marek
Cc: [email protected]
Subject: RE: [PATCH] kconfig: fix warnings due to unused return valuesQuoted 6 lines
-----Original Message-----
From: Michal Marek [mailto:[email protected]]
Sent: Wednesday, October 05, 2011 8:38 PM
To: Premi, Sanjeev
Cc: [email protected]
Subject: Re: [PATCH] kconfig: fix warnings due to unusedreturn values
Quoted 24 lines · Sanjeev Premi
Quoted 6 lines
The return value of
wattrset()is being ignored in the code and newer compilers complain about this e.g.HOSTCC
scripts/kconfig/lxdialog/checklist.oscripts/kconfig/lxdialog/checklist.c: In functionprint_item:scripts/kconfig/lxdialog/checklist.c:40: warning: valuecomputed is not used
Quoted 1 line
scripts/kconfig/lxdialog/checklist.c:46: warning: valuecomputed is not used
Quoted 12 lines
Let the compiler know that ignore is intentional.
Signed-off-by Sanjeev Premi <[email protected]>---
The patch was created against the last pull from git.kernel.org The 'pull' from github is taking more than few hours...
Based on the time stamps at this url, I believe the patch should apply cleanly:
Quoted 8 lines
https://github.com/torvalds/linux/tree/master/scripts/kconfig/lxdialog
Quoted 5 lines
The latest kconfig tree is at http://repo.or.cz/w/linux-kbuild.git,
branch kconfig. You can pull it by$ git fetch git://repo.or.cz/linux-kbuild.git kconfig:kconfigSure, I will pull it.
I tried the menuconfig after pulling from this repo and still see the same warnings.
For reference, the HEAD is at:
commit 93072c3ecafcf188390750cc755185f3150736b9 scripts/kconfig/nconf: add KEY_HOME / KEY_END for dialog_inputbox
[snip]...[snip]
Quoted 22 lines
I am on Ubuntu 10.04.1 LTS
premi #
premi # gcc --version
gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3
Copyright (C) 2009 Free Software Foundation, Inc. This is free software; see the source for copying conditions.
There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
premi #
premi #
premi # dpkg --get-selections | grep curseslib32ncurses5 install libcurses-perl install libcurses-ui-perl install libncurses5 install libncurses5-dev install libncursesw5 install ncurses-base install ncurses-bin install
Quoted 1 line
premi #
This information is in my previous mail, but keeping here just for easy reference.
~sanjeev
[snip]...[snip]