Skip to contentSkip to conversation

ACPI: check mutex release status

PATCH In review Davidlohr Bueso 2 participants 2 messages Sep 26, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: check mutex release status

From: Davidlohr Bueso <[email protected]>

If this is not done we have a bogus ACPI_FAILURE() call.

---
 drivers/acpi/acpica/nsload.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/acpica/nsload.c +1 -1
index 5f7dc69..f3070fd 100644
@@ -115,7 +115,7 @@ acpi_ns_load_table(u32 table_index, struct acpi_namespace_node *node)
 	}
 
       unlock:
-	(void)acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
+	status = acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
 
 	if (ACPI_FAILURE(status)) {
 		return_ACPI_STATUS(status);
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 16 lines · Davidlohr Bueso

From: Davidlohr Bueso <[email protected]>

If this is not done we have a bogus ACPI_FAILURE() call.

---
 drivers/acpi/acpica/nsload.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/acpica/nsload.c +0 -0
index 5f7dc69..f3070fd 100644
@@ -115,7 +115,7 @@ acpi_ns_load_table(u32 table_index, struct acpi_namespace_node *node)
        }
 
Quoted 3 lines

      unlock:
-       (void)acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
+       status = acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);

No,

The status maybe set before the "goto unlock" statement.

Lin Ming

Quoted 5 lines

       if (ACPI_FAILURE(status)) {
               return_ACPI_STATUS(status);
--
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html