insane: Promote most warnings into QA errors by default
PATCH 1/1 insane: Promote most warnings into QA errors by default
We agreed a while back that we'd start ERRORing on QA issues, not just WARNING about them. This patch changes the default QA levels to error on everything except ldflag and useless rpath issues.
It also stops giving out QA warnings about desktop files since it adds noise to the build and until someone plans to seriously tackle that problem, its pointless.
We can promote the ldflag and rpath warnings too, when the issues in OE-Core are resolved (they're mostly there now, jsut a few more to go).
---
meta/classes/insane.bbclass +3 -3
@@ -99,9 +99,9 @@ def package_qa_get_machine_dict(): } -WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths" -ERROR_QA ?= "" -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms" +# Currently not being used by default "desktop" +WARN_QA ?= "ldflags useless-rpaths" +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms" def package_qa_clean_path(path,d): """ Remove the common prefix from the path. In this case it is the TMPDIR"""
Quoted 19 lines · Richard Purdie
We agreed a while back that we'd start ERRORing on QA issues, not just WARNING about them. This patch changes the default QA levels to error on everything except ldflag and useless rpath issues.
It also stops giving out QA warnings about desktop files since it adds noise to the build and until someone plans to seriously tackle that problem, its pointless.
We can promote the ldflag and rpath warnings too, when the issues in OE-Core are resolved (they're mostly there now, jsut a few more to go).
Signed-off-by Richard Purdie <[email protected]>---
meta/classes/insane.bbclass +0
-0
meta/classes/insane.bbclass def package_qa_get_machine_dict(): · line 105
Quoted 10 lines
meta/classes/insane.bbclass +3
-3@@ -99,9 +99,9 @@ def package_qa_get_machine_dict(): } -WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths" -ERROR_QA ?= "" -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms" +# Currently not being used by default "desktop" +WARN_QA ?= "ldflags useless-rpaths" +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
Further testing shows we may not be ready to move rpath to ERROR_QA quite yet but the rest of the proposal still stands...
Cheers,
Richard
Quoted 23 lines · Richard Purdie
Quoted 22 lines · Richard Purdie
We agreed a while back that we'd start ERRORing on QA issues, not just WARNING about them. This patch changes the default QA levels to error on everything except ldflag and useless rpath issues.
It also stops giving out QA warnings about desktop files since it adds noise to the build and until someone plans to seriously tackle that problem, its pointless.
We can promote the ldflag and rpath warnings too, when the issues in OE-Core are resolved (they're mostly there now, jsut a few more to go).
Signed-off-by Richard Purdie<[email protected]>---
meta/classes/insane.bbclass +0
-0@@ -99,9 +99,9 @@ def package_qa_get_machine_dict(): }
Quoted 11 lines
meta/classes/insane.bbclass def package_qa_get_machine_dict(): · line 105
Quoted 7 lines
meta/classes/insane.bbclass +3
-3-WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths" -ERROR_QA ?= "" -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms" +# Currently not being used by default "desktop" +WARN_QA ?= "ldflags useless-rpaths" +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"Further testing shows we may not be ready to move rpath to
ERROR_QAquite yet but the rest of the proposal still stands...
How bad is the breakage in a world build?
I will probably attempt this later or tomorrow.
Sau!
Quoted 10 lines
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Quoted 35 lines · Saul Wold
Quoted 23 lines · Richard Purdie
Quoted 22 lines · Richard Purdie
We agreed a while back that we'd start ERRORing on QA issues, not just WARNING about them. This patch changes the default QA levels to error on everything except ldflag and useless rpath issues.
It also stops giving out QA warnings about desktop files since it adds noise to the build and until someone plans to seriously tackle that problem, its pointless.
We can promote the ldflag and rpath warnings too, when the issues in OE-Core are resolved (they're mostly there now, jsut a few more to go).
Signed-off-by Richard Purdie<[email protected]>---
meta/classes/insane.bbclass +0
-0@@ -99,9 +99,9 @@ def package_qa_get_machine_dict(): }Quoted 11 lines
meta/classes/insane.bbclass def package_qa_get_machine_dict(): · line 105
Quoted 7 lines
meta/classes/insane.bbclass +3
-3-WARN_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig desktop la ldflags perms useless-rpaths" -ERROR_QA ?= "" -#ERROR_QA ?= "rpaths debug-deps dev-deps debug-files arch pkgconfig perms" +# Currently not being used by default "desktop" +WARN_QA ?= "ldflags useless-rpaths" +ERROR_QA ?= "dev-so rpaths debug-deps dev-deps debug-files arch la2 pkgconfig la perms"Further testing shows we may not be ready to move rpath to
ERROR_QAquite yet but the rest of the proposal still stands...
Quoted 3 lines
How bad is the breakage in a world build?
I will probably attempt this later or tomorrow.
I tested world on qemux86 and qemuarm and fixed all the issues the above change would error on ignoring rpath/ldflags/desktop. The list of issues I posted earlier was against world for the other pieces, again ignoring desktop.
So we shouldn't be too bad, otherwise I wouldn't be proposing this :)
Cheers,
Richard