Skip to contentSkip to conversation

autotools: Remove help2man dependency

PATCH Richard Purdie 2 participants 3 messages Sep 29, 2011 – Sep 30, 2011

lore
Share & tools
lore

Richard Purdie

author
#0 lore raw

The help2man script is pretty useless to us. It requires to run the target binary to extract help information which is not possible for any of our cross compiled target binaries.

We're not interested in man pages for -cross/-native tools.

It therefore makes no sense to have this as a core build dependency.

This patch removes the dependeny and replaces it with a script returning false. This will trigger autotool's missing utility to use the copy of the man page included with the sources which is what would already happen when we tried to run cross compiled binaries anyway.

Signed-off-by Richard Purdie <[email protected]>

---

meta/classes/autotools.bbclass +1 -1
index f213c18..c05ab4b 100644
@@ -7,7 +7,7 @@ def autotools_dep_prepend(d):
 
 	if pn in ['autoconf-native', 'automake-native', 'help2man-native']:
 		return deps
-	deps += 'autoconf-native automake-native help2man-native '
+	deps += 'autoconf-native automake-native '
 
 	if not pn in ['libtool', 'libtool-native'] and not pn.endswith("libtool-cross"):
 		deps += 'libtool-native '
scripts/help2man renamed from dev/null +3 -0
new file mode 100755
index 0000000..2bb8d86
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exit 1
#1 lore raw
Quoted 8 lines · Richard Purdie

The help2man script is pretty useless to us. It requires to run the target binary to extract help information which is not possible for any of our cross compiled target binaries.

We're not interested in man pages for -cross/-native tools.

It therefore makes no sense to have this as a core build dependency.

Quoted 7 lines

This patch removes the dependeny and replaces it with a script returning false. This will trigger autotool's missing utility to use the copy of the man page included with the sources which is what would already happen when we tried to run cross compiled binaries anyway.

Signed-off-by Richard Purdie <[email protected]>
Signed-off-by Joshua Lock <[email protected]>

Great!

Joshua

Quoted 30 lines

---

meta/classes/autotools.bbclass +1 -1
index f213c18..c05ab4b 100644
@@ -7,7 +7,7 @@ def autotools_dep_prepend(d):
 
 	if pn in ['autoconf-native', 'automake-native', 'help2man-native']:
 		return deps
-	deps += 'autoconf-native automake-native help2man-native '
+	deps += 'autoconf-native automake-native '
 
 	if not pn in ['libtool', 'libtool-native'] and not pn.endswith("libtool-cross"):
 		deps += 'libtool-native '
scripts/help2man renamed from dev/null +3 -0
new file mode 100755
index 0000000..2bb8d86
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exit 1

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre
#2 lore raw
Quoted 15 lines · Joshua Lock
Quoted 14 lines · Richard Purdie

The help2man script is pretty useless to us. It requires to run the target binary to extract help information which is not possible for any of our cross compiled target binaries.

We're not interested in man pages for -cross/-native tools.

It therefore makes no sense to have this as a core build dependency.

This patch removes the dependeny and replaces it with a script returning false. This will trigger autotool's missing utility to use the copy of the man page included with the sources which is what would already happen when we tried to run cross compiled binaries anyway.

Quoted 4 lines
Quoted 1 line
Signed-off-by Richard Purdie <[email protected]>
Signed-off-by Joshua Lock <[email protected]>

Great!

By way of a follow on this patch "resolves" Yocto #1533 by no longer calling help2man on the host.

http://bugzilla.yoctoproject.org/show_bug.cgi?id=1533

Cheers,
Joshua

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre