ASoC: snd_soc_codec_set_cache_io does not set codec->hw_write callback now

DISCUSSION Axel Lin 2 participants 2 messages Oct 4, 2011

Share & tools

Axel Lin

author

2011-10-04 09:24 UTC #0 lore raw

Hi,
I just found that after commit be3ea3b9e
"SoC: Use new register map API for ASoC generic physical I/O", snd_soc_codec_set_cache_io does not set codec->hw_write any more.

It is still used in some drivers. e.g.
In wm8988_resume, we call codec->hw_write(codec->control_data, data, 2);

For the drivers that is using snd_soc_codec_set_cache_io now, where is the place to set codec->hw_write callback now?

Regards,
Axel

Mark Brown

2011-10-04 09:51 UTC #1 lore raw

Quoted 9 lines · Axel Lin

I just found that after commit be3ea3b9e
"SoC: Use new register map API for ASoC generic physical I/O", snd_soc_codec_set_cache_io does not set codec->hw_write any more.
It is still used in some drivers. e.g.
In wm8988_resume, we call codec->hw_write(codec->control_data, data, 2);
For the drivers that is using snd_soc_codec_set_cache_io now, where is the place to set codec->hw_write callback now?

These drivers should be using the standard I/O functions, probably they're looking for the cache_bypass flag. Either that or convert to use regmap directly.