netfs: Downgrade i_rwsem for a buffered write
Subsystems (6)
David Howells
maintainerPATCH 1/1 netfs: Downgrade i_rwsem for a buffered write
In the I/O locking code borrowed from NFS into netfslib, i_rwsem is held locked across a buffered write - but this causes a performance regression in cifs as it excludes buffered reads for the duration (cifs didn't use any locking for buffered reads).
Mitigate this somewhat by downgrading the i_rwsem to a read lock across the buffered write. This at least allows parallel reads to occur whilst excluding other writes, DIO, truncate and setattr.
Note that this shouldn't be a problem for a buffered write as a read through an mmap can circumvent i_rwsem anyway.
Also note that we might want to make this change in NFS also.
Signed-off-by David Howells <[email protected]>
cc Steve French <[email protected]>
cc Paulo Alcantara <[email protected]>
cc Trond Myklebust <[email protected]>
cc Jeff Layton <[email protected]>
--- fs/netfs/locking.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/netfs/locking.c +2 -1
@@ -109,6 +109,7 @@ int netfs_start_io_write(struct inode *inode)up_write (&inode->i_rwsem);return -ERESTARTSYS ; } +downgrade_write (&inode->i_rwsem);return 0 ; }EXPORT_SYMBOL (netfs_start_io_write);
@@ -123,7 +124,7 @@ EXPORT_SYMBOL(netfs_start_io_write);void netfs_end_io_write (struct inode *inode) __releases(inode->i_rwsem) { -up_write (&inode->i_rwsem); +up_read (&inode->i_rwsem); }EXPORT_SYMBOL (netfs_end_io_write);