Skip to contentSkip to conversation

Regulator: DA9052/53 regulator support v4

PATCH In review ashishj3 2 participants 2 messages Oct 7, 2011 – Oct 12, 2011

Subsystems (2)
lore
Share & tools
lore

ashishj3

author
#0 lore raw

PATCH 5/11 Regulator: DA9052/53 regulator support v4

The Dialog PMIC has below featured regulators:- DA9052-BC - 4 DVS Buck converters 0.5V - 3.6V upto 1Amp. DA9053-AA/BX - 4 DVS Buck converters 0.5V - 2.5V upto 3Amp. DA9052/53 - 10 Programmable LDO's High PSSR, 1% accuracy.

This patch support all the DA9052 and Da9053 regulators. The output voltages are fully programmable via I2C or SPI interface. The platform data with regulation constraints is passed down from the board to the regulator.

---
Changes since v4
- Add support for DA9053-AA/Bx
- Correct the definition of macros DA9052_BUCK_ILIM_MASK
- Get current limit to return current limit in microA
- Correct the voltage selector value for the Buck-PERI above 3v
- Set the struct member regulator->da9052 in probe() Changes since v3
- Corrected verify_range function
Changes since v2
- Check for current min_uA < 700000
- Corrected current conversions from mA to uA

---
 drivers/regulator/Kconfig            |    7 +
 drivers/regulator/Makefile           |    1 +
 drivers/regulator/da9052-regulator.c |  594 ++++++++++++++++++++++++++++++++++
 3 files changed, 602 insertions(+), 0 deletions(-)
 create mode 100755 drivers/regulator/da9052-regulator.c
drivers/regulator/Kconfig +7 -0
index c7fd2c0..74f6042 100644
@@ -167,6 +167,13 @@ config REGULATOR_DA903X
 	  Say y here to support the BUCKs and LDOs regulators found on
 	  Dialog Semiconductor DA9030/DA9034 PMIC.
 
+config REGULATOR_DA9052
+	tristate "Dialog DA9052/DA9053 regulators"
+	depends on PMIC_DA9052
+	help
+	  Say y here to support the BUCKs and LDOs regulators found on
+	  Dialog Semiconductor DA9052/DA9053 PMIC.
+
 config REGULATOR_PCF50633
 	tristate "PCF50633 regulator driver"
         depends on MFD_PCF50633
drivers/regulator/Makefile +1 -0
index 040d5aa..f02534e 100644
@@ -28,6 +28,7 @@ obj-$(CONFIG_REGULATOR_WM8400) += wm8400-regulator.o
 obj-$(CONFIG_REGULATOR_WM8994) += wm8994-regulator.o
 obj-$(CONFIG_REGULATOR_TPS6586X) += tps6586x-regulator.o
 obj-$(CONFIG_REGULATOR_DA903X)	+= da903x.o
+obj-$(CONFIG_REGULATOR_DA9052)	+= da9052-regulator.o
 obj-$(CONFIG_REGULATOR_PCF50633) += pcf50633-regulator.o
 obj-$(CONFIG_REGULATOR_PCAP) += pcap-regulator.o
 obj-$(CONFIG_REGULATOR_MC13783) += mc13783-regulator.o
drivers/regulator/da9052-regulator.c new file +594 -0

594 lines not on this page · raw message

Tested-by on v1 5/11
#1 lore raw
Quoted 5 lines · (2011年10月07日 20:20), ashishj3 wrote:

The Dialog PMIC has below featured regulators:- DA9052-BC - 4 DVS Buck converters 0.5V - 3.6V upto 1Amp. DA9053-AA/BX - 4 DVS Buck converters 0.5V - 2.5V upto 3Amp. DA9052/53 - 10 Programmable LDO's High PSSR, 1% accuracy.

Quoted 7 lines

This patch support all the DA9052 and Da9053 regulators. The output voltages are fully programmable via I2C or SPI interface. The platform data with regulation constraints is passed down from the board to the regulator.

Hi,

I've reviewed the source code and tested this driver on imx53 QuickStart board. Works good.

There are some minor warnings and error by running checkpatch.pl on this patch.

WARNING: please write a paragraph that describes the config symbol fully #50: FILE: drivers/regulator/Kconfig:173:
+ help

ERROR: do not set execute permissions for source files #70: FILE: drivers/regulator/da9052-regulator.c

WARNING: line over 80 characters
#117: FILE: drivers/regulator/da9052-regulator.c:43:
+ {800000, 1000000, 1200000, 1500000}, /* DA9053-AA/Bx BUCK-PRO,MEM,PERI */

Yours Sincerely,
Paul