Skip to contentSkip to conversation

: Improve performance of LZO/plain hibernation, check image with CRC32

PATCH Bojan Smojver 1 participant 1 message Oct 10, 2011

lore
Share & tools
lore
#0 lore raw
Quoted 6 lines · Bojan Smojver

static void release_swap_reader(struct swap_map_handle *handle) {

(quoted diff) +2 -2
-       if (handle->cur)
-               free_page((unsigned long)handle->cur);
+       struct swap_map_page_list *tmp;
+

Review

Quoted 10 lines
(quoted diff) +8 -0
+       while (handle->maps) {
+               if (handle->maps->map)
+                       free_page((unsigned long)handle->maps->map);
+               tmp = handle->maps;
+               handle->maps = handle->maps->next;
+               kfree(tmp);
+       }
        handle->cur = NULL;
+       handle->maps = NULL;
 } 

Obviously, that handle->maps = NULL is redundant there.

PS. It's funny how errors only become visible once you send them out. :-)

Signature · 1 line
Bojan