staging: et131x: Update TODO list
PATCH 4/4 staging: et131x: Update TODO list
Added some more tasks to the TODO list, as highlighted by Francois Romieu <[email protected]>.
--- drivers/staging/et131x/README | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-)
drivers/staging/et131x/README +7 -2
@@ -2,13 +2,18 @@ This is a driver for the ET1310 network device. Based on the driver found at https://sourceforge.net/projects/et131x/ -Cleaned up immensely by Olaf Hartman and Christoph -Hellwig <[email protected]> +Cleaned up immensely by Olaf Hartman and Christoph Hellwig <[email protected]> Note, the powermanagement options were removed from the vendor provided driver as they did not build properly at the time. TODO: + - Put the driver into a single file, with a .h for the registers layout. + - rx_ring.fbr{0, 1} can probably share a common structure + - Use of kmem_cache seems a bit unusual + - Use dma_alloc_... in place of pci_alloc_... + - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet. + - PCI_VDEVICE ? Please send patches to: Greg Kroah-Hartman <[email protected]>
Signature · 1 line
1.7.6.4
Hi Mark,
drivers/staging/et131x/README This is a driver for the ET1310 network device. · line 5
Quoted 11 lines · Mark Einon
drivers/staging/et131x/README +1
-2@@ -2,13 +2,18 @@ This is a driver for the ET1310 network device. Based on the driver found at https://sourceforge.net/projects/et131x/ -Cleaned up immensely by Olaf Hartman and Christoph -Hellwig <[email protected]> +Cleaned up immensely by Olaf Hartman and Christoph Hellwig <[email protected]>
It seems that a fragment from your earlier patch, "staging: et131x:
Removing Olaf Hartmann's email as it bounces", got mixed up with this one.
Cheers,
Signature · 1 line
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
Quoted 11 lines · Nick Bowler
Hi Mark,
Quoted 8 lines · Mark Einon
drivers/staging/et131x/README +0
-0@@ -2,13 +2,18 @@ This is a driver for the ET1310 network device.Based on the driver found at https://sourceforge.net/projects/et131x/
Quoted 7 lines
drivers/staging/et131x/README This is a driver for the ET1310 network device. · line 5
Quoted 3 lines
drivers/staging/et131x/README +1
-2-Cleaned up immensely by Olaf Hartman and Christoph -Hellwig <[email protected]> +Cleaned up immensely by Olaf Hartman and Christoph Hellwig <[email protected]>It seems that a fragment from your earlier patch, "staging: et131x:
Removing Olaf Hartmann's email as it bounces", got mixed up with this one.
Hi Nick,
Well spotted!
Actually, I was just sneaking in the removal of a carriage return which I didn't do in the earlier patch.
I didn't think that anyone would mind, being in an unnoticeable README file in the staging directory of a staging-next tree - inhabiting a small, insignificant blue green planet, circling a star we call the Sun, in an unfashionable outer spiral arm of a galaxy known as the Milky Way.
Let me know if its a problem.
Best regards,
Mark
Quoted 27 lines · Mark Einon
Quoted 11 lines · Nick Bowler
Hi Mark,
Quoted 8 lines · Mark Einon
drivers/staging/et131x/README +0
-0@@ -2,13 +2,18 @@ This is a driver for the ET1310 network device.Based on the driver found at https://sourceforge.net/projects/et131x/
Quoted 7 lines
drivers/staging/et131x/README This is a driver for the ET1310 network device. · line 5
Quoted 3 lines
drivers/staging/et131x/README +1
-2-Cleaned up immensely by Olaf Hartman and Christoph -Hellwig <[email protected]> +Cleaned up immensely by Olaf Hartman and Christoph Hellwig <[email protected]>It seems that a fragment from your earlier patch, "staging: et131x:
Removing Olaf Hartmann's email as it bounces", got mixed up with this one.Hi Nick,
Well spotted!
Actually, I was just sneaking in the removal of a carriage return which I didn't do in the earlier patch.
Quoted 7 lines
I didn't think that anyone would mind, being in an unnoticeable README file in the staging directory of a staging-next tree - inhabiting a small, insignificant blue green planet, circling a star we call the Sun, in an unfashionable outer spiral arm of a galaxy known as the Milky Way.
Let me know if its a problem.
It's really not for something like this, I'll take it as-is.
greg k-h
Hi Mark,
I wish to contribute to this project - From the latest TODO list in the README document
drivers/staging/et131x/README
If I were to start with the coding style cleanups, is there a coding standard available for reference? Please advice.
Thanks
Ramesh
Quoted 41 lines · Mark Einon
Added some more tasks to the TODO list, as highlighted by Francois Romieu <[email protected]>.
Signed-off-by Mark Einon <[email protected]>---
drivers/staging/et131x/README | 9 +++++++--1 files changed, 7 insertions(+), 2 deletions(-)drivers/staging/et131x/README +0
-0@@ -2,13 +2,18 @@ This is a driver for the ET1310 network device.Based on the driver found at https://sourceforge.net/projects/et131x/
drivers/staging/et131x/README +1
-2-Cleaned up immensely by Olaf Hartman and Christoph -Hellwig <[email protected]> +Cleaned up immensely by Olaf Hartman and Christoph Hellwig <[email protected]>Note, the powermanagement options were removed from the vendor provided driver as they did not build properly at the time.
TODO:
+ - Put the driver into a single file, with a .h for the registers layout.
+ - rx_ring.fbr{0, 1} can probably share a common structure
+ - Use ofkmem_cacheseems a bit unusual
+ - Usedma_alloc_... in place ofpci_alloc_...
+ - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet.
+ -PCI_VDEVICE?Please send patches to:
Greg Kroah-Hartman <[email protected]>
--
1.7.6.4_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
Quoted 9 lines · Ramesh R
Hi Mark,
I wish to contribute to this project - From the latest TODO list in the README document
drivers/staging/et131x/READMEIf I were to start with the coding style cleanups, is there a coding standard available for reference? Please advice.
Documentation/CodingStyle
Quoted 6 lines · Greg KH
Quoted 5 lines · Ramesh R
Hi Mark,
I wish to contribute to this project - From the latest TODO list in the README document
Quoted 7 lines
Quoted 4 lines
drivers/staging/et131x/READMEIf I were to start with the coding style cleanups, is there a coding standard available for reference? Please advice.
Documentation/CodingStyle
Ramesh,
There are no significant coding style issues with this particular driver at this time, as far as I (and the checkpatch script) are aware of.
I suggest you check other staging/ drivers for these sorts of issues.
Cheers,
Mark
Thanks Mark,
Are there any open items left in the TODO list for this driver at this point?
Regards
Ramesh
Quoted 25 lines · Mark Einon
Quoted 6 lines · Greg KH
Quoted 5 lines · Ramesh R
Hi Mark,
I wish to contribute to this project - From the latest TODO list in the README document
Quoted 7 lines
Quoted 4 lines
drivers/staging/et131x/READMEIf I were to start with the coding style cleanups, is there a coding standard available for reference? Please advice.
Documentation/CodingStyleRamesh,
There are no significant coding style issues with this particular driver at this time, as far as I (and the checkpatch script) are aware of.
I suggest you check other staging/ drivers for these sorts of issues.Cheers,
Mark
If you look at the patch once again then you find some
Quoted 38 lines · Ramesh R
Thanks Mark,
Are there any open items left in the TODO list for this driver at this point?
Regards
RameshQuoted 16 lines · Mark Einon
Quoted 6 lines · Greg KH
Quoted 5 lines · Ramesh R
Hi Mark,
I wish to contribute to this project - From the latest TODO list in the README document
Quoted 7 lines
Quoted 4 lines
drivers/staging/et131x/READMEIf I were to start with the coding style cleanups, is there a coding standard available for reference? Please advice.
Documentation/CodingStyleRamesh,
Quoted 9 lines
There are no significant coding style issues with this particular driver at this time, as far as I (and the checkpatch script) are aware of.
I suggest you check other staging/ drivers for these sorts of issues.Cheers,
Mark
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
Signature · 2 lines
Regards, Denis
Quoted 41 lines · Denis Kirjanov
If you look at the patch once again then you find some
Quoted 38 lines · Ramesh R
Thanks Mark,
Are there any open items left in the TODO list for this driver at this point?
Regards
RameshQuoted 16 lines · Mark Einon
Quoted 6 lines · Greg KH
Quoted 5 lines · Ramesh R
Hi Mark,
I wish to contribute to this project - From the latest TODO list in the README document
Quoted 7 lines
Quoted 4 lines
drivers/staging/et131x/READMEIf I were to start with the coding style cleanups, is there a coding standard available for reference? Please advice.
Documentation/CodingStyleRamesh,
Quoted 9 lines
There are no significant coding style issues with this particular driver at this time, as far as I (and the checkpatch script) are aware of.
I suggest you check other staging/ drivers for these sorts of issues.Cheers,
Mark
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
Thank you, got a few items.
I could work on item #1,
==
TODO:
+ - Put the driver into a single file, with a .h for the registers layout.
+ - rx_ring.fbr{0, 1} can probably share a common structure
+ - Use of kmem_cache seems a bit unusual
+ - Use dma_alloc_... in place of pci_alloc_...
+ - It's too late stopping the tx queue when there is no roomfor the current packet. The condition should be detected for the next packet.
+ - PCI_VDEVICE ?
==
I looked up for ET 1310 on ebay, amazon & few other sites like digikey
- I couldnt find the device. Can you please let me know where I can buy the hardware?
/Ramesh
Quoted 1 line · Ramesh R
I could work on item #1,
Actually, I have some patches for that ready to post this evening. Any other item is good, however.
Quoted 11 lines
==
TODO:
+ - Put the driver into a single file, with a .h for the registers layout.
+ - rx_ring.fbr{0, 1} can probably share a common structure
+ - Use ofkmem_cacheseems a bit unusual
+ - Usedma_alloc_... in place ofpci_alloc_...
+ - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet.
+ -PCI_VDEVICE?
Quoted 5 lines
==
I looked up for ET 1310 on ebay, amazon & few other sites like digikey
- I couldnt find the device. Can you please let me know where I can buy the hardware?
I'm afraid I can't be of much help with that - its quite hard to get hold of. I believe the chip is a few years old, not made anymore and was not widely sold when it was.
I managed to get hold of a card from eBay via a seller in France.
Mark