Skip to contentSkip to conversation

Regulator: DA9052/53 regulator support v5

PATCH In review ashishj3 3 participants 4 messages Oct 18, 2011 – Nov 9, 2011

Subsystems (2)
lore
Share & tools
lore

ashishj3

author
#0 lore raw

PATCH 5/11 Regulator: DA9052/53 regulator support v5

The Dialog PMIC has below featured regulators:- DA9052-BC - 4 DVS Buck converters 0.5V - 3.6V upto 1Amp. DA9053-AA/BX - 4 DVS Buck converters 0.5V - 2.5V upto 3Amp. DA9052/53 - 10 Programmable LDO's High PSSR, 1% accuracy.

This patch support all the DA9052 and Da9053 regulators. The output voltages are fully programmable via I2C or SPI interface. The platform data with regulation constraints is passed down from the board to the regulator.

CC Mark Brown <[email protected]>

---
Changes since v5
- Modify Kconfig to describe the config symbol
- Change file permissions - remove execute permission
- Line 43 - Adjust for 80 characters width
Changes since v4
- Add support for DA9053
- Correct the definition of macros DA9052_BUCK_ILIM_MASK
- Get current limit to return current limit in microA
- Correct the voltage selector value for Buck Peri above 3v
- Set the struct member regualtor->da9052 in probe() Changes since v3
- Corrected verify_range function
Changes since v2
- Check for current min_uA < 700000
- Corrected current conversions from mA to uA

---
 drivers/regulator/Kconfig            |    7 +
 drivers/regulator/Makefile           |    1 +
 drivers/regulator/da9052-regulator.c |  600 ++++++++++++++++++++++++++++++++++
 3 files changed, 608 insertions(+), 0 deletions(-)
 create mode 100644 drivers/regulator/da9052-regulator.c
drivers/regulator/Kconfig +7 -0
index 9713b1b..4f4774b 100644
@@ -177,6 +177,13 @@ config REGULATOR_DA903X
 	  Say y here to support the BUCKs and LDOs regulators found on
 	  Dialog Semiconductor DA9030/DA9034 PMIC.
 
+config REGULATOR_DA9052
+	tristate "Dialog DA9052/DA9053 regulators"
+	depends on PMIC_DA9052
+	help
+	  This driver supports the voltage regulators of DA9052-BC and
+	  DA9053-AA/Bx PMIC.
+
 config REGULATOR_PCF50633
 	tristate "PCF50633 regulator driver"
         depends on MFD_PCF50633
drivers/regulator/Makefile +1 -0
index 93a6318..07b2126 100644
@@ -29,6 +29,7 @@ obj-$(CONFIG_REGULATOR_WM8400) += wm8400-regulator.o
 obj-$(CONFIG_REGULATOR_WM8994) += wm8994-regulator.o
 obj-$(CONFIG_REGULATOR_TPS6586X) += tps6586x-regulator.o
 obj-$(CONFIG_REGULATOR_DA903X)	+= da903x.o
+obj-$(CONFIG_REGULATOR_DA9052)	+= da9052-regulator.o
 obj-$(CONFIG_REGULATOR_PCF50633) += pcf50633-regulator.o
 obj-$(CONFIG_REGULATOR_PCAP) += pcap-regulator.o
 obj-$(CONFIG_REGULATOR_MC13783) += mc13783-regulator.o
drivers/regulator/da9052-regulator.c new file +600 -0

600 lines not on this page · raw message

author
#1 lore raw
Quoted 9 lines · On Tue, 2011-10-18 at 20:37 +0530, ashishj3 wrote:

The Dialog PMIC has below featured regulators:- DA9052-BC - 4 DVS Buck converters 0.5V - 3.6V upto 1Amp. DA9053-AA/BX - 4 DVS Buck converters 0.5V - 2.5V upto 3Amp. DA9052/53 - 10 Programmable LDO's High PSSR, 1% accuracy.

This patch support all the DA9052 and Da9053 regulators. The output voltages are fully programmable via I2C or SPI interface. The platform data with regulation constraints is passed down from the board to the regulator.

Quoted 6 lines
CC Mark Brown <[email protected]>

---

If there are no review commnets then can it get ACK?

#2 lore raw
Quoted 10 lines · (2011年11月08日 16:28), ashishj3 wrote:
Quoted 9 lines · On Tue, 2011-10-18 at 20:37 +0530, ashishj3 wrote:

The Dialog PMIC has below featured regulators:- DA9052-BC - 4 DVS Buck converters 0.5V - 3.6V upto 1Amp. DA9053-AA/BX - 4 DVS Buck converters 0.5V - 2.5V upto 3Amp. DA9052/53 - 10 Programmable LDO's High PSSR, 1% accuracy.

This patch support all the DA9052 and Da9053 regulators. The output voltages are fully programmable via I2C or SPI interface. The platform data with regulation constraints is passed down from the board to the regulator.

Quoted 9 lines
Quoted 6 lines
CC Mark Brown <[email protected]>

---

If there are no review commnets then can it get ACK?

Thanks Ashish.

Hi Mark,

I've already tested this driver (v5) with the DA9052 MFD v8 driver posted on 20111103. It is tested on my imx53 Quickstart board. This patch also looks good to me. Please review this driver if possible.

Many Thanks,
Paul

#3 lore raw
Quoted 5 lines · Ying-Chun Liu (PaulLiu)

Hi Mark,

I've already tested this driver (v5) with the DA9052 MFD v8 driver posted on 20111103. It is tested on my imx53 Quickstart board. This patch also looks good to me. Please review this driver if possible.

Please resubmit if you want it reviewed, to reiterate the problems with the core driver meant I didn't see much value in reviewing the code. I can't review the code if I don't have a copy. I'm also note sure why you're asking me alone to review the code?

If Linaro wants to help get this stuff upstream I strongly suggest you help the guys with the process issues that have been (for example we've still not seen an actual patch series submitted). Possibly taking over the actual patch submissions would be helpful.