Skip to contentSkip to conversation

Power: DA9052 battery driver v4

PATCH In review Ashish Jangam 2 participants 4 messages Oct 19, 2011 – Nov 8, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 4/11 Power: DA9052 battery driver v4

Driver for DA9052 battery charger. This driver depends on DA9052 MFD core dirver for definitions and methods.

---
Changes since v3
- Included power_supply.h file
- Corrected the definition of DA9052_BAT_THRESHOLD macro
- Changed definition of charger_type_enum
- Added API da9052_battery_read_end_current
- Added API da9052_battery_check_status
- Changed the way of handling the interrupts in da9052_bat_irq Changes since v2
- Correct code styling for inline functions
- Remove averaging algorithm
- Set use_for_apm thru board specific parameter

---
 drivers/power/Kconfig          |    7 +
 drivers/power/Makefile         |    1 +
 drivers/power/da9052-battery.c |  611 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 619 insertions(+), 0 deletions(-)
 create mode 100755 drivers/power/da9052-battery.c
drivers/power/Kconfig +7 -0
index 57de051..c041712 100644
@@ -149,6 +149,13 @@ config BATTERY_DA9030
 	  Say Y here to enable support for batteries charger integrated into
 	  DA9030 PMIC.
 
+config BATTERY_DA9052
+	tristate "Dialog DA9052 Battery"
+	depends on PMIC_DA9052
+	help
+	  Say Y here to enable support for batteries charger integrated into
+	  DA9052 PMIC.
+
 config BATTERY_MAX17040
 	tristate "Maxim MAX17040 Fuel Gauge"
 	depends on I2C
drivers/power/Makefile +1 -0
index b4af13d..c570e20 100644
@@ -25,6 +25,7 @@ obj-$(CONFIG_BATTERY_WM97XX)	+= wm97xx_battery.o
 obj-$(CONFIG_BATTERY_BQ20Z75)	+= bq20z75.o
 obj-$(CONFIG_BATTERY_BQ27x00)	+= bq27x00_battery.o
 obj-$(CONFIG_BATTERY_DA9030)	+= da9030_battery.o
+obj-$(CONFIG_BATTERY_DA9052)	+= da9052-battery.o
 obj-$(CONFIG_BATTERY_MAX17040)	+= max17040_battery.o
 obj-$(CONFIG_BATTERY_MAX17042)	+= max17042_battery.o
 obj-$(CONFIG_BATTERY_Z2)	+= z2_battery.o
drivers/power/da9052-battery.c new file +611 -0

611 lines not on this page · raw message

#2 lore raw
Quoted 8 lines · Ashish Jangam
Quoted 6 lines · Ashish Jangam

Driver for DA9052 battery charger. This driver depends on DA9052 MFD core dirver for definitions and methods.

---

In case there are no review comments then can this be get ACK'ed?

The last time you posted this there was a serious issues with the MFD core which meant it didn't seem worth reviewing.

#3 lore raw
Quoted 14 lines

-----Original Message-----
From: Mark Brown [mailto:[email protected]]
Sent: Tuesday, November 08, 2011 3:53 PM
To: Ashish Jangam
Cc: [email protected]; [email protected]; [email protected]; linux- [email protected]; Dajun
Subject: Re: [Patch 04/11]Power: DA9052 battery driver v4

Quoted 2 lines · Ashish Jangam
Quoted 1 line · Ashish Jangam

Driver for DA9052 battery charger. This driver depends on DA9052 MFD

core dirver

Quoted 2 lines
Quoted 2 lines

for definitions and methods.

Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

---

In case there are no review comments then can this be get ACK'ed?

The last time you posted this there was a serious issues with the MFD core which meant it didn't seem worth reviewing.

If MFD know looks good to you then please ACK it.

���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�