Skip to contentSkip to conversation

drivers: ata: libata-scsi.c: Add function parameter documentation

PATCH In review Marcos Paulo de Souza 2 participants 3 messages Nov 1, 2011 – Nov 8, 2011 libata

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 drivers: ata: libata-scsi.c: Add function parameter documentation

Add the documentation of parameters of ata_change_queue_depth to silence the warning of make xmldocs

---
 drivers/ata/libata-scsi.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/ata/libata-scsi.c +4 -0
index 19ba770..5eceb23 100644
@@ -1216,6 +1216,10 @@ void ata_scsi_slave_destroy(struct scsi_device *sdev)
 
 /**
  *	__ata_change_queue_depth - helper for ata_scsi_change_queue_depth
+ *	@ap: ATA port to which the device change the queue depth
+ *	@sdev: SCSI device to configure queue depth for
+ *	@queue_depth: new queue depth
+ *	@reason: calling context
  *
  *	libsas and libata have different approaches for associating a sdev to
  *	its ata_port.
Signature · 1 line
1.7.4.1
Acked-by on v1 3/3
#1 lore raw
Quoted 3 lines · Marcos Paulo de Souza

Add the documentation of parameters of ata_change_queue_depth to silence the warning of make xmldocs

Thanks.

Quoted 19 lines
---
 drivers/ata/libata-scsi.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/ata/libata-scsi.c +4 -0
index 19ba770..5eceb23 100644
@@ -1216,6 +1216,10 @@ void ata_scsi_slave_destroy(struct scsi_device *sdev)
 
 /**
  *	__ata_change_queue_depth - helper for ata_scsi_change_queue_depth
+ *	@ap: ATA port to which the device change the queue depth
+ *	@sdev: SCSI device to configure queue depth for
+ *	@queue_depth: new queue depth
+ *	@reason: calling context
  *
  *	libsas and libata have different approaches for associating a sdev to
  *	its ata_port.
Signature · 2 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
#2 lore raw

ping?

2011/11/1, Randy Dunlap <[email protected]>:

Quoted 36 lines · Marcos Paulo de Souza
Quoted 4 lines

Add the documentation of parameters of ata_change_queue_depth to silence the warning of make xmldocs

Thanks.

Quoted 19 lines
---
 drivers/ata/libata-scsi.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/ata/libata-scsi.c +4 -0
index 19ba770..5eceb23 100644
@@ -1216,6 +1216,10 @@ void ata_scsi_slave_destroy(struct scsi_device
 *sdev)
 
 /**
  *	__ata_change_queue_depth - helper for ata_scsi_change_queue_depth
+ *	@ap: ATA port to which the device change the queue depth
+ *	@sdev: SCSI device to configure queue depth for
+ *	@queue_depth: new queue depth
+ *	@reason: calling context
  *
  *	libsas and libata have different approaches for associating a sdev to
Quoted 1 line

* its ata_port.

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Signature · 3 lines
Marcos Paulo de Souza

*Porque uma vida sem desafios é uma vida sem razão.*