Skip to contentSkip to conversation

staging: rtl8192e: Use kzalloc rather than kmalloc

PATCH In review Thomas Meyer 2 participants 2 messages Nov 8, 2011 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8192e: Use kzalloc rather than kmalloc

From: Thomas Meyer <[email protected]>

Use kzalloc rather than kmalloc followed by memset with 0

This considers some simple cases that are common and easy to validate Note in particular that there are no ...s in the rule, so all of the matched code has to be contiguous

The semantic patch that makes this change is available in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

---

drivers/staging/rtl8192e/rtllib_softmac.c 2011-11-08 09:40:07.649215930 +0100 renamed from drivers/staging/rtl8192e/rtllib_softmac.c 2011-11-07 19:38:11.780313813 +0100 +1 -2
diff -u -p a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -3048,10 +3048,9 @@ void rtllib_softmac_init(struct rtllib_d
 	ieee->state = RTLLIB_NOLINK;
 	for (i = 0; i < 5; i++)
 		ieee->seq_ctrl[i] = 0;
-	ieee->pDot11dInfo = kmalloc(sizeof(struct rt_dot11d_info), GFP_ATOMIC);
+	ieee->pDot11dInfo = kzalloc(sizeof(struct rt_dot11d_info), GFP_ATOMIC);
 	if (!ieee->pDot11dInfo)
 		RTLLIB_DEBUG(RTLLIB_DL_ERR, "can't alloc memory for DOT11D\n");
-	memset(ieee->pDot11dInfo, 0, sizeof(struct rt_dot11d_info));
 	ieee->LinkDetectInfo.SlotIndex = 0;
 	ieee->LinkDetectInfo.SlotNum = 2;
 	ieee->LinkDetectInfo.NumRecvBcnInPeriod = 0;
#1 lore raw
Quoted 2 lines · Thomas Meyer

From: Thomas Meyer <[email protected]>

You should seriously consider giving your patch mails unique subjects.

Many patches with identical subjects are prone to be missed by people on the list and it's also harder to refer to a specific patch later.

Signature · 3 lines
Jesper Juhl <[email protected]>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.