Fix : [Bug 887516] [NEW] VFP support reported for the PXA270
PATCH 1/1 arm-linux-user: fix elfload.c's AT_HWCAP to reflect cpu features.
In reply to Benoît CanetThe cpu capabilities passed by the elf loader in AT_HWCAP where a constant.
Make AT_HWCAP reflect the emulated cpu features in order to give correct clues to eglibc.
Fix : [Bug 887516] [NEW] VFP support reported for the PXA270
Signed-off-by Benoit Canet <[email protected]>
--- linux-user/elfload.c | 31 +++++++++++++++++++++++++++---- 1 files changed, 27 insertions(+), 4 deletions(-)
linux-user/elfload.c +27 -4
@@ -375,10 +375,33 @@ bool guest_validate_base(unsigned long guest_base) return 1; /* All good */ } -#define ELF_HWCAP (ARM_HWCAP_ARM_SWP | ARM_HWCAP_ARM_HALF \ - | ARM_HWCAP_ARM_THUMB | ARM_HWCAP_ARM_FAST_MULT \ - | ARM_HWCAP_ARM_FPA | ARM_HWCAP_ARM_VFP \ - | ARM_HWCAP_ARM_NEON | ARM_HWCAP_ARM_VFPv3 ) + +#define ELF_HWCAP get_elf_hwcap() + +static uint32_t get_elf_hwcap (void ) +{ +CPUState *e = thread_env; +uint32_t hwcaps =0 ; + + hwcaps |=ARM_HWCAP_ARM_SWP ; + hwcaps |=ARM_HWCAP_ARM_HALF ; + hwcaps |=ARM_HWCAP_ARM_THUMB ; + hwcaps |=ARM_HWCAP_ARM_FAST_MULT ; + hwcaps |=ARM_HWCAP_ARM_FPA ; + +/* probe for the extra features */ +#define GET_FEATURE (feat, hwcap) \ + do {if (arm_feature(e, feat)) { hwcaps |= hwcap; } } while (0) +GET_FEATURE (ARM_FEATURE_VFP ,ARM_HWCAP_ARM_VFP ); +GET_FEATURE (ARM_FEATURE_IWMMXT ,ARM_HWCAP_ARM_IWMMXT ); +GET_FEATURE (ARM_FEATURE_THUMB2EE ,ARM_HWCAP_ARM_THUMBEE ); +GET_FEATURE (ARM_FEATURE_NEON ,ARM_HWCAP_ARM_NEON ); +GET_FEATURE (ARM_FEATURE_VFP3 , ARM_HWCAP_ARM_VFPv3); +GET_FEATURE (ARM_FEATURE_VFP_FP16 , ARM_HWCAP_ARM_VFPv3D16); +#undef GET_FEATURE + +return hwcaps; +}#endif
Signature · 1 line
1.7.5.4
PATCH v2 1/1 Fix : [Bug 887516] [NEW] VFP support reported for the PXA270
A VFP was detected for pxa270 causing an "Illegal instruction" exception.
The eglibc was not receiving the right AT_HWCAP from elfloader.c.
This version fix typos.
Benoît Canet (1):
arm-linux-user: fix elfload.c's AT_HWCAP to reflect cpu features.
linux-user/elfload.c | 31 +++++++++++++++++++++++++++---- 1 files changed, 27 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.5.4