Skip to contentSkip to conversation

dlm: Use kmemdup rather than duplicating its implementation

PATCH New Thomas Meyer 1 participant 1 message Nov 10, 2011 Distributed lock manager (DLM)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dlm: Use kmemdup rather than duplicating its implementation

Use kmemdup rather than duplicating its implementation

The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci.

---

fs/dlm/lowcomms.c 2011-11-08 10:35:11.176833032 +0100 renamed from fs/dlm/lowcomms.c 2011-11-07 19:38:22.277139918 +0100 +1 -2
diff -u -p a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
@@ -1086,10 +1086,9 @@ static void init_local(void)
 		if (dlm_our_addr(&sas, i))
 			break;
 
-		addr = kmalloc(sizeof(*addr), GFP_NOFS);
+		addr = kmemdup(&sas, sizeof(*addr), GFP_NOFS);
 		if (!addr)
 			break;
-		memcpy(addr, &sas, sizeof(*addr));
 		dlm_local_addr[dlm_local_count++] = addr;
 	}
 }