Skip to contentSkip to conversation

get_maintainers.pl: Follow renames when looking up commit signers

PATCH In review Ian Campbell 4 participants 7 messages Nov 11, 2011 – Nov 14, 2011 GET_MAINTAINER script

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 get_maintainers.pl: Follow renames when looking up commit signers

I happen to have had a commit to various network drivers since the big renaming/reorg which happened to drivers/net recently. This means that I now appear to be in the top few commit signers (by %age) for many of them so am getting sent all sorts of stuff and people who are involved with the driver are not. e.g. (to pick one at random):

        $ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
        "David S. Miller" <[email protected]> (commit_signer:5/7=71%)
        Ian Campbell <[email protected]> (commit_signer:2/7=29%)
        Eric Dumazet <[email protected]> (commit_signer:1/7=14%)
        Jeff Kirsher <[email protected]> (commit_signer:1/7=14%)
        Jiri Pirko <[email protected]> (commit_signer:1/7=14%)
        [email protected] (open list:NETWORKING DRIVERS)
        [email protected] (open list)

With the following patch the renames are followed and the result appears much more sensible:

        $ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
        "David S. Miller" <[email protected]> (commit_signer:31/34=91%)
        Joe Perches <[email protected]> (commit_signer:11/34=32%)
        Szymon Janc <[email protected]> (commit_signer:5/34=15%)
        Jiri Pirko <[email protected]> (commit_signer:3/34=9%)
        Paul <[email protected]> (commit_signer:2/34=6%)
        [email protected] (open list:NETWORKING DRIVERS)
        [email protected] (open list)
Signed-off-by [email protected]
scripts/get_maintainer.pl +1 -1
index 4594f33..f32a04c 100755
@@ -95,7 +95,7 @@ my %VCS_cmds_git = (
     "execute_cmd" => \&git_execute_cmd,
     "available" => '(which("git") ne "") && (-d ".git")',
     "find_signers_cmd" =>
-	"git log --no-color --since=\$email_git_since " .
+	"git log --no-color --follow --since=\$email_git_since " .
 	    '--format="GitCommit: %H%n' .
 		      'GitAuthor: %an <%ae>%n' .
 		      'GitDate: %aD%n' .
maintainer
#1 lore raw

On Fri, 2011-11-11 at 07:59 +0000, Ian Campbell wrote:
[]

scripts/get_maintainer.pl

Quoted 1 line
scripts/get_maintainer.pl +0 -0

[]

scripts/get_maintainer.pl my %VCS_cmds_git = ( · line 95

Quoted 3 lines
scripts/get_maintainer.pl +1 -1
@@ -95,7 +95,7 @@ my %VCS_cmds_git = (
-	"git log --no-color --since=\$email_git_since " .
+	"git log --no-color --follow --since=\$email_git_since " .
#3 lore raw

Re: Mercurial linux-kernel repository at kernel.org?

[uncrossposting]

Quoted 5 lines · Joe Perches

Prior to intrusion, a mercurial repository essentially duplicating the Linus' git tree existed at:
http://www.kernel.com/hg/linux-2.6

I do not use it, but are there any plans to restore it?

Not on kernel.org, certainly.

I asked the kernel.org admins a while back to send me a copy of the SHA map file from my account I needed to continue the mirror elsewhere and HPA declined, making some handwaving towards "eventually letting people download tarballs of their old accounts".

As far as I know, "eventually" hasn't happened yet. I guess it's time to fire up a new mirror from scratch. It'll be incompatible with old clones due to not having the above file and various minor changes in both git and hg in the 6 years the original mirror was running. I'll announce it when it's done - it'll probably take a while.

Signature · 1 line
Mathematics is the supreme nostalgia of our time.
maintainer
#4 lore raw

Re: Mercurial linux-kernel repository at kernel.org?

Quoted 16 lines · Matt Mackall

[uncrossposting]

Quoted 5 lines · Joe Perches

Prior to intrusion, a mercurial repository essentially duplicating the Linus' git tree existed at:
http://www.kernel.com/hg/linux-2.6

I do not use it, but are there any plans to restore it?

Not on kernel.org, certainly.

I asked the kernel.org admins a while back to send me a copy of the SHA map file from my account I needed to continue the mirror elsewhere and HPA declined, making some handwaving towards "eventually letting people download tarballs of their old accounts".

Quoted 5 lines

As far as I know, "eventually" hasn't happened yet. I guess it's time to fire up a new mirror from scratch. It'll be incompatible with old clones due to not having the above file and various minor changes in both git and hg in the 6 years the original mirror was running. I'll announce it when it's done - it'll probably take a while.

No worries. I'm not an hg user. Ian Campbell sent a patch to get_maintainer to use git log option --follow for a largish file rename event in drivers/net/... and I was trying to get the hg commands in get_maintainer to do the same.

Any idea if tracking file renames in hg needs an additional command line option and if so what it is?

#5 lore raw

Re: Mercurial linux-kernel repository at kernel.org?

Quoted 23 lines · Joe Perches
Quoted 16 lines · Matt Mackall

[uncrossposting]

Quoted 5 lines · Joe Perches

Prior to intrusion, a mercurial repository essentially duplicating the Linus' git tree existed at:
http://www.kernel.com/hg/linux-2.6

I do not use it, but are there any plans to restore it?

Not on kernel.org, certainly.

I asked the kernel.org admins a while back to send me a copy of the SHA map file from my account I needed to continue the mirror elsewhere and HPA declined, making some handwaving towards "eventually letting people download tarballs of their old accounts".

Quoted 5 lines

As far as I know, "eventually" hasn't happened yet. I guess it's time to fire up a new mirror from scratch. It'll be incompatible with old clones due to not having the above file and various minor changes in both git and hg in the 6 years the original mirror was running. I'll announce it when it's done - it'll probably take a while.

Quoted 7 lines

No worries. I'm not an hg user. Ian Campbell sent a patch to get_maintainer to use git log option --follow for a largish file rename event in drivers/net/... and I was trying to get the hg commands in get_maintainer to do the same.

Any idea if tracking file renames in hg needs an additional command line option and if so what it is?

hg log --follow <some-file> will follow the history across renames.

Signature · 1 line
Mathematics is the supreme nostalgia of our time.
#6 lore raw

Re: Mercurial linux-kernel repository at kernel.org?

In reply to Matt Mackall
Quoted 3 lines
Quoted 1 line

I do not use it, but are there any plans to restore it?

Not on kernel.org, certainly.

I'll actually say, it hasn't been an immediate priority given the number of other tasks that are more immediately pending.

Quoted 4 lines

I asked the kernel.org admins a while back to send me a copy of the SHA map file from my account I needed to continue the mirror elsewhere and HPA declined, making some handwaving towards "eventually letting people download tarballs of their old accounts".

There hasn't been any serious movement on getting you your home directory for several reasons:

1) You haven't asked for your account to be reinstated on kernel.org. I have no record of you having ever sent in a gpg key at all, let alone one that's been signed so we can verify you and your request

2) Without a gpg key so we can verify you and your request, we can't encrypt your home dir and get it to you.

3) You asked hpa directly and not [email protected]

Quoted 5 lines

As far as I know, "eventually" hasn't happened yet. I guess it's time to fire up a new mirror from scratch. It'll be incompatible with old clones due to not having the above file and various minor changes in both git and hg in the 6 years the original mirror was running. I'll announce it when it's done - it'll probably take a while.