Skip to contentSkip to conversation

selinux: Casting (void *) value returned by kmalloc is useless

PATCH In review Thomas Meyer 2 participants 2 messages Nov 18, 2011 – Dec 19, 2011 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selinux: Casting (void *) value returned by kmalloc is useless

The semantic patch that makes this change is available in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.

---

security/selinux/ss/conditional.c 2011-11-08 09:16:49.914488441 +0100 renamed from security/selinux/ss/conditional.c 2011-11-07 19:38:36.047349083 +0100 +1 -1
diff -u -p a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
@@ -175,7 +175,7 @@ void cond_policydb_destroy(struct policy
 int cond_init_bool_indexes(struct policydb *p)
 {
 	kfree(p->bool_val_to_struct);
-	p->bool_val_to_struct = (struct cond_bool_datum **)
+	p->bool_val_to_struct =
 		kmalloc(p->p_bools.nprim * sizeof(struct cond_bool_datum *), GFP_KERNEL);
 	if (!p->bool_val_to_struct)
 		return -ENOMEM;