Skip to contentSkip to conversation

gpio: pca953x: Staticise pca953x_get_altdata()

PATCH In review Mark Brown 2 participants 2 messages Nov 21, 2011 GPIO

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 gpio: pca953x: Staticise pca953x_get_altdata()

It's not used outside of the driver so doesn't need to be exported, and sparse notices this and complains about it.

---
 drivers/gpio/gpio-pca953x.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-pca953x.c +2 -2
index 147df8a..d3f3e8f 100644
@@ -546,7 +546,7 @@ static void pca953x_irq_teardown(struct pca953x_chip *chip)
  * Translate OpenFirmware node properties into platform_data
  * WARNING: This is DEPRECATED and will be removed eventually!
  */
-void
+static void
 pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int *invert)
 {
 	struct device_node *node;
@@ -574,7 +574,7 @@ pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int *invert)
 		*invert = *val;
 }
 #else
-void
+static void
 pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int *invert)
 {
 	*gpio_base = -1;
Signature · 1 line
1.7.7.3
#1 lore raw
Quoted 4 lines · Mark Brown

It's not used outside of the driver so doesn't need to be exported, and sparse notices this and complains about it.

OK I've queued this for the -rcs.

Thanks!
Linus Walleij