acer-wmi: remove useless input argument for internal wmi
Subsystems (2)
PATCH 1/1 acer-wmi: remove useless input argument for internal wmi
From: "Lee, Chun-Yi" <[email protected]>
The "wmi_interface *iface" is a useless input argument for internal wmi get/set functions, remove it to clear up source code.
Tested on Lenovo E520.
Tested on Acer TravelMate 4750.
Tested-by mr.kobzar <[email protected]>
Cc Carlos Corbacho <[email protected]>
Cc Matthew Garrett <[email protected]>
Cc Dmitry Torokhov <[email protected]>
Cc Corentin Chary <[email protected]>
Cc Thomas Renninger <[email protected]>
Signed-off-by Lee, Chun-Yi <[email protected]>
--- drivers/platform/x86/acer-wmi.c | 30 ++++++++++++++---------------- 1 files changed, 14 insertions(+), 16 deletions(-)
drivers/platform/x86/acer-wmi.c +14 -16
@@ -536,8 +536,7 @@ struct acpi_buffer *result)return status; } -static acpi_status AMW0_get_u32 (u32 *value,u32 cap, -struct wmi_interface *iface) +static acpi_status AMW0_get_u32 (u32 *value,u32 cap) {int err;u8 result;
@@ -607,7 +606,7 @@ struct wmi_interface *iface)return AE_OK ; } -static acpi_status AMW0_set_u32 (u32 value,u32 cap,struct wmi_interface *iface) +static acpi_status AMW0_set_u32 (u32 value,u32 cap) {struct wmab_args args;
@@ -799,8 +798,7 @@ WMI_execute_u32(u32 method_id, u32 in, u32 *out)return status; } -static acpi_status WMID_get_u32 (u32 *value,u32 cap, -struct wmi_interface *iface) +static acpi_status WMID_get_u32 (u32 *value,u32 cap) {acpi_status status;u8 tmp;
@@ -836,7 +834,7 @@ struct wmi_interface *iface)return status; } -static acpi_status WMID_set_u32 (u32 value,u32 cap,struct wmi_interface *iface) +static acpi_status WMID_set_u32 (u32 value,u32 cap) {u32 method_id =0 ;char param;
@@ -1126,15 +1124,15 @@ static acpi_status get_u32(u32 *value, u32 cap)switch (interface->type) {case ACER_AMW0 : - status =AMW0_get_u32 (value, cap, interface); + status =AMW0_get_u32 (value, cap);break ;case ACER_AMW0_V2 :if (cap ==ACER_CAP_MAILLED ) { - status =AMW0_get_u32 (value, cap, interface); + status =AMW0_get_u32 (value, cap);break ; }case ACER_WMID : - status =WMID_get_u32 (value, cap, interface); + status =WMID_get_u32 (value, cap);break ;case ACER_WMID_v2: if (cap & (ACER_CAP_WIRELESS |
@@ -1142,7 +1140,7 @@ static acpi_status get_u32(u32 *value, u32 cap) ACER_CAP_THREEG)) status =wmid_v2_get_u32 (value, cap); else if (wmi_has_guid(WMID_GUID2)) - status =WMID_get_u32 (value, cap, interface); + status =WMID_get_u32 (value, cap);break ; }
@@ -1156,10 +1154,10 @@ static acpi_status set_u32(u32 value, u32 cap)if (interface->capability & cap) {switch (interface->type) {case ACER_AMW0 : -return AMW0_set_u32 (value, cap, interface); +return AMW0_set_u32 (value, cap);case ACER_AMW0_V2 :if (cap ==ACER_CAP_MAILLED ) -return AMW0_set_u32 (value, cap, interface); +return AMW0_set_u32 (value, cap);/* * On some models, some WMID methods don't toggle
@@ -1169,21 +1167,21 @@ static acpi_status set_u32(u32 value, u32 cap)*/ if (cap ==ACER_CAP_WIRELESS || cap ==ACER_CAP_BLUETOOTH ) { - status =WMID_set_u32 (value, cap, interface); + status =WMID_set_u32 (value, cap);if (ACPI_FAILURE (status))return status; -return AMW0_set_u32 (value, cap, interface); +return AMW0_set_u32 (value, cap); }case ACER_WMID : -return WMID_set_u32 (value, cap, interface); +return WMID_set_u32 (value, cap);case ACER_WMID_v2:if (cap & (ACER_CAP_WIRELESS |ACER_CAP_BLUETOOTH |ACER_CAP_THREEG ))return wmid_v2_set_u32 (value, cap);else if (wmi_has_guid (WMID_GUID2 )) -return WMID_set_u32 (value, cap, interface); +return WMID_set_u32 (value, cap);default :return AE_BAD_PARAMETER ; }
Signature · 1 line
1.7.7