Skip to contentSkip to conversation

ARM: S3C64XX: Improve logging of unknown Cragganmore module types

PATCH New Mark Brown 1 participant 1 message Nov 28, 2011

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ARM: S3C64XX: Improve logging of unknown Cragganmore module types

As our ID table is populated with hexidecimal values it makes sense to log unknown module IDs in hexidecimal. It's also helpful to display board revisions as 1 based rather than 0 based as that's the numbering system used for the hardware (and what we do when announcing known modules).

---
 arch/arm/mach-s3c64xx/mach-crag6410-module.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s3c64xx/mach-crag6410-module.c +2 -2
index 8e19ce6..bb87348 100644
@@ -217,8 +217,8 @@ static __devinit int wlf_gf_module_probe(struct i2c_client *i2c,
 		spi_register_board_info(gf_mods[i].spi_devs,
 					gf_mods[i].num_spi_devs);
 	} else {
-		dev_warn(&i2c->dev, "Unknown module ID %d revision %d\n",
-			 id, rev);
+		dev_warn(&i2c->dev, "Unknown module ID 0x%x revision %d\n",
+			 id, rev + 1);
 	}
 
 	return 0;
Signature · 1 line
1.7.7.3