Skip to contentSkip to conversation

leds: Use kcalloc instead of kzalloc to allocate array

PATCH New Thomas Meyer 1 participant 1 message Dec 3, 2011 LED

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read.

The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107

---

drivers/leds/leds-mc13783.c 2011-11-28 19:59:58.327155325 +0100 renamed from drivers/leds/leds-mc13783.c 2011-11-13 11:07:27.873510772 +0100 +1 -1
diff -u -p a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
@@ -280,7 +280,7 @@ static int __devinit mc13783_led_probe(s
 		return -EINVAL;
 	}
 
-	led = kzalloc(sizeof(*led) * pdata->num_leds, GFP_KERNEL);
+	led = kcalloc(pdata->num_leds, sizeof(*led), GFP_KERNEL);
 	if (led == NULL) {
 		dev_err(&pdev->dev, "failed to alloc memory\n");
 		return -ENOMEM;