Skip to contentSkip to conversation

fuse: Use kcalloc instead of kzalloc to allocate array

PATCH In review Thomas Meyer 2 participants 2 messages Dec 5, 2011 – Dec 6, 2011 FUSE filesystem core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fuse: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read.

The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107

---

fs/fuse/file.c 2011-11-28 19:48:25.838294455 +0100 renamed from fs/fuse/file.c 2011-11-13 11:08:00.957365615 +0100 +1 -1
diff -u -p a/fs/fuse/file.c b/fs/fuse/file.c
@@ -1804,7 +1804,7 @@ long fuse_do_ioctl(struct file *file, un
 	BUILD_BUG_ON(sizeof(struct fuse_ioctl_iovec) * FUSE_IOCTL_MAX_IOV > PAGE_SIZE);
 
 	err = -ENOMEM;
-	pages = kzalloc(sizeof(pages[0]) * FUSE_MAX_PAGES_PER_REQ, GFP_KERNEL);
+	pages = kcalloc(FUSE_MAX_PAGES_PER_REQ, sizeof(pages[0]), GFP_KERNEL);
 	iov_page = (struct iovec *) __get_free_page(GFP_KERNEL);
 	if (!pages || !iov_page)
 		goto out;