Skip to contentSkip to conversation

tests/testdisplay.c: make the 3th pipe finish all the mode setting.

PATCH In review Yi Sun 2 participants 3 messages Dec 1, 2011 – Dec 16, 2011

lore
Share & tools
lore

Yi Sun

author
#0 lore raw

PATCH 1/1 tests/testdisplay.c: make the 3th pipe finish all the mode setting.

If test all modes rather than preferred mode, remove framebuffer and set CRTC to zero after each connector mode setting.

---
 tests/testdisplay.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)
tests/testdisplay.c +11 -1
index 3c9741c..7e25296 100644
@@ -373,7 +373,10 @@ static void connector_find_preferred_mode(struct connector *c)
 	}
 	c->crtc = resources->crtcs[i];
 	c->pipe = i;
-	resources->crtcs[i] = 0;
+
+	if(test_preferred_mode)
+		resources->crtcs[i] = 0;
+
 	c->connector = connector;
 }
 
@@ -941,6 +944,7 @@ set_mode(struct connector *c)
 			continue;
 		}
 
+		fprintf(stdout, "CRTS(%u):",c->crtc);
 		dump_mode(&c->mode);
 		if (drmModeSetCrtc(fd, c->crtc, fb_id, 0, 0,
 				   &c->id, 1, &c->mode)) {
@@ -955,6 +959,12 @@ set_mode(struct connector *c)
 
 		if (sleep_between_modes && test_all_modes)
 			sleep(sleep_between_modes);
+
+	}
+
+	if(!test_preferred_mode){
+		drmModeRmFB(fd,fb_id);
+		drmModeSetCrtc(fd, c->crtc, fb_id, 0, 0,  &c->id, 1, 0);
 	}
 
 	drmModeFreeEncoder(c->encoder);
Signature · 1 line
1.7.5.1
author
#1 lore raw

Daniel,

Need your review for testdisplay patch.

Http://lists.freedesktop.org/archives/intel-gfx/2011-December/013771.html

Thanks
--Yi,Sun

Quoted 56 lines

-----Original Message-----
From: Sun, Yi
Sent: Thursday, December 01, 2011 6:57 PM
To: [email protected]
Cc: [email protected]; Jin, Gordon; Sun, Yi
Subject: [PATCH] tests/testdisplay.c: make the 3th pipe finish all the mode setting.

If test all modes rather than preferred mode, remove framebuffer and set CRTC to zero after each connector mode setting.

---
 tests/testdisplay.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)
tests/testdisplay.c +11 -2
index 3c9741c..7e25296 100644
@@ -373,7 +373,10 @@ static void connector_find_preferred_mode(struct
 connector *c)
 	}
 	c->crtc = resources->crtcs[i];
 	c->pipe = i;
-	resources->crtcs[i] = 0;
+
+	if(test_preferred_mode)
+		resources->crtcs[i] = 0;
+
 	c->connector = connector;
 }
@@ -941,6 +944,7 @@ set_mode(struct connector *c)
 			continue;
 		}
 
+		fprintf(stdout, "CRTS(%u):",c->crtc);
 		dump_mode(&c->mode);
 		if (drmModeSetCrtc(fd, c->crtc, fb_id, 0, 0,
 				   &c->id, 1, &c->mode)) {
@@ -955,6 +959,12 @@ set_mode(struct connector *c)
 
 		if (sleep_between_modes && test_all_modes)
 			sleep(sleep_between_modes);
+
+	}
+
+	if(!test_preferred_mode){
+		drmModeRmFB(fd,fb_id);
+		drmModeSetCrtc(fd, c->crtc, fb_id, 0, 0,  &c->id, 1, 0);
 	}
 
 	drmModeFreeEncoder(c->encoder);
--

1.7.5.1

Reviewed-by on v1 1/1
#2 lore raw
In reply to Yi Sun
Quoted 5 lines · Yi Sun

If test all modes rather than preferred mode, remove framebuffer and set CRTC to zero after each connector mode setting.

I forgot to comment on this before, but better late than never.

Signature · 2 lines
Eugeni Dodonov
<http://eugeni.dodonov.net/>

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx