Skip to contentSkip to conversation

sound/soc/lapis: add machine driver v3 updated

PATCH In review Tomoya MORINAGA 2 participants 4 messages Dec 9, 2011 – Dec 12, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 sound/soc/lapis: add machine driver v3 updated

---
V3 Update Mark's comments
- Delete i2c_board_info data structure.
- Delete i2c_new_device/i2c_put_adapter.
- Delete .startup method.
- Add error processing for failure of snd_soc_unregister_card.
- Add MODULE_ALIAS
- Change platform_driver name
- Set to .dai_fmt of snd_soc_dai_link not use snd_soc_dai_set_fmt

---
 sound/soc/Kconfig                   |    1 +
 sound/soc/Makefile                  |    1 +
 sound/soc/lapis/Kconfig             |    5 +
 sound/soc/lapis/Makefile            |    5 +
 sound/soc/lapis/ml7213ioh-machine.c |  158 +++++++++++++++++++++++++++++++++++
 5 files changed, 170 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/lapis/Kconfig
 create mode 100644 sound/soc/lapis/Makefile
 create mode 100644 sound/soc/lapis/ml7213ioh-machine.c
sound/soc/Kconfig +1 -0
index 35e662d..63f8582 100644
@@ -34,6 +34,7 @@ source "sound/soc/ep93xx/Kconfig"
 source "sound/soc/fsl/Kconfig"
 source "sound/soc/imx/Kconfig"
 source "sound/soc/jz4740/Kconfig"
+source "sound/soc/lapis/Kconfig"
 source "sound/soc/nuc900/Kconfig"
 source "sound/soc/omap/Kconfig"
 source "sound/soc/kirkwood/Kconfig"
sound/soc/Makefile +1 -0
index 9ea8ac8..002951f 100644
@@ -11,6 +11,7 @@ obj-$(CONFIG_SND_SOC)	+= ep93xx/
 obj-$(CONFIG_SND_SOC)	+= fsl/
 obj-$(CONFIG_SND_SOC)   += imx/
 obj-$(CONFIG_SND_SOC)	+= jz4740/
+obj-$(CONFIG_SND_SOC)   += lapis/
 obj-$(CONFIG_SND_SOC)	+= mid-x86/
 obj-$(CONFIG_SND_SOC)	+= mxs/
 obj-$(CONFIG_SND_SOC)	+= nuc900/
sound/soc/lapis/Kconfig new file +5 -0
new file mode 100644
index 0000000..f6c2fe5
@@ -0,0 +1,5 @@
+config SND_SOC_ML7213_MACHINE
+	tristate "ML7213 IOH ASoC machine driver"
+	select SND_SOC_ML7213_PLATFORM
+	help
+	  This is ASoC machine driver for ML7213 IOH
sound/soc/lapis/Makefile new file +5 -0
new file mode 100644
index 0000000..3560bd7
@@ -0,0 +1,5 @@
+# Platform
+snd-soc-ml7213-machine-objs := ml7213ioh-machine.o
+
+obj-$(CONFIG_SND_SOC_ML7213_PLATFORM) += snd-soc-ml7213-machine.o
+
sound/soc/lapis/ml7213ioh-machine.c new file +158 -0

158 lines not on this page · raw message

Signature · 1 line
1.7.4.4
#1 lore raw

sound/soc/lapis/ml7213ioh-machine.c line 51

Quoted 4 lines · Tomoya MORINAGA
sound/soc/lapis/ml7213ioh-machine.c new file +4 -0
+	snd_soc_dapm_new_controls(dapm, ml7213_dapm_widgets,
+				  ARRAY_SIZE(ml7213_dapm_widgets));
+
+	snd_soc_dapm_add_routes(dapm, ml7213_routes, ARRAY_SIZE(ml7213_routes));

You should also use table based init for these (see the card struct). Otherwise this looks good, though obviously there's a dependency on the CPU drivers.

#2 lore raw

2011/12/9 Mark Brown <[email protected]>:

Quoted 3 lines · Tomoya MORINAGA

Otherwise this looks good, though obviously there's a dependency on the CPU drivers.

I just started developing plat form driver.
According to platform.txt, soc/pxa/pxa2xx-pcm.c is shown as example. Can I believes this description ?
If the driver is not modern, let me know the modern platform driver.

Thanks in advance.

tomoya

#3 lore raw
Quoted 4 lines · Tomoya MORINAGA

I just started developing plat form driver.
According to platform.txt, soc/pxa/pxa2xx-pcm.c is shown as example. Can I believes this description ?
If the driver is not modern, let me know the modern platform driver.

It's pretty old but there's not been many updates in the world of platform drivers. In general if you're looking for modern drivers git log is your friend - look for things that are being actively worked on.