Skip to contentSkip to conversation

gnome-panel : Fix format of LICENSE field.

PATCH In review Philip Balister 2 participants 6 messages Dec 12, 2011 – Dec 13, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 gnome-panel : Fix format of LICENSE field.

---
 .../gnome-panel/gnome-panel_2.32.1.bb              |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta-gnome/recipes-gnome/gnome-panel/gnome-panel_2.32.1.bb +1 -1
index 4a07378..78b874d 100644
@@ -1,5 +1,5 @@
 DESCRIPTION = "GNOME panel"
-LICENSE = "GPLv2 && LGPLv2 && GFDLv1.1"
+LICENSE = "GPLv2 & LGPLv2 & GFDLv1.1"
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
                     file://COPYING-DOCS;md5=c9211dab3ae61e580f48432020784324 \
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 2/2 gvfs : Fix build failure due to introduction of host includes.

Tested with Angstrom on usrp-e1xx.

---
 meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb +1 -0
index 5a230eb..fd4a089 100644
@@ -14,6 +14,7 @@ SRC_URI[archive.md5sum] = "402f94b187b197b403d25c85caeb9562"
 SRC_URI[archive.sha256sum] = "0895ac8f6d416e1b15433b6b6b68eb119c6e8b04fdb66db665d684355ef89345"
 
 EXTRA_OECONF = "--disable-samba \
+                --disable-archive \
                 --with-samba-includes=${STAGING_INCDIR} \
                 --with-samba-libs=${STAGING_LIBDIR} \
                 --with-archive-includes=${STAGING_INCDIR} \
Signature · 1 line
1.7.3.4
#2 lore raw

Re: [PATCH 2/2] gvfs : Fix build failure due to introduction of host includes.

Quoted 14 lines · Philip Balister

Tested with Angstrom on usrp-e1xx.

---
 meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb +0 -0
index 5a230eb..fd4a089 100644
@@ -14,6 +14,7 @@ SRC_URI[archive.md5sum] = "402f94b187b197b403d25c85caeb9562"

 SRC_URI[archive.sha256sum] = "0895ac8f6d416e1b15433b6b6b68eb119c6e8b04fdb66db665d684355ef89345"

Quoted 2 lines

 EXTRA_OECONF = "--disable-samba \
+                --disable-archive \

You are disabling archive backend explicitly. It might be that someone is using it successfully. Why does it not work ?

Quoted 3 lines

                --with-samba-includes=${STAGING_INCDIR} \
                --with-samba-libs=${STAGING_LIBDIR} \
                --with-archive-includes=${STAGING_INCDIR} \

the above option is not needed when you are disabling libarchive anyway

Quoted 8 lines

--
1.7.3.4

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#3 lore raw

Re: [PATCH 2/2] gvfs : Fix build failure due to introduction of host includes.

Quoted 15 lines · Khem Raj
Quoted 14 lines · Philip Balister

Tested with Angstrom on usrp-e1xx.

---
 meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb +0 -0
index 5a230eb..fd4a089 100644
@@ -14,6 +14,7 @@ SRC_URI[archive.md5sum] = "402f94b187b197b403d25c85caeb9562"
 SRC_URI[archive.sha256sum] = "0895ac8f6d416e1b15433b6b6b68eb119c6e8b04fdb66db665d684355ef89345"
 
Quoted 5 lines

meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb SRC_URI[archive.md5sum] = "402f94b187b197b403d25c85caeb9562" · line 17

Quoted 2 lines
meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb +1 -0
 EXTRA_OECONF = "--disable-samba \
+                --disable-archive \

You are disabling archive backend explicitly. It might be that someone is using it successfully. Why does it not work ?

With it enabled, the build fails because it looks at host includes. Long term someone will likely fix this, be in the short term, I need this to work so I can move forward with oe-core based stuff.

Philip

Quoted 20 lines

meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb SRC_URI[archive.md5sum] = "402f94b187b197b403d25c85caeb9562" · line 20

Quoted 4 lines
meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb +0 -0
                --with-samba-includes=${STAGING_INCDIR} \
                --with-samba-libs=${STAGING_LIBDIR} \
                --with-archive-includes=${STAGING_INCDIR} \

the above option is not needed when you are disabling libarchive anyway

Quoted 8 lines

--
1.7.3.4

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#4 lore raw

Re: [PATCH 2/2] gvfs : Fix build failure due to introduction of host includes.

Quoted 10 lines · Philip Balister
Quoted 6 lines
Quoted 3 lines

 EXTRA_OECONF = "--disable-samba \
+                --disable-archive \

You are disabling archive backend explicitly. It might be that someone is using it successfully. Why does it not work ?

With it enabled, the build fails because it looks at host includes. Long term someone will likely fix this, be in the short term, I need this to work so I can move forward with oe-core based stuff.

OK. I see that we do not list libarchive in DEPENDS if we did then it would build I suppose. Can you try that please ?

so I think at present what you get is that if libarchive is built and staged before you build
gvfs then you get the support compiled in if not then you don't. So your patch at least makes
it consistent by disabling it.

Problem only happens if you have libarchive-dev installed on your build host which I think
you do have and hence you see the problem.

I have no strong feeling on enabling or disabling it but I would prefer consistency

-Khem

#5 lore raw

Re: [PATCH 2/2] gvfs : Fix build failure due to introduction of host includes.

Quoted 12 lines · Khem Raj
Quoted 10 lines · Philip Balister
Quoted 6 lines
Quoted 3 lines

EXTRA_OECONF = "--disable-samba \
+ --disable-archive \

You are disabling archive backend explicitly. It might be that someone is using it successfully. Why does it not work ?

With it enabled, the build fails because it looks at host includes. Long term someone will likely fix this, be in the short term, I need this to work so I can move forward with oe-core based stuff.

Quoted 8 lines

OK. I see that we do not list libarchive in DEPENDS if we did then it would build I suppose. Can you try that please ?

so I think at present what you get is that if libarchive is built and staged before you build
gvfs then you get the support compiled in if not then you don't. So your patch at least makes
it consistent by disabling it.

Still fails if you DEPEND on libarchive.

Philip

Quoted 14 lines

Problem only happens if you have libarchive-dev installed on your build host which I think
you do have and hence you see the problem.

I have no strong feeling on enabling or disabling it but I would prefer consistency

-Khem

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel