ASoC: Rename ALC5632 MICBIAS to common name convention.
PATCH 1/1 ASoC: Rename ALC5632 MICBIAS to common name convention.
--- sound/soc/codecs/alc5632.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/alc5632.c +2 -2
@@ -379,8 +379,8 @@ SND_SOC_DAPM_PGA("MIC1 PGA", ALC5632_PWR_MANAG_ADD3, 3, 0, NULL, 0),SND_SOC_DAPM_PGA ("MIC2 PGA" ,ALC5632_PWR_MANAG_ADD3 ,2 ,0 ,NULL ,0 ),SND_SOC_DAPM_PGA ("MIC1 Pre Amp" ,ALC5632_PWR_MANAG_ADD3 ,1 ,0 ,NULL ,0 ),SND_SOC_DAPM_PGA ("MIC2 Pre Amp" ,ALC5632_PWR_MANAG_ADD3 ,0 ,0 ,NULL ,0 ), -SND_SOC_DAPM_SUPPLY ("Mic Bias1" ,ALC5632_PWR_MANAG_ADD1 ,3 ,0 ,NULL ,0 ), -SND_SOC_DAPM_SUPPLY ("Mic Bias2" ,ALC5632_PWR_MANAG_ADD1 ,2 ,0 ,NULL ,0 ), +SND_SOC_DAPM_SUPPLY ("MICBIAS1" ,ALC5632_PWR_MANAG_ADD1 ,3 ,0 ,NULL ,0 ), +SND_SOC_DAPM_SUPPLY ("MICBIAS2" ,ALC5632_PWR_MANAG_ADD1 ,2 ,0 ,NULL ,0 ),SND_SOC_DAPM_PGA_E ("D Amp" ,ALC5632_PWR_MANAG_ADD2 ,14 ,0 ,NULL ,0 , amp_mixer_event, SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
Signature · 1 line
1.7.3.4
sound/soc/codecs/alc5632.c SND_SOC_DAPM_PGA("MIC1 PGA", ALC5632_PWR_MANAG_ADD3, 3, 0, NULL, 0), · line 383
Quoted 4 lines · Leon Romanovsky
sound/soc/codecs/alc5632.c +2
-2-SND_SOC_DAPM_SUPPLY ("Mic Bias1" ,ALC5632_PWR_MANAG_ADD1 ,3 ,0 ,NULL ,0 ), -SND_SOC_DAPM_SUPPLY("Mic Bias2", ALC5632_PWR_MANAG_ADD1, 2, 0, NULL, 0), +SND_SOC_DAPM_SUPPLY ("MICBIAS1" ,ALC5632_PWR_MANAG_ADD1 ,3 ,0 ,NULL ,0 ), +SND_SOC_DAPM_SUPPLY("MICBIAS2", ALC5632_PWR_MANAG_ADD1, 2, 0, NULL, 0),
What does the datasheet say the pins are called?
Quoted 9 lines · Mark Brown
sound/soc/codecs/alc5632.c SND_SOC_DAPM_PGA("MIC1 PGA", ALC5632_PWR_MANAG_ADD3, 3, 0, NULL, 0), · line 383
Quoted 4 lines · Leon Romanovsky
sound/soc/codecs/alc5632.c +2
-2-SND_SOC_DAPM_SUPPLY ("Mic Bias1" ,ALC5632_PWR_MANAG_ADD1 ,3 ,0 ,NULL ,0 ), -SND_SOC_DAPM_SUPPLY("Mic Bias2", ALC5632_PWR_MANAG_ADD1, 2, 0, NULL, 0), +SND_SOC_DAPM_SUPPLY ("MICBIAS1" ,ALC5632_PWR_MANAG_ADD1 ,3 ,0 ,NULL ,0 ), +SND_SOC_DAPM_SUPPLY("MICBIAS2", ALC5632_PWR_MANAG_ADD1, 2, 0, NULL, 0),What does the datasheet say the pins are called?
MICBIAS
http://ac100.wikispaces.com/file/view/alc5632_micbiases.PNG/285333934/alc5632_micbiases.PNG
--
Leon Romanovsky | Independent Linux Consultant
www.leon.nu | [email protected]
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 8 lines · Leon Romanovsky
On Tue, Dec 13, 2011 at 03:36, Mark Brown
Quoted 4 lines
sound/soc/codecs/alc5632.c SND_SOC_DAPM_PGA("MIC1 PGA", ALC5632_PWR_MANAG_ADD3, 3, 0, NULL, 0), · line 383
Quoted 2 lines
sound/soc/codecs/alc5632.c +2
-0+SND_SOC_DAPM_SUPPLY ("MICBIAS1" ,ALC5632_PWR_MANAG_ADD1 ,3 ,0 ,NULL ,0 ), +SND_SOC_DAPM_SUPPLY("MICBIAS2", ALC5632_PWR_MANAG_ADD1, 2, 0, NULL, 0),What does the datasheet say the pins are called?
MICBIAS
http://ac100.wikispaces.com/file/view/alc5632_micbiases.PNG/285333934/alc5632_micbiases.PNG
OK - you should've said this in your changelog, that's what the convention is, to use the pin names.