Skip to contentSkip to conversation

staging: wlan-ng: prism: coding style fixes, removed space-indentations

PATCH Dan Luedtke 1 participant 1 message Dec 13, 2011

lore
Share & tools
lore
#0 lore raw

Hello,

Quoted 3 lines · Dan Carpenter

Everyone's first patch is rejected, so don't feel bad. :) Btw put these kind of comments which you don't want in the permanent git log under the --- dashes. git am removes that information.

Thanks for the feedback! I'm glad I managed git send-email without breaking up something, so no offense taken that the patch got rejected.

Quoted 3 lines

It looks like you've tried to make everything aligned with the right hand side of the screen. I think that's the first time I've seen someone do that. I don't think it's normal.

Thank god! I am working on a kmodule, and the code looks awful that way. I think I have to dig deeper into CodingStyle.txt

Quoted 5 lines
Quoted 2 lines

-----------------------------------------------------------------*/ +*----------------------------------------------------------------*/

There is a normal kernel comment style described in Chapter 8 of Documentation/CodingStyle.

Now I am confused, as I understand multi-line comments should start every line but the first with a *.
Anyway, one should commit code before bothering about comments, so I silence myself here.

Quoted 1 line

Documentation/kernel-doc-nano-HOWTO.txt

Printed.

Again, thanks for the feedback! Will work on that and come back later when I found something in the kernel to work on or when my module leaves design-phase.

regards,
Dan

Signature · 2 lines
Dan Luedtke
http://www.danrl.de