TV Out patches to make our mode list be according to TV timing standards
Subsystems (2)
cover TV Out patches to make our mode list be according to TV timing standards
Hi all,
The following patches makes the TV Out mode list be according to timing table specification from TV standards.
The first one of the list fixes the https://bugs.freedesktop.org/show_bug.cgi?id=23899
When I start looking at this bug I was so focused on the pixel clock that I didn't noticed refresh rates were half of the specification for most of the modes. After the fix some modes got obsoletes and others were removed simply because they weren't on the TV Out standard timing table. From this same table I got the 1080p specification and added to our list there.
Cheers,
Rodrigo.
Rodrigo Vivi (3):
drm/i915: Fix TV Out refresh rate.
drm/i915: Removing TV Out modes.
drm/i915: Adding 1080p modes to our TV Out mode list.
drivers/gpu/drm/i915/intel_tv.c | 176 ++++++++++++++------------------------- 1 files changed, 63 insertions(+), 113 deletions(-)
Signature · 1 line
1.7.7.4
PATCH 1/3 drm/i915: Fix TV Out refresh rate.
TV Out refresh rate was half of the specification for almost all modes. Due to this reason pixel clock was so low for some modes causing flickering screen.
--- drivers/gpu/drm/i915/intel_tv.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/intel_tv.c +8 -8
@@ -417,7 +417,7 @@ static const struct tv_mode tv_modes[] = { { .name = "NTSC-M", .clock = 108000, - .refresh = 29970, + .refresh = 59940, .oversample = TV_OVERSAMPLE_8X, .component_only = 0,/* 525 Lines, 60 Fields, 15.734KHz line, Sub-Carrier 3.580MHz */
@@ -460,7 +460,7 @@ static const struct tv_mode tv_modes[] = { { .name = "NTSC-443", .clock = 108000, - .refresh = 29970, + .refresh = 59940, .oversample = TV_OVERSAMPLE_8X, .component_only = 0,/* 525 Lines, 60 Fields, 15.734KHz line, Sub-Carrier 4.43MHz */
@@ -502,7 +502,7 @@ static const struct tv_mode tv_modes[] = { { .name = "NTSC-J", .clock = 108000, - .refresh = 29970, + .refresh = 59940, .oversample = TV_OVERSAMPLE_8X, .component_only = 0,
@@ -545,7 +545,7 @@ static const struct tv_mode tv_modes[] = { { .name = "PAL-M", .clock = 108000, - .refresh = 29970, + .refresh = 59940, .oversample = TV_OVERSAMPLE_8X, .component_only = 0,
@@ -589,7 +589,7 @@ static const struct tv_mode tv_modes[] = {/* 625 Lines, 50 Fields, 15.625KHz line, Sub-Carrier 4.434MHz */ .name = "PAL-N", .clock = 108000, - .refresh = 25000, + .refresh = 50000, .oversample = TV_OVERSAMPLE_8X, .component_only = 0,
@@ -634,7 +634,7 @@ static const struct tv_mode tv_modes[] = {/* 625 Lines, 50 Fields, 15.625KHz line, Sub-Carrier 4.434MHz */ .name = "PAL", .clock = 108000, - .refresh = 25000, + .refresh = 50000, .oversample = TV_OVERSAMPLE_8X, .component_only = 0,
@@ -821,7 +821,7 @@ static const struct tv_mode tv_modes[] = { { .name = "1080i@50Hz", .clock = 148800, - .refresh = 25000, + .refresh = 50000, .oversample = TV_OVERSAMPLE_2X, .component_only = 1,
@@ -847,7 +847,7 @@ static const struct tv_mode tv_modes[] = { { .name = "1080i@60Hz", .clock = 148800, - .refresh = 30000, + .refresh = 60000, .oversample = TV_OVERSAMPLE_2X, .component_only = 1,
Signature · 1 line
1.7.7.4
Re: [PATCH 1/3] drm/i915: Fix TV Out refresh rate.
Quoted 8 lines · On Wed, 14 Dec 2011 21:10:06 -0200 Rodrigo Vivi <[email protected]> wrote:
TV Out refresh rate was half of the specification for almost all modes. Due to this reason pixel clock was so low for some modes causing flickering screen.
Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_tv.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-)
Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/3] drm/i915: Fix TV Out refresh rate.
In reply to Rodrigo ViviQuoted 5 lines · Rodrigo Vivi
TV Out refresh rate was half of the specification for almost all modes. Due to this reason pixel clock was so low for some modes causing flickering screen.
Signed-off-by Rodrigo Vivi <[email protected]>
And
Quoted 6 lines
These modes are no longer needed or are not according to TV timing standards.
Intel PRM Vol 3 - Display Registers Updated - Section 5 TV-Out Programming / 5.2.1 Television Standards / 5.2.1.1 Timing tables
Signed-off-by Rodrigo Vivi <[email protected]>
I've got these two queued on my machine. Once drm-next is merged to master, drm-intel-fixes will be fast-forwarded to that point and these fixes rebased on top of that.
There's still the 1080p modes which Chris has asked for an updated changelog and a comment in the source for.
Signature · 1 line
[email protected]
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/3] drm/i915: Fix TV Out refresh rate.
I think we should go ahead and integrate the first and second patches and skip the 1080 (third) for now.
We are internally discussing when and if that document will be released.
Quoted 25 lines · Keith Packard
Quoted 5 lines · Rodrigo Vivi
TV Out refresh rate was half of the specification for almost all modes. Due to this reason pixel clock was so low for some modes causing flickering screen.
Signed-off-by Rodrigo Vivi <[email protected]>And
Quoted 6 lines
These modes are no longer needed or are not according to TV timing standards.
Intel PRM Vol 3 - Display Registers Updated - Section 5 TV-Out Programming / 5.2.1 Television Standards / 5.2.1.1 Timing tables
Signed-off-by Rodrigo Vivi <[email protected]>I've got these two queued on my machine. Once drm-next is merged to master, drm-intel-fixes will be fast-forwarded to that point and these fixes rebased on top of that.
There's still the 1080p modes which Chris has asked for an updated changelog and a comment in the source for.
Signature · 3 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br GPG: 0x905BE242 @ wwwkeys.pgp.net
PATCH 2/3 drm/i915: Removing TV Out modes.
In reply to Rodrigo ViviThese modes are no longer needed or are not according to TV timing standards.
--- drivers/gpu/drm/i915/intel_tv.c | 122 --------------------------------------- 1 files changed, 0 insertions(+), 122 deletions(-)
drivers/gpu/drm/i915/intel_tv.c +0 -122
@@ -674,78 +674,6 @@ static const struct tv_mode tv_modes[] = { .filter_table = filter_table, }, { - .name = "[email protected]", - .clock = 107520, - .refresh = 59940, - .oversample = TV_OVERSAMPLE_4X, - .component_only = 1, - - .hsync_end = 64, .hblank_end = 122, - .hblank_start = 842, .htotal = 857, - - .progressive = true, .trilevel_sync = false, - - .vsync_start_f1 = 12, .vsync_start_f2 = 12, - .vsync_len = 12, - - .veq_ena = false, - - .vi_end_f1 = 44, .vi_end_f2 = 44, - .nbr_end = 479, - - .burst_ena = false, - - .filter_table = filter_table, - }, - { - .name = "480p@60Hz", - .clock = 107520, - .refresh = 60000, - .oversample = TV_OVERSAMPLE_4X, - .component_only = 1, - - .hsync_end = 64, .hblank_end = 122, - .hblank_start = 842, .htotal = 856, - - .progressive = true, .trilevel_sync = false, - - .vsync_start_f1 = 12, .vsync_start_f2 = 12, - .vsync_len = 12, - - .veq_ena = false, - - .vi_end_f1 = 44, .vi_end_f2 = 44, - .nbr_end = 479, - - .burst_ena = false, - - .filter_table = filter_table, - }, - { - .name = "576p", - .clock = 107520, - .refresh = 50000, - .oversample = TV_OVERSAMPLE_4X, - .component_only = 1, - - .hsync_end = 64, .hblank_end = 139, - .hblank_start = 859, .htotal = 863, - - .progressive = true, .trilevel_sync = false, - - .vsync_start_f1 = 10, .vsync_start_f2 = 10, - .vsync_len = 10, - - .veq_ena = false, - - .vi_end_f1 = 48, .vi_end_f2 = 48, - .nbr_end = 575, - - .burst_ena = false, - - .filter_table = filter_table, - }, - { .name = "720p@60Hz", .clock = 148800, .refresh = 60000,
@@ -770,30 +698,6 @@ static const struct tv_mode tv_modes[] = { .filter_table = filter_table, }, { - .name = "[email protected]", - .clock = 148800, - .refresh = 59940, - .oversample = TV_OVERSAMPLE_2X, - .component_only = 1, - - .hsync_end = 80, .hblank_end = 300, - .hblank_start = 1580, .htotal = 1651, - - .progressive = true, .trilevel_sync = true, - - .vsync_start_f1 = 10, .vsync_start_f2 = 10, - .vsync_len = 10, - - .veq_ena = false, - - .vi_end_f1 = 29, .vi_end_f2 = 29, - .nbr_end = 719, - - .burst_ena = false, - - .filter_table = filter_table, - }, - { .name = "720p@50Hz", .clock = 148800, .refresh = 50000,
@@ -870,32 +774,6 @@ static const struct tv_mode tv_modes[] = { .filter_table = filter_table, }, - { - .name = "[email protected]", - .clock = 148800, - .refresh = 29970, - .oversample = TV_OVERSAMPLE_2X, - .component_only = 1, - - .hsync_end = 88, .hblank_end = 235, - .hblank_start = 2155, .htotal = 2201, - - .progressive = false, .trilevel_sync = true, - - .vsync_start_f1 = 4, .vsync_start_f2 = 5, - .vsync_len = 10, - - .veq_ena = true, .veq_start_f1 = 4, - .veq_start_f2 = 4, .veq_len = 10, - - - .vi_end_f1 = 21, .vi_end_f2 = 22, - .nbr_end = 539, - - .burst_ena = false, - - .filter_table = filter_table, - }, };static struct intel_tv *enc_to_intel_tv (struct drm_encoder *encoder)
Signature · 1 line
1.7.7.4
PATCH 1/2 drm/i915: Removing TV Out modes.
These modes are no longer needed or are not according to TV timing standards.
Intel PRM Vol 3 - Display Registers Updated - Section 5 TV-Out Programming / 5.2.1 Television Standards / 5.2.1.1 Timing tables
--- drivers/gpu/drm/i915/intel_tv.c | 122 --------------------------------------- 1 files changed, 0 insertions(+), 122 deletions(-)
drivers/gpu/drm/i915/intel_tv.c +0 -122
@@ -674,78 +674,6 @@ static const struct tv_mode tv_modes[] = { .filter_table = filter_table, }, { - .name = "[email protected]", - .clock = 107520, - .refresh = 59940, - .oversample = TV_OVERSAMPLE_4X, - .component_only = 1, - - .hsync_end = 64, .hblank_end = 122, - .hblank_start = 842, .htotal = 857, - - .progressive = true, .trilevel_sync = false, - - .vsync_start_f1 = 12, .vsync_start_f2 = 12, - .vsync_len = 12, - - .veq_ena = false, - - .vi_end_f1 = 44, .vi_end_f2 = 44, - .nbr_end = 479, - - .burst_ena = false, - - .filter_table = filter_table, - }, - { - .name = "480p@60Hz", - .clock = 107520, - .refresh = 60000, - .oversample = TV_OVERSAMPLE_4X, - .component_only = 1, - - .hsync_end = 64, .hblank_end = 122, - .hblank_start = 842, .htotal = 856, - - .progressive = true, .trilevel_sync = false, - - .vsync_start_f1 = 12, .vsync_start_f2 = 12, - .vsync_len = 12, - - .veq_ena = false, - - .vi_end_f1 = 44, .vi_end_f2 = 44, - .nbr_end = 479, - - .burst_ena = false, - - .filter_table = filter_table, - }, - { - .name = "576p", - .clock = 107520, - .refresh = 50000, - .oversample = TV_OVERSAMPLE_4X, - .component_only = 1, - - .hsync_end = 64, .hblank_end = 139, - .hblank_start = 859, .htotal = 863, - - .progressive = true, .trilevel_sync = false, - - .vsync_start_f1 = 10, .vsync_start_f2 = 10, - .vsync_len = 10, - - .veq_ena = false, - - .vi_end_f1 = 48, .vi_end_f2 = 48, - .nbr_end = 575, - - .burst_ena = false, - - .filter_table = filter_table, - }, - { .name = "720p@60Hz", .clock = 148800, .refresh = 60000,
@@ -770,30 +698,6 @@ static const struct tv_mode tv_modes[] = { .filter_table = filter_table, }, { - .name = "[email protected]", - .clock = 148800, - .refresh = 59940, - .oversample = TV_OVERSAMPLE_2X, - .component_only = 1, - - .hsync_end = 80, .hblank_end = 300, - .hblank_start = 1580, .htotal = 1651, - - .progressive = true, .trilevel_sync = true, - - .vsync_start_f1 = 10, .vsync_start_f2 = 10, - .vsync_len = 10, - - .veq_ena = false, - - .vi_end_f1 = 29, .vi_end_f2 = 29, - .nbr_end = 719, - - .burst_ena = false, - - .filter_table = filter_table, - }, - { .name = "720p@50Hz", .clock = 148800, .refresh = 50000,
@@ -870,32 +774,6 @@ static const struct tv_mode tv_modes[] = { .filter_table = filter_table, }, - { - .name = "[email protected]", - .clock = 148800, - .refresh = 29970, - .oversample = TV_OVERSAMPLE_2X, - .component_only = 1, - - .hsync_end = 88, .hblank_end = 235, - .hblank_start = 2155, .htotal = 2201, - - .progressive = false, .trilevel_sync = true, - - .vsync_start_f1 = 4, .vsync_start_f2 = 5, - .vsync_len = 10, - - .veq_ena = true, .veq_start_f1 = 4, - .veq_start_f2 = 4, .veq_len = 10, - - - .vi_end_f1 = 21, .vi_end_f2 = 22, - .nbr_end = 539, - - .burst_ena = false, - - .filter_table = filter_table, - }, };static struct intel_tv *enc_to_intel_tv (struct drm_encoder *encoder)
Signature · 1 line
1.7.7.4
Re: [PATCH 2/3] drm/i915: Removing TV Out modes.
In reply to Rodrigo ViviQuoted 6 lines · On Wed, 14 Dec 2011 21:10:07 -0200 Rodrigo Vivi <[email protected]> wrote:
These modes are no longer needed or are not according to TV timing standards.
Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_tv.c | 122 --------------------------------------- 1 files changed, 0 insertions(+), 122 deletions(-)
Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/3 drm/i915: Adding 1080p modes to our TV Out mode list.
In reply to Rodrigo ViviAccording to TV Out timing standards, supported 1080p modes were missing.
--- drivers/gpu/drm/i915/intel_tv.c | 72 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 72 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/intel_tv.c +72 -0
@@ -774,6 +774,78 @@ static const struct tv_mode tv_modes[] = { .filter_table = filter_table, }, + { + .name = "1080p@30Hz", + .clock = 148800, + .refresh = 30000, + .oversample = TV_OVERSAMPLE_2X, + .component_only = 1, + + .hsync_end = 88, .hblank_end = 235, + .hblank_start = 2155, .htotal = 2199, + + .progressive = true, .trilevel_sync = true, + + .vsync_start_f1 = 8, .vsync_start_f2 = 8, + .vsync_len = 10, + + .veq_ena = false, + + .vi_end_f1 = 44, .vi_end_f2 = 44, + .nbr_end = 1079, + + .burst_ena = false, + + .filter_table = filter_table, + }, + { + .name = "1080p@50Hz", + .clock = 148800, + .refresh = 50000, + .oversample = TV_OVERSAMPLE_2X, + .component_only = 1, + + .hsync_end = 88, .hblank_end = 235, + .hblank_start = 2155, .htotal = 2639, + + .progressive = true, .trilevel_sync = true, + + .vsync_start_f1 = 8, .vsync_start_f2 = 8, + .vsync_len = 10, + + .veq_ena = false, + + .vi_end_f1 = 44, .vi_end_f2 = 44, + .nbr_end = 1079, + + .burst_ena = false, + + .filter_table = filter_table, + }, + { + .name = "1080p@60Hz", + .clock = 148800, + .refresh = 60000, + .oversample = TV_OVERSAMPLE_2X, + .component_only = 1, + + .hsync_end = 88, .hblank_end = 235, + .hblank_start = 2155, .htotal = 2199, + + .progressive = true, .trilevel_sync = true, + + .vsync_start_f1 = 8, .vsync_start_f2 = 8, + .vsync_len = 10, + + .veq_ena = false, + + .vi_end_f1 = 44, .vi_end_f2 = 44, + .nbr_end = 1079, + + .burst_ena = false, + + .filter_table = filter_table, + }, };static struct intel_tv *enc_to_intel_tv (struct drm_encoder *encoder)
Signature · 1 line
1.7.7.4
Re: [PATCH 3/3] drm/i915: Adding 1080p modes to our TV Out mode list.
Quoted 1 line · Rodrigo Vivi
According to TV Out timing standards, supported 1080p modes were missing.
Can you both here in the changelog and in comments a document reference so that we can easily find the right table again in future? -Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Re: [PATCH 3/3] drm/i915: Adding 1080p modes to our TV Out mode list.
For other patches in this serie the table can be found at our PRM
http://intellinuxgraphics.org/VOL_3_display_registers_updated.pdf
Section 5.2 TV Out Programming / 5.2.1 Television Standards
Quoted 9 lines · Chris Wilson
Quoted 1 line · Rodrigo Vivi
According to TV Out timing standards, supported 1080p modes were missing.
Can you both here in the changelog and in comments a document reference so that we can easily find the right table again in future? -Chris
--
Chris Wilson, Intel Open Source Technology Centre
Signature · 3 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br GPG: 0x905BE242 @ wwwkeys.pgp.net
Re: [PATCH 3/3] drm/i915: Adding 1080p modes to our TV Out mode list.
sorry... last email was unfinished and it was sent by mistake.. full version:
For other patches in this serie the table can be found at our PRM
http://intellinuxgraphics.org/VOL_3_display_registers_updated.pdf
Section 5.2 TV Out Programming / 5.2.1 Television Standards / 5.2.1.1 Timing Table
However the 1080p was added on the new version witch is internal for now. I'm going to change the commit comment but I'm not happy with the comment such as:
"Adding 1080p supported modes according to new PRM version which is internal for now."
Because in a near future this document will be public and the comment will be there forever.
Do you have any suggestion?
Thanks
Rodrigo
Quoted 22 lines · Rodrigo Vivi
For other patches in this serie the table can be found at our PRM
http://intellinuxgraphics.org/VOL_3_display_registers_updated.pdfSection 5.2 TV Out Programming / 5.2.1 Television Standards
Quoted 9 lines · Chris Wilson
Quoted 1 line · Rodrigo Vivi
According to TV Out timing standards, supported 1080p modes were missing.
Can you both here in the changelog and in comments a document reference so that we can easily find the right table again in future? -Chris
--
Chris Wilson, Intel Open Source Technology Centre--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
GPG:0x905BE242@ wwwkeys.pgp.net
Signature · 3 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br GPG: 0x905BE242 @ wwwkeys.pgp.net
Re: [PATCH 3/3] drm/i915: Adding 1080p modes to our TV Out mode list.
Quoted 12 lines · Rodrigo Vivi
sorry... last email was unfinished and it was sent by mistake.. full version:
For other patches in this serie the table can be found at our PRM
http://intellinuxgraphics.org/VOL_3_display_registers_updated.pdfSection 5.2 TV Out Programming / 5.2.1 Television Standards / 5.2.1.1 Timing Table
However the 1080p was added on the new version witch is internal for now. I'm going to change the commit comment but I'm not happy with the comment such as:
Quoted 5 lines
"Adding 1080p supported modes according to new PRM version which is internal for now."
Because in a near future this document will be public and the comment will be there forever.
The comment can be updated to match the public material once it becomes available (and more likely when someone finds something that needs changing). If someone finds a reference to an internal document, they are likely to ask us for it. At that point, we can double check whether the material is now public, answer their question for them (and see if we can improve the code so that the question becomes unncessary) or see if we can provide them with the document under NDA.
Without a reference at all, that dialogue will never happen and we run the risk of loosing the review. And more likely we will forget where to find the information and have to search all the specs afresh. I'll trade confusing a few people for saving time and preventing mistakes later. -Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
PATCH 2/2 drm/i915: Adding 1080p modes to our TV Out mode list.
In reply to Rodrigo ViviAdding 1080p supported modes according to new PRM version which is internal for now.
--- drivers/gpu/drm/i915/intel_tv.c | 72 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 72 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/intel_tv.c +72 -0
@@ -774,6 +774,78 @@ static const struct tv_mode tv_modes[] = { .filter_table = filter_table, }, + { + .name = "1080p@30Hz", + .clock = 148800, + .refresh = 30000, + .oversample = TV_OVERSAMPLE_2X, + .component_only = 1, + + .hsync_end = 88, .hblank_end = 235, + .hblank_start = 2155, .htotal = 2199, + + .progressive = true, .trilevel_sync = true, + + .vsync_start_f1 = 8, .vsync_start_f2 = 8, + .vsync_len = 10, + + .veq_ena = false, + + .vi_end_f1 = 44, .vi_end_f2 = 44, + .nbr_end = 1079, + + .burst_ena = false, + + .filter_table = filter_table, + }, + { + .name = "1080p@50Hz", + .clock = 148800, + .refresh = 50000, + .oversample = TV_OVERSAMPLE_2X, + .component_only = 1, + + .hsync_end = 88, .hblank_end = 235, + .hblank_start = 2155, .htotal = 2639, + + .progressive = true, .trilevel_sync = true, + + .vsync_start_f1 = 8, .vsync_start_f2 = 8, + .vsync_len = 10, + + .veq_ena = false, + + .vi_end_f1 = 44, .vi_end_f2 = 44, + .nbr_end = 1079, + + .burst_ena = false, + + .filter_table = filter_table, + }, + { + .name = "1080p@60Hz", + .clock = 148800, + .refresh = 60000, + .oversample = TV_OVERSAMPLE_2X, + .component_only = 1, + + .hsync_end = 88, .hblank_end = 235, + .hblank_start = 2155, .htotal = 2199, + + .progressive = true, .trilevel_sync = true, + + .vsync_start_f1 = 8, .vsync_start_f2 = 8, + .vsync_len = 10, + + .veq_ena = false, + + .vi_end_f1 = 44, .vi_end_f2 = 44, + .nbr_end = 1079, + + .burst_ena = false, + + .filter_table = filter_table, + }, };static struct intel_tv *enc_to_intel_tv (struct drm_encoder *encoder)
Signature · 1 line
1.7.7.4