Skip to contentSkip to conversation

binutils-cross-canadian: Allow ld-is-gold

PATCH Applied Derek Buitenhuis 4 participants 17 messages Jan 4, 2012 – Apr 30, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 binutils-cross-canadian: Allow ld-is-gold

In order to actually generate a toolchain (with bitbake meta-toolchain) that supports gold, binutils- cross-canadian also needs to be built this way.

---
 .../binutils/binutils-cross-canadian.inc           |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
meta/recipes-devtools/binutils/binutils-cross-canadian.inc +2 -1
index b1cee67..00648a6 100644
@@ -7,7 +7,8 @@ BPN = "binutils"
 DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/libc-nativesdk zlib-nativesdk gettext-nativesdk"
 EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                 --program-prefix=${TARGET_PREFIX} \
-                --disable-werror"
+                --disable-werror \
+                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
 
 do_install () {
 	autotools_do_install
Signature · 1 line
1.7.7.3
#1 lore raw

PATCH 2/2 binutils: Allow plugins

Make sure it's possible to build binutils with
plugin support.

---
 .../binutils/binutils-cross-canadian.inc           |    3 ++-
 meta/recipes-devtools/binutils/binutils-cross.inc  |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-devtools/binutils/binutils-cross-canadian.inc +2 -1
index 00648a6..4f20ad7 100644
@@ -8,7 +8,8 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l
 EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                 --program-prefix=${TARGET_PREFIX} \
                 --disable-werror \
-                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
+                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
+                ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"
 
 do_install () {
 	autotools_do_install
meta/recipes-devtools/binutils/binutils-cross.inc +2 -1
index 80152a9..0af913d 100644
@@ -10,7 +10,8 @@ EXTRA_OECONF = "--with-sysroot=${STAGING_DIR_TARGET} \
                 --disable-werror \
                 --enable-poison-system-directories \
                 ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
-                ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
+                ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
+                ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"
 
 do_install () {
 	oe_runmake 'DESTDIR=${D}' install
Signature · 1 line
1.7.7.3
#2 lore raw

Re: [PATCH 2/2] binutils: Allow plugins

Should I send this patch to oe-core (ML and/or github pull req) instead?

- Derek

#3 lore raw

Re: [PATCH 2/2] binutils: Allow plugins

In reply to Derek Buitenhuis
Quoted 28 lines · Derek Buitenhuis

Make sure it's possible to build binutils with
plugin support.

---
  .../binutils/binutils-cross-canadian.inc           |    3 ++-
  meta/recipes-devtools/binutils/binutils-cross.inc  |    3 ++-
  2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-devtools/binutils/binutils-cross-canadian.inc +2 -1
index 00648a6..4f20ad7 100644
@@ -8,7 +8,8 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l
  EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                  --program-prefix=${TARGET_PREFIX} \
                  --disable-werror \
-                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
+                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
+                ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"
 
  do_install () {
  	autotools_do_install
meta/recipes-devtools/binutils/binutils-cross.inc +0 -0
index 80152a9..0af913d 100644

meta/recipes-devtools/binutils/binutils-cross.inc EXTRA_OECONF = "--with-sysroot=${STAGING_DIR_TARGET} \ · line 17

Quoted 9 lines
meta/recipes-devtools/binutils/binutils-cross.inc +2 -1
@@ -10,7 +10,8 @@ EXTRA_OECONF = "--with-sysroot=${STAGING_DIR_TARGET} \
                  --disable-werror \
                  --enable-poison-system-directories \
                  ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
-                ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
+                ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
+                ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"
 
  do_install () {
  	oe_runmake 'DESTDIR=${D}' install

I think that the DISTRO_FEATURE here is too much, you this be changed to be a PACKAGECONFIG instead?

Sau!

#4 lore raw

Re: [PATCH 2/2] binutils: Allow plugins

In reply to Derek Buitenhuis
Quoted 14 lines · Derek Buitenhuis

Make sure it's possible to build binutils with
plugin support.

---
 .../binutils/binutils-cross-canadian.inc           |    3 ++-
 meta/recipes-devtools/binutils/binutils-cross.inc  |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-devtools/binutils/binutils-cross-canadian.inc +0 -0
index 00648a6..4f20ad7 100644

meta/recipes-devtools/binutils/binutils-cross-canadian.inc DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l · line 12

Quoted 6 lines
meta/recipes-devtools/binutils/binutils-cross-canadian.inc +2 -1
@@ -8,7 +8,8 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l
 EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                 --program-prefix=${TARGET_PREFIX} \
                 --disable-werror \
-                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
+                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
+                ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"

enabling plugins regardless is a good thing and since we use binutils 2.22+ now a days in oe-core plugins are well supported. Please submit the patch where you add this option (--enable-plugins) to binutils common configure that will be add to EXTRA_OECONF in binutils.inc

-Khem

#5 lore raw

Re: [PATCH 2/2] binutils: Allow plugins

Quoted 6 lines · Khem Raj

enabling plugins regardless is a good thing and since we use binutils 2.22+ now a days in oe-core plugins are well supported. Please submit the patch where you add this option (--enable-plugins) to binutils common configure that will be add to EXTRA_OECONF in binutils.inc

-Khem

Sweet! Sorry I've been MIA for a bit. I've sent in the new patch, which patches all 3 includes. From a look, this seemed necessary, but if it isn't, let me know.

Patch is sent in reply to the original patch set, titled:

[PATCH 2/2 v2] binutils: Always enable plugins

Enjoy.

- Derek

Applied
#6 lore raw
In reply to Derek Buitenhuis
Quoted 14 lines · Derek Buitenhuis

In order to actually generate a toolchain (with bitbake meta-toolchain) that supports gold, binutils- cross-canadian also needs to be built this way.

---
  .../binutils/binutils-cross-canadian.inc           |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
meta/recipes-devtools/binutils/binutils-cross-canadian.inc +0 -0
index b1cee67..00648a6 100644

meta/recipes-devtools/binutils/binutils-cross-canadian.inc BPN = "binutils" · line 14

Quoted 9 lines
meta/recipes-devtools/binutils/binutils-cross-canadian.inc +2 -1
@@ -7,7 +7,8 @@ BPN = "binutils"
  DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/libc-nativesdk zlib-nativesdk gettext-nativesdk"
  EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                  --program-prefix=${TARGET_PREFIX} \
-                --disable-werror"
+                --disable-werror \
+                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
 
  do_install () {
  	autotools_do_install

Merged into OE-Core

In the future for OE-Core (meta/*) changes please send them to [email protected]

Thanks
Sau!

#7 lore raw
Quoted 8 lines · Saul Wold

Merged into OE-Core

In the future for OE-Core (meta/*) changes please send them to [email protected]

Thanks
Sau!

Thanks, and noted for future reference.

Cheers,

- Derek

#8 lore raw

PATCH v2 2/2 binutils: Always enable plugins

In reply to Derek Buitenhuis

Since oe-core now uses binutils 2.22+, plugins should be well supported. Enable them by default.

---
 .../binutils/binutils-cross-canadian.inc           |    1 +
 meta/recipes-devtools/binutils/binutils-cross.inc  |    1 +
 meta/recipes-devtools/binutils/binutils.inc        |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)
meta/recipes-devtools/binutils/binutils-cross-canadian.inc +1 -0
index 15b9abb..c902c51 100644
@@ -8,6 +8,7 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l
 EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                 --program-prefix=${TARGET_PREFIX} \
                 --disable-werror \
+                --enable-plugins \
                 ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
 
 do_install () {
meta/recipes-devtools/binutils/binutils-cross.inc +1 -0
index 80152a9..38457e8 100644
@@ -9,6 +9,7 @@ EXTRA_OECONF = "--with-sysroot=${STAGING_DIR_TARGET} \
                 --disable-install-libbfd \
                 --disable-werror \
                 --enable-poison-system-directories \
+                --enable-plugins \
                 ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
                 ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
 
meta/recipes-devtools/binutils/binutils.inc +1 -0
index 30a0416..5449e1a 100644
@@ -52,6 +52,7 @@ B = "${S}/build.${HOST_SYS}.${TARGET_SYS}"
 EXTRA_OECONF = "--program-prefix=${TARGET_PREFIX} \
                 --enable-install-libbfd \
                 --enable-shared \
+                --enable-plugins \
                 ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
 
 EXTRA_OECONF_virtclass-native = "--enable-target=all --enable-64-bit-bfd --enable-install-libbfd"
Signature · 1 line
1.7.8.3
#9 lore raw

Re: [PATCH 2/2 v2] binutils: Always enable plugins

Quoted 45 lines · Derek Buitenhuis

Since oe-core now uses binutils 2.22+, plugins should be well supported. Enable them by default.

---
 .../binutils/binutils-cross-canadian.inc           |    1 + meta/recipes-devtools/binutils/binutils-cross.inc  |    1 + meta/recipes-devtools/binutils/binutils.inc        |    1 +

 3 files changed, 3 insertions(+), 0 deletions(-)
meta/recipes-devtools/binutils/binutils-cross-canadian.inc +1 -0
index 15b9abb..c902c51 100644
@@ -8,6 +8,7 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l
  EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                 --program-prefix=${TARGET_PREFIX} \
                 --disable-werror \
+                --enable-plugins \

                ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"

 do_install () {

meta/recipes-devtools/binutils/binutils-cross.inc +1 -0
index 80152a9..38457e8 100644
@@ -9,6 +9,7 @@ EXTRA_OECONF = "--with-sysroot=${STAGING_DIR_TARGET} \
                 --disable-install-libbfd \
                 --disable-werror \
                 --enable-poison-system-directories \
+                --enable-plugins \
                 ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \

                ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"

meta/recipes-devtools/binutils/binutils.inc +1 -0
index 30a0416..5449e1a 100644
@@ -52,6 +52,7 @@ B = "${S}/build.${HOST_SYS}.${TARGET_SYS}"
  EXTRA_OECONF = "--program-prefix=${TARGET_PREFIX} \
                 --enable-install-libbfd \
                 --enable-shared \
+                --enable-plugins \

                ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"

Quoted 3 lines

 EXTRA_OECONF_virtclass-native = "--enable-target=all --enable-64-bit-bfd --enable-install-libbfd" --
1.7.8.3

while this patch is ok. It occurs to me that we might have to find an easier way to specify common options once for all binutils recipes

Quoted 1 line
#10 lore raw

Re: [PATCH 2/2 v2] binutils: Always enable plugins

Quoted 2 lines · Khem Raj

while this patch is ok. It occurs to me that we might have to find an easier way to specify common options once for all binutils recipes

A singular EXTRA_OECONF = ... in binutils.inc, and use EXTRA_OECONF += elsewhere after including it, perhaps? :/

- Derek

#11 lore raw

Re: [PATCH 2/2 v2] binutils: Always enable plugins

Quoted 9 lines · Derek Buitenhuis
Quoted 3 lines · Khem Raj

while this patch is ok. It occurs to me that we might have to find an easier way to specify common options once for all binutils recipes

A singular EXTRA_OECONF = ... in binutils.inc, and use EXTRA_OECONF += elsewhere after including it, perhaps? :/

yes we can refactor binutils.inc into binutils-common.inc and binutils.inc where the former holds the shareable parts

Quoted 1 line

- Derek

#12 lore raw

Re: [PATCH 2/2 v2] binutils: Always enable plugins

In reply to Khem Raj
Quoted 2 lines · Khem Raj

while this patch is ok. It occurs to me that we might have to find an easier way to specify common options once for all binutils recipes

So uh, I am not clear if this patch will be pushed or if you're waiting for a refactor of binutils...

- Derek

#13 lore raw

Re: [PATCH 2/2 v2] binutils: Always enable plugins

Quoted 8 lines · Derek Buitenhuis
Quoted 3 lines · Khem Raj

while this patch is ok. It occurs to me that we might have to find an easier way to specify common options once for all binutils recipes

So uh, I am not clear if this patch will be pushed or if you're waiting for a refactor of binutils...

this is ok to go in. cleanup can happen at later times

Quoted 2 lines

- Derek

#14 lore raw

Re: [PATCH 2/2 v2] binutils: Always enable plugins

Quoted 4 lines · Khem Raj
Quoted 2 lines · Derek Buitenhuis
Quoted 1 line · Khem Raj
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

while this patch is ok. It occurs to me that we might have to find an easier way to specify common options once for all binutils recipes

So uh, I am not clear if this patch will be pushed or if you're waiting for a refactor of binutils...

this is ok to go in. cleanup can happen at later times

Ping! Resurrecting an old thread!

Is this going to be pushed?

- Derek

#15 lore raw

Re: [PATCH 2/2 v2] binutils: Always enable plugins

Quoted 9 lines · Derek Buitenhuis
Quoted 8 lines · Khem Raj
Quoted 6 lines · Derek Buitenhuis
Quoted 3 lines · Khem Raj

while this patch is ok. It occurs to me that we might have to find an easier way to specify common options once for all binutils recipes

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

So uh, I am not clear if this patch will be pushed or if you're waiting for a refactor of binutils...

this is ok to go in. cleanup can happen at later times

Ping! Resurrecting an old thread!

Is this going to be pushed?

Any reason to not do the refactor now? It's early in 1.3, this would be good to have, let's do it right once.

Thanks
Sau!

Quoted 6 lines

- Derek
_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

#16 lore raw

Re: [PATCH 2/2 v2] binutils: Always enable plugins

In reply to Derek Buitenhuis

Op 29 apr. 2012, om 19:56 heeft Derek Buitenhuis het volgende geschreven:

Quoted 9 lines · Khem Raj
Quoted 8 lines
Quoted 6 lines · Derek Buitenhuis
Quoted 3 lines · Khem Raj

while this patch is ok. It occurs to me that we might have to find an easier way to specify common options once for all binutils recipes

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

So uh, I am not clear if this patch will be pushed or if you're waiting for a refactor of binutils...

this is ok to go in. cleanup can happen at later times

Ping! Resurrecting an old thread!

Is this going to be pushed?

You could start by sending it to the right mailing list. Hint: not poky.