Skip to contentSkip to conversation

Fix typo in ctcs that causes build failure

PATCH In review philby john 2 participants 2 messages Jan 5, 2012 – Jan 6, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix typo in ctcs that causes build failure

From: Philby John <[email protected]>
Date: Thu, 5 Jan 2012 18:01:11 +0530
Subject: [PATCH] Fix typo in ctcs that causes build failure

RDEPENDS includes a line perl-module-tcntl, which is clearly a typo for perl-module-fcntl, without which you get a build failure.

---
 recipes/ctorrent/ctcs_1.4.1.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
recipes/ctorrent/ctcs_1.4.1.bb +2 -1
index afaee6f..8680b0c 100644
@@ -1,10 +1,11 @@
 require ctorrent.inc
 
 DESCRIPTION += "This is the controller of the enhanced version"
-RDEPENDS_${PN} = "perl perl-module-strict perl-module-socket perl-module-tcntl \
+RDEPENDS_${PN} = "perl perl-module-strict perl-module-socket perl-module-fcntl \
             perl-module-errno perl-module-sys-hostname"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/dtorrent/ctcs-${PV}.tar.gz"
+PR="r1"
 
 do_install () {
   install -d ${D}/usr/bin
Signature · 1 line
1.6.3.3.338.ge89ce
#1 lore raw

Dear Philby,

thank you for the patch.

Am Donnerstag, den 05.01.2012, 18:23 +0530 schrieb philby john:

Quoted 3 lines

From: Philby John <[email protected]>
Date: Thu, 5 Jan 2012 18:01:11 +0530
Subject: [PATCH] Fix typo in ctcs that causes build failure

Please adhere to the commit policy. Especially prefix the commit summary with the package name.

Quoted 3 lines

RDEPENDS includes a line perl-module-tcntl, which is clearly a typo for perl-module-fcntl, without which you get a build failure.

I see that this is an error and will push your improved patch. But I tried bitbake -k ctcs with angstrom-2010.x for MACHINE = "beagleboard" and it worked without problems. What command did you use to get a build error and how does it look like? I guess it is in the final image creation that the error occurs?

Quoted 4 lines
---
 recipes/ctorrent/ctcs_1.4.1.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

[…]

Thanks,

Paul

[1] http://www.openembedded.org/wiki/Commit_Policy