ASoC: Fix build dependency for SND_ATMEL_SOC_SSC
PATCH 1/1 ASoC: Fix build dependency for SND_ATMEL_SOC_SSC
Make SND_ATMEL_SOC_SSC select ATMEL_SSC to fix below build errors:
LD .tmp_vmlinux1sound/built-in.o: In function `atmel_ssc_remove':sound/soc/atmel/atmel_ssc_dai.c:713: undefined reference to ssc_free' sound/built-in.o: In function atmel_ssc_probe':sound/soc/atmel/atmel_ssc_dai.c:700: undefined reference to ssc_request' sound/built-in.o: In function atmel_ssc_set_audio':sound/soc/atmel/atmel_ssc_dai.c:845: undefined reference to ssc_request' sound/soc/atmel/atmel_ssc_dai.c:851: undefined reference to ssc_free'
make: *** [.tmp_vmlinux1] Error 1
---
This patch is against linux-next 20120103.
sound/soc/atmel/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/atmel/Kconfig +1 -0
@@ -9,6 +9,7 @@ config SND_ATMEL_SOC config SND_ATMEL_SOC_SSC tristate depends on SND_ATMEL_SOC + select ATMEL_SSC help Say Y or M if you want to add support for codecs the ATMEL SSC interface. You will also needs to select the individual
Signature · 1 line
1.7.5.4
2012/1/6 Axel Lin <[email protected]>:
Quoted 23 lines
Make
SND_ATMEL_SOC_SSCselectATMEL_SSCto fix below build errors:LD .tmp_vmlinux1
sound/built-in.o: In function `atmel_ssc_remove':sound/soc/atmel/atmel_ssc_dai.c:713: undefined reference tossc_free' sound/built-in.o: In functionatmel_ssc_probe':sound/soc/atmel/atmel_ssc_dai.c:700: undefined reference tossc_request' sound/built-in.o: In functionatmel_ssc_set_audio':sound/soc/atmel/atmel_ssc_dai.c:845: undefined reference tossc_request' sound/soc/atmel/atmel_ssc_dai.c:851: undefined reference tossc_free'
make: *** [.tmp_vmlinux1] Error 1Signed-off-by Axel Lin <[email protected]>---
This patch is against linux-next 20120103.
sound/soc/atmel/Kconfig | 1 +1 files changed, 1 insertions(+), 0 deletions(-)sound/soc/atmel/Kconfig +0
-0@@ -9,6 +9,7 @@ config SND_ATMEL_SOC
Quoted 4 lines
config
SND_ATMEL_SOC_SSC
tristate
depends onSND_ATMEL_SOC
+ selectATMEL_SSC
With this patch I got recursive dependency detected with the patch because SND_AT91_SOC_SAM9G20_WM8731 depends on ATMEL_SSC.
scripts/kconfig/mconf Kconfig drivers/misc/Kconfig:212:error: recursive dependency detected!drivers/misc/Kconfig:212: symbol ATMEL_SSC is selected bySND_ATMEL_SOC_SSCsound/soc/atmel/Kconfig:9: symbol SND_ATMEL_SOC_SSC is selected
by SND_AT91_SOC_SAM9G20_WM8731sound/soc/atmel/Kconfig:18: symbol SND_AT91_SOC_SAM9G20_WM8731
depends on ATMEL_SSC
And if I removed ATMEL_SSC dependency from SND_AT91_SOC_SAM9G20_WM8731, I still got below build warning:
warning: (SND_ATMEL_SOC_SSC) selects ATMEL_SSC which has unmet direct dependencies (MISC_DEVICES && (AVR32 || ARCH_AT91))
warning: (SND_ATMEL_SOC_SSC) selects ATMEL_SSC which has unmet direct dependencies (MISC_DEVICES && (AVR32 || ARCH_AT91))
So how about make SND_AT91_SOC_AFEB9260 depend on ATMEL_SSC instead of making SND_ATMEL_SOC_SSC select ATMEL_SSC? Comment?
Regards,
Axek