Skip to contentSkip to conversation

watchdog: via_wdt: Staticise wdt_pci_table

PATCH In review Axel Lin 2 participants 2 messages Jan 14, 2012 – Jan 16, 2012 Watchdog device drivers

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 watchdog: via_wdt: Staticise wdt_pci_table

It is only used in this driver, so no need to make the symbol global.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/watchdog/via_wdt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/watchdog/via_wdt.c +1 -1
index 026b4bb..8b24b00 100644
@@ -233,7 +233,7 @@ static void __devexit wdt_remove(struct pci_dev *pdev)
 	pci_disable_device(pdev);
 }
 
-DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
+static DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_CX700) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX800) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX855) },
Signature · 1 line
1.7.5.4
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Axel Lin

It is only used in this driver, so no need to make the symbol global.

Agree.

Acked-by Marc Vertes <[email protected]>
Quoted 18 lines
Signed-off-by Axel Lin <[email protected]>
---
 drivers/watchdog/via_wdt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/watchdog/via_wdt.c +1 -1
index 026b4bb..8b24b00 100644
@@ -233,7 +233,7 @@ static void __devexit wdt_remove(struct pci_dev *pdev)
 	pci_disable_device(pdev);
 }
 
-DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
+static DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_CX700) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX800) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX855) },