Skip to contentSkip to conversation

gpio: Add missing spin_lock_init in gpio-pch driver

PATCH Superseded Axel Lin 2 participants 2 messages Jan 17, 2012

Subsystems (2)
GPIO Intel GPIO drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 gpio: Add missing spin_lock_init in gpio-pch driver

This bug was introduced by commit d568a681
"gpio-pch: add spinlock in suspend/resume processing" which adds a spinlock to struct pch_gpio but never init the spinlock.

Reported-by Tomoya MORINAGA <[email protected]>
Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/gpio-pch.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/gpio/gpio-pch.c +1 -0
index f060329..e84eabf 100644
@@ -392,6 +392,7 @@ static int __devinit pch_gpio_probe(struct pci_dev *pdev,
 	chip->reg = chip->base;
 	pci_set_drvdata(pdev, chip);
 	mutex_init(&chip->lock);
+	spin_lock_init(&chip->spinlock);
 	pch_gpio_setup(chip);
 	ret = gpiochip_add(&chip->gpio);
 	if (ret) {
Signature · 1 line
1.7.5.4