drm/i915: print out which pixel format we do not support
Subsystems (2)
PATCH 1/1 drm/i915: print out which pixel format we do not support
Otherwise, we are left with pretty bogus message saying that the pixel format is not supported while leaving the details to the telepatic powers.
--- drivers/gpu/drm/i915/intel_display.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/intel_display.c +2 -1
@@ -7880,7 +7880,8 @@ int intel_framebuffer_init(struct drm_device *dev,case DRM_FORMAT_VYUY :break ;default : -DRM_ERROR ("unsupported pixel format\n" ); +DRM_ERROR ("unsupported pixel format %u\n" , + mode_cmd->pixel_format);return -EINVAL ; }
Signature · 1 line
1.7.8.3
Quoted 13 lines · Eugeni Dodonov
Otherwise, we are left with pretty bogus message saying that the pixel format is not supported while leaving the details to the telepatic powers.
Signed-off-by Eugeni Dodonov <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)drivers/gpu/drm/i915/intel_display.c +0
-0
drivers/gpu/drm/i915/intel_display.c int intel_framebuffer_init(struct drm_device *dev, · line 7884
Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +2
-1@@ -7880,7 +7880,8 @@ int intel_framebuffer_init(struct drm_device *dev,case DRM_FORMAT_VYUY :break ;default : -DRM_ERROR ("unsupported pixel format\n" ); +DRM_ERROR ("unsupported pixel format %u\n" , + mode_cmd->pixel_format);
While we're bashing Jesse, this looks like a user-triggerable error. Can we have a DRM_DEBUG_KMS instead?
-Daniel
Signature · 3 lines
Daniel Vetter Mail: [email protected] Mobile: +41 (0)79 365 57 48
PATCH 1/1 drm/i915: print out which pixel format we do not support
Otherwise, we are left with pretty bogus message saying that the pixel format is not supported while leaving the details to the telepatic powers.
v2: use DRM_DEBUG_KMS instead of DRM_ERROR
--- drivers/gpu/drm/i915/intel_display.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/intel_display.c +2 -1
@@ -7880,7 +7880,8 @@ int intel_framebuffer_init(struct drm_device *dev,case DRM_FORMAT_VYUY :break ;default : -DRM_ERROR ("unsupported pixel format\n" ); +DRM_DEBUG_KMS ("unsupported pixel format %u\n" , + mode_cmd->pixel_format);return -EINVAL ; }
Signature · 1 line
1.7.8.3
Daniel Vetter
AppliedQuoted 6 lines · Eugeni Dodonov
Otherwise, we are left with pretty bogus message saying that the pixel format is not supported while leaving the details to the telepatic powers.
v2: use
DRM_DEBUG_KMSinstead ofDRM_ERRORSigned-off-by Eugeni Dodonov <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Mail: [email protected] Mobile: +41 (0)79 365 57 48