Skip to contentSkip to conversation

yaffs: Use deferable timer for background operations

PATCH Superseded Sujit Reddy Thumma 2 participants 2 messages Jan 20, 2012 Arm Qualcomm mailing list

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 yaffs: Use deferable timer for background operations

Use deferable timer in background operations thread, so that it won't cause unnecessary wakeups. Typically, wakeups are seen in the range 60ms to 2secs (for HZ=100) after the thread is scheduled out. In general, during this delay the processor can go into sleep, if there is no other activity. Since, the work done in this background operation is not critical and can be handled as soon as when timer expires and processor wakes up for other critical events, we mark the timer responsible for wakeup of this thread as deferable timer. Otherwise, the processor wakesup unnecessarily to handle the background operations causing higher power consumption in idle state.

---
 yaffs_vfs_multi.c  |    9 ++++-----
 yaffs_vfs_single.c |    5 ++---
 2 files changed, 6 insertions(+), 8 deletions(-)
yaffs_vfs_multi.c +4 -5
index b8e5124..2132ae3 100644
@@ -129,9 +129,9 @@
 #endif
 
 #if (LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 26))
-#define Y_INIT_TIMER(a)	init_timer(a)
+#define Y_INIT_TIMER(a, b, c)	setup_timer(a, b, c)
 #else
-#define Y_INIT_TIMER(a)	init_timer_on_stack(a)
+#define Y_INIT_TIMER(a, b, c)	setup_deferrable_timer_on_stack(a, b, c)
 #endif
 
 #if (LINUX_VERSION_CODE > KERNEL_VERSION(2, 6, 17))
@@ -2300,10 +2300,9 @@ static int yaffs_bg_thread_fn(void *data)
 		if (time_before(expires, now))
 			expires = now + HZ;
 
-		Y_INIT_TIMER(&timer);
+		Y_INIT_TIMER(&timer, yaffs_background_waker,
+				(unsigned long)current);
 		timer.expires = expires + 1;
-		timer.data = (unsigned long)current;
-		timer.function = yaffs_background_waker;
 
 		set_current_state(TASK_INTERRUPTIBLE);
 		add_timer(&timer);
yaffs_vfs_single.c +2 -3
index f822845..1ddc03e 100644
@@ -1636,10 +1636,9 @@ static int yaffs_bg_thread_fn(void *data)
 		if (time_before(expires, now))
 			expires = now + HZ;
 
-		init_timer_on_stack(&timer);
+		setup_deferrable_timer_on_stack(&timer, yaffs_background_waker,
+				(unsigned long)current);
 		timer.expires = expires + 1;
-		timer.data = (unsigned long)current;
-		timer.function = yaffs_background_waker;
 
 		set_current_state(TASK_INTERRUPTIBLE);
 		add_timer(&timer);
Signature · 2 lines
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
#1 lore raw
Quoted 5 lines · Sujit Reddy Thumma
yaffs_vfs_multi.c +0 -0
index b8e5124..2132ae3 100644

yaffs_vfs_multi.c line 135

Quoted 9 lines
yaffs_vfs_multi.c +2 -2
@@ -129,9 +129,9 @@
 #endif
 
 #if (LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 26))
-#define Y_INIT_TIMER(a)	init_timer(a)
+#define Y_INIT_TIMER(a, b, c)	setup_timer(a, b, c)
 #else
-#define Y_INIT_TIMER(a)	init_timer_on_stack(a)
+#define Y_INIT_TIMER(a, b, c)	setup_deferrable_timer_on_stack(a, b, c)
 #endif

setup_timer() was added in 2.6.15, so I'm not sure that this will quite work as is.

David

Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.