Skip to contentSkip to conversation

perf, tool: Fix perf stack to non executable on x86_64

PATCH In review Jiri Olsa 2 participants 4 messages Feb 1, 2012 – Feb 7, 2012 perf events

lore
Share & tools
lore

Jiri Olsa

author
#0 lore raw

PATCH 1/1 perf, tool: Fix perf stack to non executable on x86_64

By adding following objects:
bench/mem-memset-x86-64-asm.o bench/mem-memcpy-x86-64-asm.o
the x86_64 perf binary ended up with executable stack.

The reason was that above objects are assembler sourced and are missing the GNU-stack note section. In such case the linker assumes that the final binary should not be restricted at all and mark the stack as RWX.

Adding section ".note.GNU-stack" definition to mentioned objects, with all flags disabled, thus omiting those objects from linker stack flags decision.

---
 tools/perf/bench/mem-memcpy-x86-64-asm.S |    7 +++++++
 tools/perf/bench/mem-memset-x86-64-asm.S |    7 +++++++
 2 files changed, 14 insertions(+), 0 deletions(-)
tools/perf/bench/mem-memcpy-x86-64-asm.S +7 -0
index a20780b..a6c8909 100644
@@ -4,3 +4,10 @@
 #define Lmemcpy_c globl memcpy_c; memcpy_c
 #define Lmemcpy_c_e globl memcpy_c_e; memcpy_c_e
 #include "../../../arch/x86/lib/memcpy_64.S"
+
+/*
+ * We need to provide note.GNU-stack section, saying that we want
+ * NOT executable stack. Otherwise the final linking will assume that
+ * the ELF stack should not be restricted at all and set it RWX.
+ */
+.section .note.GNU-stack,"",@progbits
tools/perf/bench/mem-memset-x86-64-asm.S +7 -0
index cb92170..9e5af89 100644
@@ -4,3 +4,10 @@
 #define Lmemset_c globl memset_c; memset_c
 #define Lmemset_c_e globl memset_c_e; memset_c_e
 #include "../../../arch/x86/lib/memset_64.S"
+
+/*
+ * We need to provide note.GNU-stack section, saying that we want
+ * NOT executable stack. Otherwise the final linking will assume that
+ * the ELF stack should not be restricted at all and set it RWX.
+ */
+.section .note.GNU-stack,"",@progbits
Signature · 1 line
1.7.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Jiri Olsa

By adding following objects:
bench/mem-memset-x86-64-asm.o bench/mem-memcpy-x86-64-asm.o
the x86_64 perf binary ended up with executable stack.

The reason was that above objects are assembler sourced and are missing the GNU-stack note section. In such case the linker assumes that the final binary should not be restricted at all and mark the stack as RWX.

Quoted 6 lines

Adding section ".note.GNU-stack" definition to mentioned objects, with all flags disabled, thus omiting those objects from linker stack flags decision.

---

Good catch, thanks !

#2 lore raw

[tip:perf/core] perf tools: Fix perf stack to non executable on x86_64

In reply to Jiri Olsa
Commit-ID:  7a0153ee15575a4d07b5da8c96b79e0b0fd41a12
Gitweb:     http://git.kernel.org/tip/7a0153ee15575a4d07b5da8c96b79e0b0fd41a12
Author:     Jiri Olsa <[email protected]>
AuthorDate: Mon, 6 Feb 2012 18:54:06 -0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 6 Feb 2012 18:54:06 -0200

perf tools: Fix perf stack to non executable on x86_64

By adding following objects:
bench/mem-memcpy-x86-64-asm.o
the x86_64 perf binary ended up with executable stack.

The reason was that above object are assembler sourced and is missing the GNU-stack note section. In such case the linker assumes that the final binary should not be restricted at all and mark the stack as RWX.

Adding section ".note.GNU-stack" definition to mentioned object, with all flags disabled, thus omiting this object from linker stack flags decision.

Problem introduced in:

  $ git describe ea7872b
  v2.6.37-rc2-19-gea7872b

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=783570

Cc Corey Ashford <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
[ committer note: Backported fix to perf/urgent (3.3-rc2+) ]
---
 tools/perf/bench/mem-memcpy-x86-64-asm.S |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
tools/perf/bench/mem-memcpy-x86-64-asm.S +6 -0
index a57b66e..185a96d 100644
@@ -1,2 +1,8 @@
 
 #include "../../../arch/x86/lib/memcpy_64.S"
+/*
+ * We need to provide note.GNU-stack section, saying that we want
+ * NOT executable stack. Otherwise the final linking will assume that
+ * the ELF stack should not be restricted at all and set it RWX.
+ */
+.section .note.GNU-stack,"",@progbits
#3 lore raw

[tip:perf/core] perf tool: Fix perf stack to non executable on x86_64

In reply to Jiri Olsa
Commit-ID:  e89cef136a8b56eef1acf702591fd3039fc3385d
Gitweb:     http://git.kernel.org/tip/e89cef136a8b56eef1acf702591fd3039fc3385d
Author:     Jiri Olsa <[email protected]>
AuthorDate: Wed, 1 Feb 2012 13:54:08 +0100
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 6 Feb 2012 19:14:17 -0200

perf tool: Fix perf stack to non executable on x86_64

By adding following objects:
bench/mem-memset-x86-64-asm.o bench/mem-memcpy-x86-64-asm.o
the x86_64 perf binary ended up with executable stack.

The reason was that above objects are assembler sourced and are missing the GNU-stack note section. In such case the linker assumes that the final binary should not be restricted at all and mark the stack as RWX.

Adding section ".note.GNU-stack" definition to mentioned objects, with all flags disabled, thus omiting those objects from linker stack flags decision.

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=783570

Cc Corey Ashford <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
[ committer note: Remaining bits after what was already added to perf/urgent ]
---
 tools/perf/bench/mem-memset-x86-64-asm.S |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
tools/perf/bench/mem-memset-x86-64-asm.S +7 -0
index cb92170..9e5af89 100644
@@ -4,3 +4,10 @@
 #define Lmemset_c globl memset_c; memset_c
 #define Lmemset_c_e globl memset_c_e; memset_c_e
 #include "../../../arch/x86/lib/memset_64.S"
+
+/*
+ * We need to provide note.GNU-stack section, saying that we want
+ * NOT executable stack. Otherwise the final linking will assume that
+ * the ELF stack should not be restricted at all and set it RWX.
+ */
+.section .note.GNU-stack,"",@progbits