Skip to contentSkip to conversation

uxa/glamor: Use a macro to specify module name.

PATCH In review [email protected] 2 participants 4 messages Feb 2, 2012 – Feb 8, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uxa/glamor: Use a macro to specify module name.

From: Zhigang Gong <[email protected]>

---
 src/intel_glamor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
src/intel_glamor.c +1 -1
index 446dd3d..f908b7c 100644
@@ -67,7 +67,7 @@ intel_glamor_pre_init(ScrnInfoPtr scrn)
 	intel = intel_get_screen_private(scrn);
 
 	/* Load glamor module */
-	if ((glamor_module = xf86LoadSubModule(scrn, "glamor_egl"))) {
+	if ((glamor_module = xf86LoadSubModule(scrn, GLAMOR_EGL_MODULE_NAME))) {
 		version = xf86GetModuleVersion(glamor_module);
 		if (version < MODULE_VERSION_NUMERIC(0,3,0)) {
 			xf86DrvMsg(scrn->scrnIndex, X_ERROR,
Signature · 1 line
1.7.4.4
#1 lore raw
Quoted 1 line · On Thu, 2 Feb 2012 11:30:57 +0800, [email protected] wrote:

From: Zhigang Gong <[email protected]>

Would be good to mention which commit introduces the macro into glamor, just to serve as a reminder that one needs to update. Same for the other patches that introduces a new dependency.
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#2 lore raw
Quoted 7 lines

-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Thursday, February 02, 2012 4:52 PM
To: [email protected]
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] uxa/glamor: Use a macro to specify module name.

Quoted 7 lines
Quoted 1 line · On Thu, 2 Feb 2012 11:30:57 +0800, [email protected] wrote:

From: Zhigang Gong <[email protected]>

Would be good to mention which commit introduces the macro into glamor, just to serve as a reminder that one needs to update. Same for the other patches that introduces a new dependency.

Agree, these patches should be reviewed with the corresponding glamor patches.
For this patch, the glamor patch is as below:
http://lists.freedesktop.org/archives/glamor/2012-February/000068.html

Quoted 4 lines

-Chris

--
Chris Wilson, Intel Open Source Technology Centre

#3 lore raw
In reply to [email protected]

src/intel_glamor.c index

Quoted 15 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]]
Sent: Thursday, February 02, 2012 11:31 AM
To: [email protected]
Cc: [email protected]; [email protected]
Subject: [PATCH] uxa/glamor: Use a macro to specify module name.

From: Zhigang Gong <[email protected]>

---
 src/intel_glamor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
src/intel_glamor.c index renamed from src/intel_glamor.c +0 -0

446dd3d..f908b7c

Quoted 15 lines

100644

src/intel_glamor.c +2 -2
@@ -67,7 +67,7 @@ intel_glamor_pre_init(ScrnInfoPtr scrn)
 	intel = intel_get_screen_private(scrn);
 
 	/* Load glamor module */
-	if ((glamor_module = xf86LoadSubModule(scrn, "glamor_egl"))) {
+	if ((glamor_module = xf86LoadSubModule(scrn,
 GLAMOR_EGL_MODULE_NAME)))
+{
 		version = xf86GetModuleVersion(glamor_module);
 		if (version < MODULE_VERSION_NUMERIC(0,3,0)) {
 			xf86DrvMsg(scrn->scrnIndex, X_ERROR,
--
Quoted 1 line

1.7.4.4

This patch depends on glamor commit b5f8d...