Skip to contentSkip to conversation

avr32: select GENERIC_ATOMIC64

PATCH In review Cong Wang 2 participants 3 messages Feb 3, 2012

lore
Share & tools
lore

Cong Wang

author
#0 lore raw

PATCH 1/1 avr32: select GENERIC_ATOMIC64

avr32 doesn't implement atomic64_ operations, if not select this, we would get:

kernel/trace/trace_clock.c:117: error: syntax error before 'trace_counter' kernel/trace/trace_clock.c:126: error: implicit declaration of function 'atomic64_add_return'

Cc Haavard Skinnemoen <[email protected]>
Cc Hans-Christian Egtvedt <[email protected]>

---

arch/avr32/Kconfig +1 -0
index 197e96f..6ecb8f4 100644
@@ -11,6 +11,7 @@ config AVR32
 	select HARDIRQS_SW_RESEND
 	select GENERIC_IRQ_SHOW
 	select ARCH_HAVE_NMI_SAFE_CMPXCHG
+	select GENERIC_ATOMIC64
 	help
 	  AVR32 is a high-performance 32-bit RISC microprocessor core,
 	  designed for cost-sensitive embedded applications, with particular
#1 lore raw
Quoted 9 lines · Cong Wang

avr32 doesn't implement atomic64_ operations, if not select this, we would get:

kernel/trace/trace_clock.c:117: error: syntax error before 'trace_counter' kernel/trace/trace_clock.c:126: error: implicit declaration of function 'atomic64_add_return'

Cc Haavard Skinnemoen <[email protected]>
Cc Hans-Christian Egtvedt <[email protected]>

Thanks Cong, but Fabio beat you to it; https://lkml.org/lkml/2012/2/2/406

The above patch (similar to yours), was just pulled into Andrews tree.

Quoted 13 lines

---

arch/avr32/Kconfig +1 -0
index 197e96f..6ecb8f4 100644
@@ -11,6 +11,7 @@ config AVR32
 	select HARDIRQS_SW_RESEND
 	select GENERIC_IRQ_SHOW
 	select ARCH_HAVE_NMI_SAFE_CMPXCHG
+	select GENERIC_ATOMIC64
 	help
 	  AVR32 is a high-performance 32-bit RISC microprocessor core,
 	  designed for cost-sensitive embedded applications, with particular
Signature · 2 lines
mvh
Hans-Christian Egtvedt
author
#2 lore raw
Quoted 7 lines · Hans-Christian Egtvedt
Quoted 6 lines · Cong Wang

avr32 doesn't implement atomic64_ operations, if not select this, we would get:

kernel/trace/trace_clock.c:117: error: syntax error before 'trace_counter' kernel/trace/trace_clock.c:126: error: implicit declaration of function 'atomic64_add_return'

Quoted 7 lines
Quoted 3 lines
Cc Haavard Skinnemoen<[email protected]>
Cc Hans-Christian Egtvedt<[email protected]>

Thanks Cong, but Fabio beat you to it; https://lkml.org/lkml/2012/2/2/406

The above patch (similar to yours), was just pulled into Andrews tree.

Yeah, then ignore mine. :)

Thanks.