NFS: Make keys writable on the idmap keyring.
Subsystems (2)
PATCH 1/1 NFS: Make keys writable on the idmap keyring.
To take advantage of the "Allow special keyrings to be cleared" keyring patch the NFS keyring has to be writeable.
--- fs/nfs/idmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/nfs/idmap.c +1 -1
@@ -269,7 +269,7 @@ static ssize_t nfs_idmap_request_key(const char *name, size_t namelen, }rcu_read_lock (); - rkey->perm |=KEY_USR_VIEW ; + rkey->perm |=KEY_USR_VIEW |KEY_USR_WRITE ; ret =key_validate (rkey);if (ret <0 )
Signature · 1 line
1.7.7.5
Should this go in via the NFS tree? I can put it into the security tree otherwise.
Quoted 24 lines · Steve Dickson
To take advantage of the "Allow special keyrings to be cleared" keyring patch the NFS keyring has to be writeable.
Signed-off-by Steve Dickson <[email protected]>--- fs/nfs/idmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)fs/nfs/idmap.c +1
-1@@ -269,7 +269,7 @@ static ssize_t nfs_idmap_request_key(const char *name, size_t namelen, }rcu_read_lock (); - rkey->perm |=KEY_USR_VIEW ; + rkey->perm |=KEY_USR_VIEW |KEY_USR_WRITE ; ret =key_validate (rkey);if (ret <0 )Signature · 1 line
1.7.7.5
Signature · 2 lines
James Morris <[email protected]>
I'm indifferent... as long as it gets in...
Personally I thought it should been be part of David's "KEYS: Allow special keyrings to be cleared" patch since NFS can not use that feature unless the key is writable...
steved.
Quoted 31 lines · James Morris
Should this go in via the NFS tree? I can put it into the security tree otherwise.
Quoted 24 lines · Steve Dickson
To take advantage of the "Allow special keyrings to be cleared" keyring patch the NFS keyring has to be writeable.
Signed-off-by Steve Dickson <[email protected]>--- fs/nfs/idmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)fs/nfs/idmap.c +1
-1@@ -269,7 +269,7 @@ static ssize_t nfs_idmap_request_key(const char *name, size_t namelen, }rcu_read_lock (); - rkey->perm |=KEY_USR_VIEW ; + rkey->perm |=KEY_USR_VIEW |KEY_USR_WRITE ; ret =key_validate (rkey);if (ret <0 )Signature · 1 line
1.7.7.5
Quoted 2 lines · Steve Dickson
To take advantage of the "Allow special keyrings to be cleared" keyring patch the NFS keyring has to be writeable.
That's not true.
I'll push the "Allow special keyrings to be cleared" keyring patch to James now.
David