Skip to contentSkip to conversation

ASoC: wm8994: Fix typo in VMID ramp setting

PATCH In review Mark Brown 2 participants 3 messages Feb 7, 2012

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: wm8994: Fix typo in VMID ramp setting

The VMID ramp rate is supposed to be 3b, not 0x11. Fix that.

---
 sound/soc/codecs/wm8994.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/codecs/wm8994.c +1 -1
index 81795eb..b75a652 100644
@@ -785,7 +785,7 @@ static void vmid_reference(struct snd_soc_codec *codec)
 				    WM8994_VMID_RAMP_MASK,
 				    WM8994_STARTUP_BIAS_ENA |
 				    WM8994_VMID_BUF_ENA |
-				    (0x11 << WM8994_VMID_RAMP_SHIFT));
+				    (0x3 << WM8994_VMID_RAMP_SHIFT));
 
 		/* Main bias enable, VMID=2x40k */
 		snd_soc_update_bits(codec, WM8994_POWER_MANAGEMENT_1,
Signature · 1 line
1.7.9.rc1
#1 lore raw
Quoted 12 lines · Mark Brown

The VMID ramp rate is supposed to be 3b, not 0x11. Fix that.

---
 sound/soc/codecs/wm8994.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/codecs/wm8994.c +0 -0
index 81795eb..b75a652 100644

sound/soc/codecs/wm8994.c static void vmid_reference(struct snd_soc_codec *codec) · line 788

Quoted 5 lines
sound/soc/codecs/wm8994.c +1 -1
@@ -785,7 +785,7 @@ static void vmid_reference(struct snd_soc_codec *codec)
 				    WM8994_VMID_RAMP_MASK,
 				    WM8994_STARTUP_BIAS_ENA |
 				    WM8994_VMID_BUF_ENA |
-				    (0x11 << WM8994_VMID_RAMP_SHIFT));
+				    (0x3 << WM8994_VMID_RAMP_SHIFT));

The commit message says 3b, so maybe a typo ?

Liam

author
#2 lore raw
Quoted 1 line · Liam Girdwood

The commit message says 3b, so maybe a typo ?

In the commit message, got the binary and the hex the wrong way round.