Skip to contentSkip to conversation

Documentation: kgdb: Replace deprecated remotebaud

PATCH Superseded Christian Löhle 3 participants 6 messages Jan 4, 2022 – Jan 10, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: kgdb: Replace deprecated remotebaud

The gdb remotebaud to set baudrate has been replaced in favor of set serial baud many years ago.

---
 Documentation/dev-tools/kgdb.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/dev-tools/kgdb.rst +1 -1
index 43456244651a..7c90e111b364 100644
@@ -557,7 +557,7 @@ Connecting with gdb to a serial port
    Example (using a directly connected port)::
 
            % gdb ./vmlinux
-           (gdb) set remotebaud 115200
+           (gdb) set serial baud 115200
            (gdb) target remote /dev/ttyS0
 
 
Signature · 4 lines
2.34.1
Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Christian Löhle

The gdb remotebaud to set baudrate has been replaced in favor of set serial baud many years ago.

I'd prefer to have a little more historical info in the patch header so that anyone still running gdb-7.6 has a better shot at finding out what is going on (some folks in the embedded world end up relying on surprisingly old cross-toolsets).

In other words something more like:

Using set remotebaud to set the baud rate was deprecated in gdb-7.7 and completely removed from the command parser in gdb-7.8 (released in 2014). Adopt set serial baud instead.

Other than that the change looks good to me so with an improved description containing the above versions and dates this can be:

Thanks

Daniel.

Quoted 25 lines
---
 Documentation/dev-tools/kgdb.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/dev-tools/kgdb.rst +1 -2
index 43456244651a..7c90e111b364 100644
@@ -557,7 +557,7 @@ Connecting with gdb to a serial port
    Example (using a directly connected port)::
 
            % gdb ./vmlinux
-           (gdb) set remotebaud 115200
+           (gdb) set serial baud 115200
            (gdb) target remote /dev/ttyS0
 
 
--

2.34.1
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director: Dr. Jan Peter Berns. Commercial register of local courts: Freiburg HRB381782

#2 lore raw

PATCH v2 1/1 Documentation: kgdb: Replace deprecated remotebaud

In reply to Christian Löhle

Using set remotebaud to set the baud rate was deprecated in gdb-7.7 and completely removed from the command parser in gdb-7.8 (released in 2014). Adopt set serial baud instead.

---
 Documentation/dev-tools/kgdb.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/dev-tools/kgdb.rst +1 -1
index 43456244651a..7c90e111b364 100644
@@ -557,7 +557,7 @@ Connecting with gdb to a serial port
    Example (using a directly connected port)::
 
            % gdb ./vmlinux
-           (gdb) set remotebaud 115200
+           (gdb) set serial baud 115200
            (gdb) target remote /dev/ttyS0
 
 
Signature · 4 lines
2.34.1
Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782
Reviewed-by on v2 1/1
#3 lore raw
Quoted 5 lines · Christian Löhle

Using set remotebaud to set the baud rate was deprecated in gdb-7.7 and completely removed from the command parser in gdb-7.8 (released in 2014). Adopt set serial baud instead.

Thanks for the update.

Daniel.

PS No need to worry about it this time around but, for future
reference, if someone provides you one of the tags (Reviewed-By, Acked-By, etc) during a review cycle then you are normally expected to collect this and add them to tags section when you share the next version of the patch or, if there are big technical changes that make you choose to view the tag as out-of-date then drop the tag but mention why in the patch changelog.

Quoted 23 lines
---
 Documentation/dev-tools/kgdb.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/dev-tools/kgdb.rst +1 -2
index 43456244651a..7c90e111b364 100644
@@ -557,7 +557,7 @@ Connecting with gdb to a serial port
    Example (using a directly connected port)::
 
            % gdb ./vmlinux
-           (gdb) set remotebaud 115200
+           (gdb) set serial baud 115200
            (gdb) target remote /dev/ttyS0
 
 
--

2.34.1
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director: Dr. Jan Peter Berns. Commercial register of local courts: Freiburg HRB381782

maintainer Applied
#4 lore raw
In reply to Christian Löhle
Quoted 14 lines · Christian Löhle

Using set remotebaud to set the baud rate was deprecated in gdb-7.7 and completely removed from the command parser in gdb-7.8 (released in 2014). Adopt set serial baud instead.

---
 Documentation/dev-tools/kgdb.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/dev-tools/kgdb.rst +0 -0
index 43456244651a..7c90e111b364 100644

Documentation/dev-tools/kgdb.rst Connecting with gdb to a serial port · line 561

Quoted 6 lines
Documentation/dev-tools/kgdb.rst +1 -1
@@ -557,7 +557,7 @@ Connecting with gdb to a serial port
    Example (using a directly connected port)::
 
            % gdb ./vmlinux
-           (gdb) set remotebaud 115200
+           (gdb) set serial baud 115200
            (gdb) target remote /dev/ttyS0

I've applied this, thanks.

I can help but wonder, though, whether the historical information in the changelog actually belongs in the document itself. A user on some ancient system who can't make the example work is probably unlikely to consult the git history when looking for a solution.

jon

#5 lore raw

PATCH v3 1/1 Documentation: kgdb: Replace deprecated remotebaud

Using set remotebaud to set the baud rate was deprecated in gdb-7.7 and completely removed from the command parser in gdb-7.8 (released in 2014). Adopt set serial baud instead.

Change since v2:
- Add historical example in the documentation

---
 Documentation/dev-tools/kgdb.rst | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/dev-tools/kgdb.rst +6 -1
index 43456244651a..d7acb2bdb0ba 100644
@@ -557,9 +557,14 @@ Connecting with gdb to a serial port
    Example (using a directly connected port)::
 
            % gdb ./vmlinux
-           (gdb) set remotebaud 115200
+           (gdb) set serial baud 115200
            (gdb) target remote /dev/ttyS0
 
+   Example (using a directly connected port with gdb version < 7.8)::
+
+           % gdb ./vmlinux
+           (gdb) set remotebaud 115200
+           (gdb) target remote /dev/ttyS0
 
    Example (kgdb to a terminal server on TCP port 2012)::
 
Signature · 4 lines
2.34.1
Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782