block: fix the inaccurate draining activities with block I/O throttling

PATCH In review [email protected] 1 participant 1 message Feb 20, 2012

lore

Share & tools

lore

[email protected]

author

2012-02-20 04:51 UTC #0 lore raw

PATCH 2/2 block: fix the inaccurate draining activities with block I/O throttling

From: Zhi Yong Wu <[email protected]>

Signed-off-by Zhi Yong Wu <[email protected]>

---
 blockdev.c     |    4 ++--
 hw/ide/macio.c |    2 +-
 hw/ide/pci.c   |    3 ++-
 3 files changed, 5 insertions(+), 4 deletions(-)

blockdev.c +2 -2

index 7a6613a..fa85c78 100644
@@ -693,7 +693,7 @@ void qmp_blockdev_snapshot_sync(const char *device, const char *snapshot_file,
         return;
     }
 
-    bdrv_drain_all();
+    bdrv_drain_request(bs);
     bdrv_flush(bs);
 
     bdrv_close(bs);

@@ -882,7 +882,7 @@ int do_drive_del(Monitor *mon, const QDict *qdict, QObject **ret_data)
     }
 
     /* quiesce block driver; prevent further io */
-    bdrv_drain_all();
+    bdrv_drain_request(bs);
     bdrv_flush(bs);
     bdrv_close(bs);

hw/ide/macio.c +1 -1

index abbc41b..201574d 100644
@@ -192,7 +192,7 @@ static void pmac_ide_flush(DBDMA_io *io)
     MACIOIDEState *m = io->opaque;
 
     if (m->aiocb) {
-        bdrv_drain_all();
+        bdrv_drain_request(m->aiocb->bs);
     }
 }

hw/ide/pci.c +2 -1

index 246dd57..55f7622 100644
@@ -27,6 +27,7 @@
 #include <hw/pci.h>
 #include <hw/isa.h>
 #include "block.h"
+#include "block_int.h"
 #include "dma.h"
 
 #include <hw/ide/pci.h>

@@ -309,7 +310,7 @@ void bmdma_cmd_writeb(BMDMAState *bm, uint32_t val)
              * aio operation with preadv/pwritev.
              */
             if (bm->bus->dma->aiocb) {
-                bdrv_drain_all();
+                bdrv_drain_request(bm->bus->dma->aiocb->bs);
                 assert(bm->bus->dma->aiocb == NULL);
                 assert((bm->status & BM_STATUS_DMAING) == 0);
             }

Signature · 1 line

1.7.6