Skip to contentSkip to conversation

dma: dmaengine: Distinguish between 'dmaengine: failed to get' messages

PATCH Applied Fabio Estevam 2 participants 2 messages Feb 21, 2012 – Mar 6, 2012 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma: dmaengine: Distinguish between 'dmaengine: failed to get' messages

The message "dmaengine: failed to get" can come from two possible locations within dmaengine.c.

In order to distinguish between them, replace "dmaengine" with __func__ string so that the source function of the error message can be easily identified.

---
 drivers/dma/dmaengine.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/dma/dmaengine.c +4 -4
index a6c6051..ac10325 100644
@@ -510,8 +510,8 @@ struct dma_chan *__dma_request_channel(dma_cap_mask_t *mask, dma_filter_fn fn, v
 					 dma_chan_name(chan));
 				list_del_rcu(&device->global_node);
 			} else if (err)
-				pr_debug("dmaengine: failed to get %s: (%d)\n",
-					 dma_chan_name(chan), err);
+				pr_debug("%s: failed to get %s: (%d)\n",
+					__func__, dma_chan_name(chan), err);
 			else
 				break;
 			if (--device->privatecnt == 0)
@@ -564,8 +564,8 @@ void dmaengine_get(void)
 				list_del_rcu(&device->global_node);
 				break;
 			} else if (err)
-				pr_err("dmaengine: failed to get %s: (%d)\n",
-				       dma_chan_name(chan), err);
+				pr_err("%s: failed to get %s: (%d)\n",
+					__func__, dma_chan_name(chan), err);
 		}
 	}
 
Signature · 1 line
1.7.1
Applied
#1 lore raw
Quoted 26 lines · Fabio Estevam

The message "dmaengine: failed to get" can come from two possible locations within dmaengine.c.

In order to distinguish between them, replace "dmaengine" with __func__ string so that the source function of the error message can be easily identified.

---
 drivers/dma/dmaengine.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/dma/dmaengine.c +2 -2
index a6c6051..ac10325 100644
@@ -510,8 +510,8 @@ struct dma_chan *__dma_request_channel(dma_cap_mask_t *mask, dma_filter_fn fn, v
 					 dma_chan_name(chan));
 				list_del_rcu(&device->global_node);
 			} else if (err)
-				pr_debug("dmaengine: failed to get %s: (%d)\n",
-					 dma_chan_name(chan), err);
+				pr_debug("%s: failed to get %s: (%d)\n",
+					__func__, dma_chan_name(chan), err);
 			else
 				break;
 			if (--device->privatecnt == 0)

drivers/dma/dmaengine.c void dmaengine_get(void) · line 571

Quoted 10 lines
drivers/dma/dmaengine.c +2 -2
@@ -564,8 +564,8 @@ void dmaengine_get(void)
 				list_del_rcu(&device->global_node);
 				break;
 			} else if (err)
-				pr_err("dmaengine: failed to get %s: (%d)\n",
-				       dma_chan_name(chan), err);
+				pr_err("%s: failed to get %s: (%d)\n",
+					__func__, dma_chan_name(chan), err);
 		}
 	}
 

Applied, Thanks

Signature · 1 line
~Vinod