Skip to contentSkip to conversation

Fixed off-by-one in serial length calculation

PATCH In review Adriaan de Jong 2 participants 2 messages Feb 28, 2012 – Mar 29, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fixed off-by-one in serial length calculation

The serial length was one digit too short, resulting in missing digits at the end of the certificate's stringified serial number.

---
 ssl_verify_polarssl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
ssl_verify_polarssl.c +1 -1
index 2ba0a5c..4206578 100644
@@ -121,7 +121,7 @@ x509_get_serial (x509_cert *cert, struct gc_arena *gc)
   int ret = 0;
   int i = 0;
   char *buf = NULL;
-  size_t len = cert->serial.len * 3;
+  size_t len = cert->serial.len * 3 + 1;
 
   buf = gc_malloc(len, true, gc);
 
Signature · 1 line
1.7.5.4
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 7 lines · Adriaan de Jong

The serial length was one digit too short, resulting in missing digits at the end of the certificate's stringified serial number.

ssl_verify_polarssl.c | 2 +- 1 files changed, 1 insertions(+), 1
deletions(-)

ACK! Applied to master branches on -testing and -stable git trees.

commit 6a47aa0a975d219c2cddab33dc43f75f983957ca

Author: Adriaan de Jong <[email protected]...>
Date:   Tue Feb 28 17:29:47 2012 +0100
    Signed-off-by: Adriaan de Jong <[email protected]...>
    Acked-by: David Sommerseth <[email protected]...>
    Signed-off-by: David Sommerseth <[email protected]...>

kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk90Wf8ACgkQDC186MBRfrp9IgCgh7g/eC6/HTuebxZ4HrfWlyUX JksAn0zCkhJ2z76lNUhh4onVeBa3N5wt
=G7u2
-----END PGP SIGNATURE-----