Skip to contentSkip to conversation

sound/soc/lapis: add machine driver for ML7213 Carrier Board

PATCH In review Tomoya MORINAGA 2 participants 2 messages Mar 21, 2012

Subsystems (2)
Sound ASoC
lore
Share & tools
lore

Tomoya MORINAGA

author
#0 lore raw

PATCH v8 1/1 sound/soc/lapis: add machine driver for ML7213 Carrier Board

This machine driver is for
LAPIS Semiconductor ML7213 Carrier Board + ML26124 Reference Board

Signed-off-by Tomoya MORINAGA <[email protected]>

---
v8
- Delete redundant break
- Use module_platform_driver
- Delete redundant 'space'
- Delete snd_soc_dapm_enable_pin()s

---
 sound/soc/lapis/Kconfig             |    7 ++
 sound/soc/lapis/Makefile            |    2 +
 sound/soc/lapis/ml7213ioh-machine.c |  169 +++++++++++++++++++++++++++++++++++
 3 files changed, 178 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/lapis/ml7213ioh-machine.c
sound/soc/lapis/Kconfig +7 -0
index 551e385..9bc1b4d 100644
@@ -2,3 +2,10 @@ config SND_SOC_ML7213_PLATFORM
 	tristate "ML7213 IOH ASoC platform driver"
 	help
 	  This option enables support for the AC Link Controllers in ML7213 IOH SoC.
+
+config SND_SOC_ML7213_MACHINE
+	tristate "ML7213 IOH ASoC machine driver"
+	select SND_SOC_ML7213_PLATFORM
+	select SND_SOC_ML26124
+	help
+	  This is ASoC machine driver for ML7213 IOH
sound/soc/lapis/Makefile +2 -0
index aba1630..7ec4bea 100644
@@ -1,4 +1,6 @@
 # Platform
+snd-soc-ml7213-machine-objs := ml7213ioh-machine.o
 snd-soc-ml7213-plat-objs := ml7213ioh-plat.o
 
 obj-$(CONFIG_SND_SOC_ML7213_PLATFORM) += snd-soc-ml7213-plat.o
+obj-$(CONFIG_SND_SOC_ML7213_MACHINE) += snd-soc-ml7213-machine.o
sound/soc/lapis/ml7213ioh-machine.c new file +169 -0

169 lines not on this page · raw message

Signature · 1 line
1.7.7.6
#1 lore raw
Quoted 2 lines · Tomoya MORINAGA

This machine driver is for
LAPIS Semiconductor ML7213 Carrier Board + ML26124 Reference Board

This looks good but obviously needs the platform before it can be merged. One fairly minor thing:

sound/soc/lapis/ml7213ioh-machine.c line 79

Quoted 3 lines
sound/soc/lapis/ml7213ioh-machine.c new file +2 -0
+	mclkfs = clk / params_rate(hw_params);
 
+		bclkfs = 32;

You no longer use either mclkfs or bclkfs so you could just delete the code that calculates them - the DAI drivers will work this stuff out for you now so the machine driver doesn't need to.