Skip to contentSkip to conversation

libcgroup: fix QA warnings

PATCH Superseded Andreas Müller 3 participants 7 messages Mar 27, 2012 – Mar 28, 2012

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 libcgroup: fix QA warnings

fix the following warnings:

WARNING: For recipe libcgroup, the following files/directories were installed but not shipped in any package:
WARNING:   /lib/security/pam_cgroup.la
WARNING:   /lib/security/.debug
WARNING:   /lib/security/.debug/pam_cgroup.so.0.0.0
WARNING:   /lib/security/.debug/pam_cgroup.so
WARNING:   /lib/security/.debug/pam_cgroup.so.0
---
 meta-oe/recipes-core/libcgroup/libcgroup_0.37.1.bb |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
meta-oe/recipes-core/libcgroup/libcgroup_0.37.1.bb +4 -0
index 91829fa..68eef2a 100644
@@ -3,6 +3,8 @@ SECTION = "libs"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=2d5025d4aa3495befef8f17206a5b0a1"
 
+PR = "r1"
+
 inherit autotools pkgconfig
 
 DEPENDS = "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
@@ -18,6 +20,8 @@ PARALLEL_MAKE = ""
 
 PACKAGES =+ "cgroups-pam-plugin"
 FILES_cgroups-pam-plugin = "${base_libdir}/security/pam_cgroup.so*"
+FILES_${PN}-dbg += "${base_libdir}/security/.debug"
+FILES_${PN}-staticdev = "${base_libdir}/security/*.la"
 
 # We really need the symlink so :(
 ERROR_QA = "debug-deps dev-deps debug-files arch la2 pkgconfig la perms"
Signature · 1 line
1.7.6.5
#1 lore raw

PATCH 2/4 faad2: fix QA warnings

fix the following warnings:
WARNING: QA Issue: non -staticdev package contains static .a library: libfaad-dev path '/work/armv7a-angstrom-linux-gnueabi/faad2-2.7-r1/packages-split/libfaad-dev/usr/lib/libfaad.a'
WARNING: QA Issue: non -staticdev package contains static .a library: libmp4ff-dev path '/work/armv7a-angstrom-linux-gnueabi/faad2-2.7-r1/packages-split/libmp4ff-dev/usr/lib/libmp4ff.a'

---
 meta-oe/recipes-multimedia/faad2/faad2_2.7.bb |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)
meta-oe/recipes-multimedia/faad2/faad2_2.7.bb +6 -2
index 462837f..855299c 100644
@@ -4,6 +4,8 @@ LICENSE = "GPLv2"
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=381c8cbe277a7bc1ee2ae6083a04c958"
 
+PR = "r1"
+
 inherit autotools
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/faac/faad2-src/faad2-${PV}/${PN}-${PV}.tar.bz2;name=faad2 \
@@ -17,8 +19,10 @@ PACKAGES =+ "libfaad libfaad-dev libmp4ff libmp4ff-dev"
 FILES_${PN} = "${bindir}/faad"
 
 FILES_libfaad = "${libdir}/libfaad.so.*"
-FILES_libfaad-dev = "${libdir}/libfaad.so ${libdir}/libfaad.la ${libdir}/libfaad.a ${includedir}/faad.h"
+FILES_libfaad-dev = "${libdir}/libfaad.so ${libdir}/libfaad.la ${includedir}/faad.h"
+FILES_libfaad-staticdev = "${libdir}/libfaad.a"
 
 FILES_libmp4ff = "${libdir}/libmp4ff.so.*"
-FILES_libmp4ff-dev = "${libdir}/libmp4ff.so ${libdir}/libmp4ff.la ${libdir}/libmp4ff.a ${includedir}/mp4ff.h"
+FILES_libmp4ff-dev = "${libdir}/libmp4ff.so ${libdir}/libmp4ff.la ${includedir}/mp4ff.h"
+FILES_libmp4ff-staticdev = "${libdir}/libmp4ff.a"
 
Signature · 1 line
1.7.6.5
#2 lore raw

PATCH 3/4 libatasmart: fix QA warnings

In reply to Andreas Müller

fix the following warnings:

WARNING: For recipe libatasmart, the following files/directories were installed but not shipped in any package:
WARNING:   /usr/share/vala
WARNING:   /usr/share/vala/vapi
WARNING:   /usr/share/vala/vapi/atasmart.vapi
---
 .../libatasmart/libatasmart_0.17.bb                |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
meta-oe/recipes-support/libatasmart/libatasmart_0.17.bb +5 -0
index c8f75f8..6162b58 100644
@@ -2,6 +2,8 @@ DESCRIPTION = "ATA S.M.A.R.T. Reading and Parsing Library"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://LGPL;md5=2d5025d4aa3495befef8f17206a5b0a1"
 
+PR = "r1"
+
 DEPENDS = "udev"
 
 SRCREV = "v${PV}"
@@ -15,3 +17,6 @@ inherit autotools lib_package
 do_install_append() {
 	sed -i -e s://:/:g -e 's:=${libdir}/libudev.la:-ludev:g' ${D}${libdir}/libatasmart.la
 }
+
+PACKAGES =+ "${PN}-dev-vala"
+FILES_${PN}-dev-vala = "${datadir}/vala"
Signature · 1 line
1.7.6.5
#3 lore raw

PATCH 4/4 obexd: fix QA warnings

In reply to Andreas Müller

fix the following warnings:

WARNING: For recipe obexd, the following files/directories were installed but not shipped in any package:
WARNING:   /usr/lib
WARNING:   /usr/lib/obex
WARNING:   /usr/lib/obex/plugins
---
 meta-oe/recipes-connectivity/obex/obexd_0.44.bb |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
meta-oe/recipes-connectivity/obex/obexd_0.44.bb +7 -0
index 24edb9d..c53bfdc 100644
@@ -4,12 +4,19 @@ DEPENDS = "openobex glib-2.0 dbus bluez4 libical"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "files://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e"
 
+PR = "r1"
+
 SRC_URI = "http://www.kernel.org/pub/linux/bluetooth/obexd-${PV}.tar.gz"
 SRC_URI[md5sum] = "3fb9cb9d7ab119753253ff784235a364"
 SRC_URI[sha256sum] = "104fc50eb8bf41d690d31588c3a4829a75dc7738b1c76cf260171d8f525da758"
 
 inherit autotools
 
+do_install_append() {
+    # remove empty plugins dir
+    rm -rf ${D}${libdir}
+}
+
 PACKAGES =+ "obex-client"
 
 FILES_${PN} += "${datadir}/dbus-1/services/${PN}.service"
Signature · 1 line
1.7.6.5
#4 lore raw

Re: [PATCH 4/4] obexd: fix QA warnings

meta-oe/recipes-connectivity/obex/obexd_0.44.bb DEPENDS = "openobex glib-2.0 dbus bluez4 libical" · line 19

Quoted 5 lines · Andreas Müller
meta-oe/recipes-connectivity/obex/obexd_0.44.bb +5 -0
+do_install_append() {
+    # remove empty plugins dir
+    rm -rf ${D}${libdir}
+}
+

can you use use rmdir instead so it gets flagged when the dir is not empty ?

#5 lore raw

Re: [PATCH 4/4] obexd: fix QA warnings

Quoted 10 lines · Khem Raj

meta-oe/recipes-connectivity/obex/obexd_0.44.bb DEPENDS = "openobex glib-2.0 dbus bluez4 libical" · line 19

Quoted 5 lines · Andreas M??ller
meta-oe/recipes-connectivity/obex/obexd_0.44.bb +5 -0
+do_install_append() {
+    # remove empty plugins dir
+    rm -rf ${D}${libdir}
+}
+

can you use use rmdir instead so it gets flagged when the dir is not empty ?

Can we instead create obex-plugins in PACKAGES, even if it's empty now?

Signature · 1 line
Denys