Skip to contentSkip to conversation

ASoC: sgtl5000: Fix warning due to the lack of REGULATOR_CHANGE_VOLTAGE

PATCH Superseded Fabio Estevam 2 participants 4 messages Apr 3, 2012

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Fabio Estevam

author maintainer
#0 lore raw

PATCH 1/1 ASoC: sgtl5000: Fix warning due to the lack of REGULATOR_CHANGE_VOLTAGE

Fix the following warning during kernel boot:

0-000a: 850 <--> 1600 mV at 1200 mV normal 0-000a: Voltage range but no REGULATOR_CHANGE_VOLTAGE

---
 sound/soc/codecs/sgtl5000.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
sound/soc/codecs/sgtl5000.c +2 -1
index 8e92fb8..bad5ba5 100644
@@ -87,7 +87,8 @@ static struct regulator_init_data ldo_init_data = {
 		.min_uV                 = 850000,
 		.max_uV                 = 1600000,
 		.valid_modes_mask       = REGULATOR_MODE_NORMAL,
-		.valid_ops_mask         = REGULATOR_CHANGE_STATUS,
+		.valid_ops_mask         = REGULATOR_CHANGE_VOLTAGE  |
+						REGULATOR_CHANGE_STATUS,
 	},
 	.num_consumer_supplies = 1,
 	.consumer_supplies = &ldo_consumer[0],
Signature · 1 line
1.7.1
#1 lore raw
Quoted 4 lines · Fabio Estevam

Fix the following warning during kernel boot:

0-000a: 850 <--> 1600 mV at 1200 mV normal 0-000a: Voltage range but no REGULATOR_CHANGE_VOLTAGE

Are you sure this is the best fix? There's no set_voltage() call in the driver.

author maintainer
#2 lore raw
Quoted 8 lines · Mark Brown
Quoted 4 lines · Fabio Estevam

Fix the following warning during kernel boot:

0-000a: 850 <--> 1600 mV at 1200 mV normal 0-000a: Voltage range but no REGULATOR_CHANGE_VOLTAGE

Are you sure this is the best fix?  There's no set_voltage() call in the driver.

Sorry, I was not able to understand your last comment.

How do you suggest me to fix this, please?
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#3 lore raw
Quoted 8 lines · Fabio Estevam

On Tue, Apr 3, 2012 at 5:37 PM, Mark Brown

Quoted 2 lines

Are you sure this is the best fix?  There's no set_voltage() call in the driver.

Sorry, I was not able to understand your last comment.

How do you suggest me to fix this, please?

I was wondering if it might be better to remove the voltage range if the driver doesn't ever actually set the voltage rather than adding an unused permission to change it.