scsi/ufs: likely || misuse

DISCUSSION Joe Perches 2 participants 2 messages Apr 4, 2012 – Apr 6, 2012

lore

Share & tools

lore

Joe Perches

author

2012-04-04 23:46 UTC #0 lore raw

Probably this should be && not ||

drivers/scsi/ufs/ufshcd.c: if (task_result != UPIU_TASK_MANAGEMENT_FUNC_COMPL ||

		    task_result != UPIU_TASK_MANAGEMENT_FUNC_SUCCEEDED)

Santosh Y

2012-04-06 09:07 UTC #1 lore raw

Quoted 5 lines · Joe Perches

Probably this should be && not ||
drivers/scsi/ufs/ufshcd.c: if (task_result != UPIU_TASK_MANAGEMENT_FUNC_COMPL || task_result != UPIU_TASK_MANAGEMENT_FUNC_SUCCEEDED)

Somehow missed this email. Thanks Joe. I see Venkatraman has posted a patch with the changes.

Signature · 1 line

~Santosh